From unknown Sun Jun 22 11:33:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#10332 <10332@debbugs.gnu.org> To: bug#10332 <10332@debbugs.gnu.org> Subject: Status: battery.el not working when multiple batteries are present Reply-To: bug#10332 <10332@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:33:55 +0000 retitle 10332 battery.el not working when multiple batteries are present reassign 10332 emacs submitter 10332 Dan Nicolaescu severity 10332 normal tag 10332 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 17:38:00 2011 Received: (at submit) by debbugs.gnu.org; 19 Dec 2011 22:38:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RclqK-0001QH-6B for submit@debbugs.gnu.org; Mon, 19 Dec 2011 17:38:00 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RclqI-0001QB-Dx for submit@debbugs.gnu.org; Mon, 19 Dec 2011 17:37:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcloQ-0008Uh-Mh for submit@debbugs.gnu.org; Mon, 19 Dec 2011 17:36:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=5.0 tests=ALL_TRUSTED,BAYES_00, RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:58457) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcloQ-0008Ud-LF for submit@debbugs.gnu.org; Mon, 19 Dec 2011 17:36:02 -0500 Received: from eggs.gnu.org ([140.186.70.92]:35549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcloP-0001jx-OS for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2011 17:36:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcloO-0008UQ-OV for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2011 17:36:01 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:37861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcloO-0008UM-LX for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2011 17:36:00 -0500 Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RcloO-00018y-Em for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2011 17:36:00 -0500 From: Dan Nicolaescu To: bug-gnu-emacs@gnu.org Subject: battery.el not working when multiple batteries are present Date: Mon, 19 Dec 2011 17:36:00 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) On a machine that has a normal battery and another one that can be put in the CD/DVD slot M-x battery does not work when both batteries are present. Only one battery is discharged at a time, but that seems to confuse battery.el when computing `rate-type' for the battery not being discharged. Here's a proposed patch. === modified file 'lisp/battery.el' --- lisp/battery.el 2011-10-19 12:54:24 +0000 +++ lisp/battery.el 2011-10-20 21:40:57 +0000 @@ -337,14 +337,15 @@ (setq charging-state (match-string 1))) (when (re-search-forward "present rate: +\\([0-9]+\\) \\(m[AW]\\)$" nil t) - (setq rate (+ (or rate 0) (string-to-number (match-string 1))) - rate-type (or (and rate-type + (setq rate (+ (or rate 0) (string-to-number (match-string 1)))) + (when (> rate 0) + (setq rate-type (or (and rate-type (if (string= rate-type (match-string 2)) rate-type (error "Inconsistent rate types (%s vs. %s)" rate-type (match-string 2)))) - (match-string 2)))) + (match-string 2))))) (when (re-search-forward "remaining capacity: +\\([0-9]+\\) m[AW]h$" nil t) (setq capacity From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 10 19:26:28 2012 Received: (at 10332) by debbugs.gnu.org; 10 Apr 2012 23:26:28 +0000 Received: from localhost ([127.0.0.1]:49515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHkS9-0004U9-NK for submit@debbugs.gnu.org; Tue, 10 Apr 2012 19:26:28 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:50037) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHkS6-0004Tw-UF for 10332@debbugs.gnu.org; Tue, 10 Apr 2012 19:26:24 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SHkQy-0002MZ-GZ; Wed, 11 Apr 2012 01:25:12 +0200 From: Lars Magne Ingebrigtsen To: Dan Nicolaescu Subject: Re: bug#10332: battery.el not working when multiple batteries are present References: X-Now-Playing: The Birthday Party with Lydia Lunch's _Welcome to the Car Smash..._: "Pleasure Heads" Date: Wed, 11 Apr 2012 01:25:11 +0200 In-Reply-To: (Dan Nicolaescu's message of "Mon, 19 Dec 2011 17:36:00 -0500") Message-ID: User-Agent: Gnus/5.130004 (Ma Gnus v0.4) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1SHkQy-0002MZ-GZ X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334705112.57449@Ojm64MGlVAZLXJkCrkMZsA X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10332 Cc: 10332@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Dan Nicolaescu writes: > On a machine that has a normal battery and another one that can be put > in the CD/DVD slot M-x battery does not work when both batteries are > present. > > Only one battery is discharged at a time, but that seems to confuse > battery.el when computing `rate-type' for the battery not being > discharged. I don't use battery.el, but the patch looks sensible to me, so I've applied it to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 10 19:26:28 2012 Received: (at control) by debbugs.gnu.org; 10 Apr 2012 23:26:29 +0000 Received: from localhost ([127.0.0.1]:49517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHkSC-0004UI-Hr for submit@debbugs.gnu.org; Tue, 10 Apr 2012 19:26:28 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:50043) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHkS9-0004U8-DT for control@debbugs.gnu.org; Tue, 10 Apr 2012 19:26:26 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SHkR1-0002Mg-Oq for control@debbugs.gnu.org; Wed, 11 Apr 2012 01:25:15 +0200 Date: Wed, 11 Apr 2012 01:25:15 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #10332 X-MailScanner-ID: 1SHkR1-0002Mg-Oq X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1334705116.26943@3x6ODj9k6us3c+r420C2ug X-Spam-Status: No X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) tags 10332 fixed close 10332 24.2 From unknown Sun Jun 22 11:33:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 09 May 2012 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator