GNU bug report logs - #1032
foreground-color in default-frame-alist affects tooltips, while background-color does not

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 1032 <at> debbugs.gnu.org
Subject: bug#1032: foreground-color in default-frame-alist affects tooltips, while background-color does not
Date: Fri, 26 Sep 2008 17:14:28 +0200

[Message part 1 (text/plain, inline)]

> With
> 
> (setq default-frame-alist
>       '((background-mode  . dark)
> 	(background-color . "black")
> 	(foreground-color . "white")))
> 
> the tooltip text foreground is white, but the background is still the
> default lightyellow, so the text is not visible.

Does the attached patch fix it?

martin

[1032.diff (text/plain, inline)]

*** w32fns.c.~1.347.~	2008-09-19 23:24:49.062500000 +0200
--- w32fns.c	2008-09-26 17:10:10.953125000 +0200
***************
*** 5532,5546 ****
       attribute of the frame get's set, which let's the internal border
       of the tooltip frame appear in pink.  Prevent this.  */
    {
      Lisp_Object bg = Fframe_parameter (frame, Qbackground_color);
  
      /* Set tip_frame here, so that */
      tip_frame = frame;
      call2 (Qface_set_after_frame_default, frame, Qnil);
  
!     if (!EQ (bg, Fframe_parameter (frame, Qbackground_color)))
!       Fmodify_frame_parameters (frame, Fcons (Fcons (Qbackground_color, bg),
! 					      Qnil));
    }
  
    f->no_split = 1;
--- 5532,5549 ----
       attribute of the frame get's set, which let's the internal border
       of the tooltip frame appear in pink.  Prevent this.  */
    {
+     Lisp_Object fg = Fframe_parameter (frame, Qforeground_color);
      Lisp_Object bg = Fframe_parameter (frame, Qbackground_color);
  
      /* Set tip_frame here, so that */
      tip_frame = frame;
      call2 (Qface_set_after_frame_default, frame, Qnil);
  
!     if (!EQ (bg, Fframe_parameter (frame, Qbackground_color))
! 	|| !EQ (fg, Fframe_parameter (frame, Qforeground_color)))
! 	Fmodify_frame_parameters (frame, (Fcons (Qforeground_color, fg),
! 					  (Fcons (Qbackground_color, bg),
! 					   Qnil)));
    }
  
    f->no_split = 1;

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.