GNU bug report logs - #10317
patch to su: -l and -p should not be used together

Previous Next

Full log

View this message in rfc822 format

From: Rocky Bernstein <rocky <at> gnu.org>
To: Jim Meyering <jim <at> meyering.net>
Cc: 10317 <at> debbugs.gnu.org
Subject: bug#10317: PING - bug#10317: patch to su: -l and -p should not be used together
Date: Thu, 12 Apr 2012 22:43:44 -0400

[Message part 1 (text/plain, inline)]

On Sat, Apr 7, 2012 at 2:15 AM, Jim Meyering <jim <at> meyering.net> wrote:

> Rocky Bernstein wrote:
> > Any progress or thoughts on the revised patch?
>
> Hi Rocky,
> Sorry about the delay.
> I haven't forgotten.
>
> I noticed that your test requires typing a root password.
>

Um, no. I don't know how you got that impression, but did you try running
the test as a non-root or non-privileged user?

Here is what I got when I just tried:

$ (cd tests && make check TESTS=su/p-and-l)
make  check-TESTS
make[1]: Entering directory `/src/external-vcs/coreutils/tests'
make[2]: Entering directory `/src/external-vcs/coreutils/tests'
PASS: su/p-and-l
=============
1 test passed
=============

(Sorry for the delay - I wrote this long enough ago that  I didn't remember
what I did and only now have I had the time to review.)





We prefer to avoid that, so that the tests can be run
> non-interactively.  That's why some tests are root-only.
> (see README for details on running them)
> They're marked with require_root_.
> At least one is a bourne shell husk that actually does
> its work in Perl, so may be a good model.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.