GNU bug report logs - #10317
patch to su: -l and -p should not be used together

Previous Next

Package: coreutils;

Reported by: Rocky Bernstein <rocky <at> gnu.org>

Date: Sat, 17 Dec 2011 22:29:01 UTC

Severity: normal

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 10317 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Rocky Bernstein <rocky <at> gnu.org>
Cc: 10317 <at> debbugs.gnu.org
Subject: Re: bug#10317: PING - bug#10317: patch to su: -l and -p should not be
	used together
Date: Mon, 13 Feb 2012 10:19:44 +0100

Rocky Bernstein wrote:
> It's been a couple of months since I first sent this was sent without nary
> an ack. Comments?

Hi Rocky,

su is barely on life support in coreutils.
Meaning that it's no longer really maintained.
We stopped installing it (by default) back in the 2007-2008
time frame (6.9.90, 7.0).  We nearly removed it altogether.

Do you build/install coreutils yourself, or use it via a distribution?
If the latter, which distribution?

I don't remember looking carefully at your patch before,
but glanced through it just now.  Here are some suggestions
if you'd like to pursue it:

  - use "error (0, 0, ...", not fprintf (
  - indent with spaces, not TABs
  - use gnu indentation/formatting style (esp. wrt braces)
  - mention the change in NEWS
  - for a behavior change like this, we would like a test case
This bug report was last modified 6 years and 281 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.