From unknown Thu Jun 19 13:53:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#1027 <1027@debbugs.gnu.org> To: bug#1027 <1027@debbugs.gnu.org> Subject: Status: 23.0.60; pcomplete/rpm does not complete "rpm -qip filepath" Reply-To: bug#1027 <1027@debbugs.gnu.org> Date: Thu, 19 Jun 2025 20:53:19 +0000 retitle 1027 23.0.60; pcomplete/rpm does not complete "rpm -qip filepath" reassign 1027 emacs submitter 1027 Jens Petersen severity 1027 normal tag 1027 patch thanks From petersen@redhat.com Thu Sep 25 17:57:43 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.8 required=4.0 tests=BAYES_00,MURPHY_WRONG_WORD2, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 26 Sep 2008 00:57:43 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8Q0vdrC031831 for ; Thu, 25 Sep 2008 17:57:41 -0700 Received: from mx10.gnu.org ([199.232.76.166]:55158) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kj1cK-0004cg-8C for emacs-pretest-bug@gnu.org; Thu, 25 Sep 2008 20:55:32 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kj1eL-00071h-Rr for emacs-pretest-bug@gnu.org; Thu, 25 Sep 2008 20:57:38 -0400 Received: from mx1.redhat.com ([66.187.233.31]:53725) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kj1eL-00071Z-JU for emacs-pretest-bug@gnu.org; Thu, 25 Sep 2008 20:57:37 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m8Q0vZQg016898 for ; Thu, 25 Sep 2008 20:57:35 -0400 Received: from dhcp-0-235.bne.redhat.com (dhcp-0-235.bne.redhat.com [10.64.0.235]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m8Q0vWCL005397; Thu, 25 Sep 2008 20:57:33 -0400 Received: from dhcp-0-235.bne.redhat.com (localhost.localdomain [127.0.0.1]) by dhcp-0-235.bne.redhat.com (8.14.2/8.14.1) with ESMTP id m8Q0vV8r002314; Fri, 26 Sep 2008 10:57:31 +1000 Received: (from petersen@localhost) by dhcp-0-235.bne.redhat.com (8.14.2/8.14.2/Submit) id m8Q0vU0D002312; Fri, 26 Sep 2008 10:57:30 +1000 Date: Fri, 26 Sep 2008 10:57:30 +1000 Message-Id: <200809260057.m8Q0vU0D002312@dhcp-0-235.bne.redhat.com> From: Jens Petersen To: emacs-pretest-bug@gnu.org Subject: 23.0.60; pcomplete/rpm does not complete "rpm -qip filepath" X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Hi, In eshell, pcomplete/rpm does not handle the -p (file) option well currently: eg "rpm -q -p filepath..." completes but not "rpm -qp filepath...". Here is an improvement which at least checks the first argument for a -p option, so that "rpm -qp", "rpm --qp --changelog", etc all file complete rather than querying the rpm database. I think this is good enough for now, though strictly all args should be checked for a -p option. Jens 2008-09-26 Jens Petersen * pcmpl-rpm.el (pcomplete/rpm): Make "rpm -qp" use file completion. Index: lisp/pcmpl-rpm.el =================================================================== RCS file: /sources/emacs/emacs/lisp/pcmpl-rpm.el,v retrieving revision 1.13 diff -u -r1.13 pcmpl-rpm.el --- lisp/pcmpl-rpm.el 6 May 2008 07:57:45 -0000 1.13 +++ lisp/pcmpl-rpm.el 26 Sep 2008 00:22:31 -0000 @@ -135,7 +135,9 @@ (pcmpl-rpm-all-query "--requires"))))) (if (pcomplete-match "^-" 0) (pcomplete-opt "af.p(pcmpl-rpm-files)ilsdcvR") - (pcomplete-here (pcmpl-rpm-packages))))) + (if (pcomplete-test "-[^-]*p" 'first 1) + (pcomplete-here (pcmpl-rpm-files)) + (pcomplete-here (pcmpl-rpm-packages)))))) ((pcomplete-test "--pipe") (pcomplete-here* (funcall pcomplete-command-completion-function))) ((pcomplete-test "--rmsource") From rgm@gnu.org Thu Sep 25 21:04:15 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.5 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,RCVD_IN_DNSWL_MED,VALID_BTS_CONTROL, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 26 Sep 2008 04:04:16 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8Q44DWA012781 for ; Thu, 25 Sep 2008 21:04:14 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Kj4Wr-0003Ba-Uw; Fri, 26 Sep 2008 00:02:05 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18652.24253.895094.969061@fencepost.gnu.org> Date: Fri, 26 Sep 2008 00:02:05 -0400 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: green X-Ran: f$HThOU'D(xR[CYsue&c(wS1NB$$-+()v>*j5mba6Zxw%l#,cuJ~EIj:0; Thu, 23 Oct 2008 15:09:52 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 89D0257E055; Thu, 23 Oct 2008 18:09:54 -0400 (EDT) From: Chong Yidong To: Jens Petersen Cc: 1027-done@debbugs.gnu.org Subject: Re: 23.0.60; pcomplete/rpm does not complete "rpm -qip filepath" Date: Thu, 23 Oct 2008 18:09:54 -0400 Message-ID: <87d4hrrmj1.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > In eshell, pcomplete/rpm does not handle the -p (file) option well > currently: > > eg "rpm -q -p filepath..." completes but not "rpm -qp filepath...". > > Here is an improvement which at least checks the first argument for a > -p option, so that "rpm -qp", "rpm --qp --changelog", etc all file > complete rather than querying the rpm database. I think this is good > enough for now, though strictly all args should be checked for a -p > option. Thanks. I've checked in the patch. From unknown Thu Jun 19 13:53:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 Nov 2008 15:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator