From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 06:11:26 2011 Received: (at submit) by debbugs.gnu.org; 10 Dec 2011 11:11:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RZKpy-0000qG-A5 for submit@debbugs.gnu.org; Sat, 10 Dec 2011 06:11:26 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RZKpu-0000q0-IN for submit@debbugs.gnu.org; Sat, 10 Dec 2011 06:11:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RZKov-0007xQ-AZ for submit@debbugs.gnu.org; Sat, 10 Dec 2011 06:10:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:54074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RZKov-0007xK-90 for submit@debbugs.gnu.org; Sat, 10 Dec 2011 06:10:21 -0500 Received: from eggs.gnu.org ([140.186.70.92]:36099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RZKou-00027o-AU for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2011 06:10:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RZKot-0007x5-9M for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2011 06:10:20 -0500 Received: from mail-yx0-f169.google.com ([209.85.213.169]:55631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RZKot-0007x1-5k for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2011 06:10:19 -0500 Received: by yenq10 with SMTP id q10so3876117yen.0 for ; Sat, 10 Dec 2011 03:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=XqBqZy/k11cqRg7uYtZFE+AVS0TRvgGbWHxilfCBkxw=; b=A5rYCK7xbgg9hHFaqm3GFKpU8GLhiHOkvmxe6umKPxnzov3Ma7oZykDHv0haqAN7OQ FxP63SJoarUXCZAuWqJqEZib2QB95Kx9WtzjdmOIHmmdzUKx3GXqwx0Wav2VPbgQuteO WSp/QwVhoijAPG41Su/4YGDKzbcWyDvjaWsFc= MIME-Version: 1.0 Received: by 10.236.192.135 with SMTP id i7mr17488137yhn.13.1323515418850; Sat, 10 Dec 2011 03:10:18 -0800 (PST) Received: by 10.236.34.231 with HTTP; Sat, 10 Dec 2011 03:10:18 -0800 (PST) Date: Sat, 10 Dec 2011 12:10:18 +0100 Message-ID: Subject: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) Hi, After bootstrapping Emacs on my system (MS-Windows 7 64-bit; mingw32), if I try the "dist" target (mingw32-make dist), I get this error: --------------------------------------[...]cp -rf "C:/emacs/trunk/nt/../leim" emacs-24.0.92 cp -rf "C:/emacs/trunk/nt/../site-lisp" emacs-24.0.92 cp -rf emacs-24.0.92/bin cp: missing destination file operand after `emacs-24.0.92/bin' Try `cp --help' for more information. mingw32-make: *** [dist] Error 1 -------------------------------------- Looking at the file "nt/makefile", the failing sentence seems to be this one: $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin The problem is that `$(DIST_FILES)' expands to nothing, because I specified no "--distfiles" argument to configure.bat. =A0In fact, if I comment out that line, everything seem to go fine. Therefore, I request to allow making a binary distribution even in this case, i.e., that the above-mentioned like of nt/makefile was not written by the configure script when there is no --distfiles arguments. TIA In GNU Emacs 24.0.92.1 (i386-mingw-nt6.1.7601) of 2011-12-09 on DANI-PC Windowing system distributor `Microsoft Corp.', version 6.1.7601 configured using `configure --with-gcc (4.6) --no-opt --cflags -fno-omit-frame-pointer' --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 06:26:29 2011 Received: (at 10261) by debbugs.gnu.org; 10 Dec 2011 11:26:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RZL4X-0001Vl-Bq for submit@debbugs.gnu.org; Sat, 10 Dec 2011 06:26:29 -0500 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RZL4U-0001VY-Ll for 10261@debbugs.gnu.org; Sat, 10 Dec 2011 06:26:27 -0500 Received: by ghrr18 with SMTP id r18so3052281ghr.3 for <10261@debbugs.gnu.org>; Sat, 10 Dec 2011 03:25:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; bh=CzijZV8peNY8AgOcmHGYiug0wsQJwsPivAJTawoO7P0=; b=Y55BXCygrquMsEr1/HViaXVcAtpPsQLmBI9bdE6BYVZtNPbvLO2TQJPLPAdWkLhuwy ahuON4mfcJW3Q+dQ4YFjgtGoQUm7G/htH6zdLTs6WqCXZ9m9fNAJe05Br6vMTfpUGbOb c82EYLNmlrOrS3cLx9HAQMm6wfpoPvN2F4AjU= MIME-Version: 1.0 Received: by 10.236.192.135 with SMTP id i7mr17554616yhn.13.1323516325884; Sat, 10 Dec 2011 03:25:25 -0800 (PST) Received: by 10.236.34.231 with HTTP; Sat, 10 Dec 2011 03:25:25 -0800 (PST) In-Reply-To: References: Date: Sat, 10 Dec 2011 12:25:25 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: 10261@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 10261 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) [Sorry, the OP is badly formatted, due to some "feature" of GMail. Here is the message again, hopefully well formatted]. After bootstrapping Emacs on my system (MS-Windows 7 64-bit; mingw32), if I try the "dist" target (mingw32-make dist), I get this error: -------------------------------------- [...] cp -rf "C:/emacs/trunk/nt/../leim" emacs-24.0.92 cp -rf "C:/emacs/trunk/nt/../site-lisp" emacs-24.0.92 cp -rf =A0emacs-24.0.92/bin cp: missing destination file operand after `emacs-24.0.92/bin' Try `cp --help' for more information. mingw32-make: *** [dist] Error 1 -------------------------------------- Looking at the file "nt/makefile", the failing sentence seems to be this on= e: =A0$(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin The problem is that `$(DIST_FILES)' expands to nothing, because I specified no "--distfiles" argument to configure.bat. =A0In fact, if I comment out that line, everything seem to go fine. Therefore, I request to allow making a binary distribution even in this case, i.e., that the above-mentioned like of nt/makefile was not written by the configure script when there is no --distfiles arguments. TIA. In GNU Emacs 24.0.92.1 (i386-mingw-nt6.1.7601) =A0of 2011-12-09 on DANI-PC Windowing system distributor `Microsoft Corp.', version 6.1.7601 configured using `configure --with-gcc (4.6) --no-opt --cflags -fno-omit-frame-pointer' --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 09:33:16 2011 Received: (at 10261) by debbugs.gnu.org; 10 Dec 2011 14:33:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RZNzI-0001x4-3w for submit@debbugs.gnu.org; Sat, 10 Dec 2011 09:33:16 -0500 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RZNzF-0001wp-0t for 10261@debbugs.gnu.org; Sat, 10 Dec 2011 09:33:13 -0500 Received: by iaek3 with SMTP id k3so5909923iae.3 for <10261@debbugs.gnu.org>; Sat, 10 Dec 2011 06:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=kMW5/n3kKI6Ra1e0qMaqy2fDqnBN6ScRAeu66ymoW68=; b=eOg1E7s3IZFP/hciIn/YuNIU2BaM6RtVDZv70KsrpHI6JWCGsbqQTwxZMeeKwYoXh1 +n0kR42hi0yTZtXWxRL2EBK9OLZpMAcYC3ZdH+xVeItf40EUjRaVgE8XFZYUTBZCcjep zRjaH46snnmHZDhTSp5HMumQYRHrXPdQ4bSPQ= Received: by 10.50.186.200 with SMTP id fm8mr7617542igc.93.1323527531035; Sat, 10 Dec 2011 06:32:11 -0800 (PST) Received: from [192.168.1.2] (71-208-65-52.hlrn.qwest.net. [71.208.65.52]) by mx.google.com with ESMTPS id 36sm24190627ibc.6.2011.12.10.06.32.09 (version=SSLv3 cipher=OTHER); Sat, 10 Dec 2011 06:32:09 -0800 (PST) Message-ID: <4EE36D66.7000506@gmail.com> Date: Sat, 10 Dec 2011 07:32:06 -0700 From: Christoph Scholtes User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Dani Moncayo Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 10261 Cc: 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) On 12/10/2011 4:25 AM, Dani Moncayo wrote: > Therefore, I request to allow making a binary distribution even in > this case, i.e., that the above-mentioned like of nt/makefile was not > written by the configure script when there is no --distfiles > arguments. I will look into it. Just out of curiosity, don't you want to package at least libXpm.dll in your distribution via ---distfiles? Christoph From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 10:07:53 2011 Received: (at 10261) by debbugs.gnu.org; 10 Dec 2011 15:07:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RZOWm-0003WR-Pr for submit@debbugs.gnu.org; Sat, 10 Dec 2011 10:07:53 -0500 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RZOWk-0003WF-2c for 10261@debbugs.gnu.org; Sat, 10 Dec 2011 10:07:51 -0500 Received: by ghrr18 with SMTP id r18so3129402ghr.3 for <10261@debbugs.gnu.org>; Sat, 10 Dec 2011 07:06:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=c6VxlASbzIQEsK+KwVeaJB01MKxV8np6oEtY27chGP0=; b=VsfGzlGzKOu7F6sAmhzDSFdj+UUVLmfCXxuS/+92fOQsQeSxmgaGpDmSfeUbKHkwYw R7mFicPN9sc1UgXwz7OIJK7Rg06rl9CcGu9EWJXE6YpWK4df1U839JnLllbXWLpJJ4g+ 0/0gtkIAkz7MPYnu+MRL8uGEDMMVH6hTS+jNU= MIME-Version: 1.0 Received: by 10.236.192.135 with SMTP id i7mr18608744yhn.13.1323529608532; Sat, 10 Dec 2011 07:06:48 -0800 (PST) Received: by 10.236.34.231 with HTTP; Sat, 10 Dec 2011 07:06:48 -0800 (PST) In-Reply-To: <4EE36D66.7000506@gmail.com> References: <4EE36D66.7000506@gmail.com> Date: Sat, 10 Dec 2011 16:06:48 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Christoph Scholtes Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 10261 Cc: 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) >> Therefore, I request to allow making a binary distribution even in >> this case, i.e., that the above-mentioned like of nt/makefile was not ^^^^ I meant "line". Sorry. >> written by the configure script when there is no --distfiles >> arguments. > > > I will look into it. Thank you. > Just out of curiosity, don't you want to package at least libXpm.dll in your > distribution via ---distfiles? Currently I have no need to package any library, even libXpm.dll. I use Emacs for editing text and source code, and I don't want to use toolbars (at all! :)), so I don't see why I would need that libraries. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 02 17:11:25 2012 Received: (at 10261) by debbugs.gnu.org; 2 Jan 2012 22:11:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rhq6H-00084A-8Q for submit@debbugs.gnu.org; Mon, 02 Jan 2012 17:11:25 -0500 Received: from mail-iy0-f172.google.com ([209.85.210.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rhq6F-000842-20 for 10261@debbugs.gnu.org; Mon, 02 Jan 2012 17:11:23 -0500 Received: by iabz21 with SMTP id z21so7638022iab.3 for <10261@debbugs.gnu.org>; Mon, 02 Jan 2012 14:08:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=679FN8utRKUy6NM7XxsM4tlMLXRZ/8PxwVp/NeiuOAw=; b=hLzNYHaE0ViTNknQG3bZiiv+htAiuPVVs+vfGgIelxJYPMj1fb1BUDzprBMC7WbFwi 2Ez2805jUaFWsbej6XRwmjPXJL0DyNi4nfaCLIo4uoxw7M3PJrFjjg1hM3PCji6TkLXd afOaVhw8eFnAAPpiySRAruWBuIvXWBBzUxovQ= Received: by 10.50.168.70 with SMTP id zu6mr48385689igb.13.1325542087309; Mon, 02 Jan 2012 14:08:07 -0800 (PST) Received: from [192.168.1.4] (174-29-203-215.hlrn.qwest.net. [174.29.203.215]) by mx.google.com with ESMTPS id r5sm71686069igl.3.2012.01.02.14.08.05 (version=SSLv3 cipher=OTHER); Mon, 02 Jan 2012 14:08:06 -0800 (PST) Message-ID: <4F022AC1.3000009@gmail.com> Date: Mon, 02 Jan 2012 15:08:01 -0700 From: Christoph Scholtes User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Dani Moncayo Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 10261 Cc: Eli Zaretskii , 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On 12/10/2011 4:25 AM, Dani Moncayo wrote: > The problem is that `$(DIST_FILES)' expands to nothing, because I > specified no "--distfiles" argument to configure.bat. In fact, if I > comment out that line, everything seem to go fine. > > Therefore, I request to allow making a binary distribution even in > this case, i.e., that the above-mentioned like of nt/makefile was not > written by the configure script when there is no --distfiles > arguments. The following patch should fix the problem. It only copies the dist files if any files were specified in the DIST_FILES variable via configure.bat. Eli, could you please review this to ensure that I am not over-complicating things. Thanks. === modified file 'nt/makefile.w32-in' --- nt/makefile.w32-in 2011-11-30 16:23:05 +0000 +++ nt/makefile.w32-in 2012-01-02 22:03:04 +0000 @@ -257,8 +257,22 @@ install-shortcuts: "$(INSTALL_DIR)/bin/addpm" -q -dist: install-bin - mkdir $(TMP_DIST_DIR) +maybe-copy-distfiles: maybe-copy-distfiles-$(SHELLTYPE) + +maybe-copy-distfiles-CMD: doit + @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin + +maybe-copy-distfiles-SH: doit + @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin + fi + +create-tmp-dist-dir: + mkdir "$(TMP_DIST_DIR)" +# Also create bin directory for dist files. + mkdir "$(TMP_DIST_DIR)/bin" + +dist: install-bin create-tmp-dist-dir maybe-copy-distfiles $(CP) "$(INSTALL_DIR)/BUGS" $(TMP_DIST_DIR) $(CP) "$(INSTALL_DIR)/COPYING" $(TMP_DIST_DIR) $(CP) "$(INSTALL_DIR)/README" $(TMP_DIST_DIR) @@ -269,7 +283,6 @@ $(CP_DIR) "$(INSTALL_DIR)/lisp" $(TMP_DIST_DIR) $(CP_DIR) "$(INSTALL_DIR)/leim" $(TMP_DIST_DIR) $(CP_DIR) "$(INSTALL_DIR)/site-lisp" $(TMP_DIST_DIR) - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin $(COMSPEC)$(ComSpec) /c $(ARGQUOTE)zipdist.bat $(VERSION)$(ARGQUOTE) $(DEL_TREE) $(TMP_DIST_DIR) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 17:46:56 2012 Received: (at 10261) by debbugs.gnu.org; 4 Feb 2012 22:46:56 +0000 Received: from localhost ([127.0.0.1]:54713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RtoNk-0005zu-1Q for submit@debbugs.gnu.org; Sat, 04 Feb 2012 17:46:56 -0500 Received: from mail-iy0-f172.google.com ([209.85.210.172]:46919) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RtoNg-0005zf-W8 for 10261@debbugs.gnu.org; Sat, 04 Feb 2012 17:46:54 -0500 Received: by iagf6 with SMTP id f6so7073951iag.3 for <10261@debbugs.gnu.org>; Sat, 04 Feb 2012 14:46:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=rclKst1BTCzXXhNCPyaMDUl5F2ab8xYi5W+J0d6VbVE=; b=UZs8B7YzkbTaf4PVuLXInR+1KvAyJTGi35BxOcGhBlG4TI8HTKRGVbcsi80jBqg2mq qadgdg4/Zai5/SCAI0V4XWHhgVgWsLXuoqh2LSB2eqQN4u684t5o/zLI9qRp9KHostPW g7kPUDVGmVcJTTtdTCA1cU/2mi3MdJSTavs5U= Received: by 10.50.202.97 with SMTP id kh1mr14776978igc.19.1328395566820; Sat, 04 Feb 2012 14:46:06 -0800 (PST) Received: from [192.168.1.2] (71-212-144-226.hlrn.qwest.net. [71.212.144.226]) by mx.google.com with ESMTPS id vr4sm10076307igb.1.2012.02.04.14.46.05 (version=SSLv3 cipher=OTHER); Sat, 04 Feb 2012 14:46:05 -0800 (PST) Message-ID: <4F2DB52C.30801@gmail.com> Date: Sat, 04 Feb 2012 15:46:04 -0700 From: Christoph Scholtes User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20120129 Thunderbird/10.0 MIME-Version: 1.0 To: Dani Moncayo Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option References: <4F022AC1.3000009@gmail.com> In-Reply-To: <4F022AC1.3000009@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10261 Cc: Eli Zaretskii , 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.3 (--) On 1/2/2012 3:08 PM, Christoph Scholtes wrote: > On 12/10/2011 4:25 AM, Dani Moncayo wrote: > >> The problem is that `$(DIST_FILES)' expands to nothing, because I >> specified no "--distfiles" argument to configure.bat. In fact, if I >> comment out that line, everything seem to go fine. >> >> Therefore, I request to allow making a binary distribution even in >> this case, i.e., that the above-mentioned like of nt/makefile was not >> written by the configure script when there is no --distfiles >> arguments. > > The following patch should fix the problem. It only copies the dist > files if any files were specified in the DIST_FILES variable via > configure.bat. > > Eli, could you please review this to ensure that I am not > over-complicating things. Thanks. > > === modified file 'nt/makefile.w32-in' > --- nt/makefile.w32-in 2011-11-30 16:23:05 +0000 > +++ nt/makefile.w32-in 2012-01-02 22:03:04 +0000 > @@ -257,8 +257,22 @@ > install-shortcuts: > "$(INSTALL_DIR)/bin/addpm" -q > > -dist: install-bin > - mkdir $(TMP_DIST_DIR) > +maybe-copy-distfiles: maybe-copy-distfiles-$(SHELLTYPE) > + > +maybe-copy-distfiles-CMD: doit > + @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR) > $(DIST_FILES) $(TMP_DIST_DIR)/bin > + > +maybe-copy-distfiles-SH: doit > + @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ > + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin > + fi > + > +create-tmp-dist-dir: > + mkdir "$(TMP_DIST_DIR)" > +# Also create bin directory for dist files. > + mkdir "$(TMP_DIST_DIR)/bin" > + > +dist: install-bin create-tmp-dist-dir maybe-copy-distfiles > $(CP) "$(INSTALL_DIR)/BUGS" $(TMP_DIST_DIR) > $(CP) "$(INSTALL_DIR)/COPYING" $(TMP_DIST_DIR) > $(CP) "$(INSTALL_DIR)/README" $(TMP_DIST_DIR) > @@ -269,7 +283,6 @@ > $(CP_DIR) "$(INSTALL_DIR)/lisp" $(TMP_DIST_DIR) > $(CP_DIR) "$(INSTALL_DIR)/leim" $(TMP_DIST_DIR) > $(CP_DIR) "$(INSTALL_DIR)/site-lisp" $(TMP_DIST_DIR) > - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin > $(COMSPEC)$(ComSpec) /c $(ARGQUOTE)zipdist.bat $(VERSION)$(ARGQUOTE) > $(DEL_TREE) $(TMP_DIST_DIR) Any issues with applying this patch? Christoph From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 11:48:30 2012 Received: (at 10261) by debbugs.gnu.org; 5 Feb 2012 16:48:30 +0000 Received: from localhost ([127.0.0.1]:55763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ru5GP-00021b-Tu for submit@debbugs.gnu.org; Sun, 05 Feb 2012 11:48:30 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:33319) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ru5GN-00021B-Q6 for 10261@debbugs.gnu.org; Sun, 05 Feb 2012 11:48:28 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LYX00A00IHN9M00@a-mtaout22.012.net.il> for 10261@debbugs.gnu.org; Sun, 05 Feb 2012 18:47:13 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.33.58]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LYX008TZIMLUN90@a-mtaout22.012.net.il>; Sun, 05 Feb 2012 18:47:13 +0200 (IST) Date: Sun, 05 Feb 2012 18:47:11 +0200 From: Eli Zaretskii Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option In-reply-to: <4F2DB52C.30801@gmail.com> X-012-Sender: halo1@inter.net.il To: Christoph Scholtes Message-id: <83ehu9cjn4.fsf@gnu.org> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 10261 Cc: 10261@debbugs.gnu.org, dmoncayo@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Sat, 04 Feb 2012 15:46:04 -0700 > From: Christoph Scholtes > CC: 10261@debbugs.gnu.org, Eli Zaretskii > > Any issues with applying this patch? No. (And sorry I missed this.) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 13:20:51 2012 Received: (at 10261) by debbugs.gnu.org; 5 Feb 2012 18:20:51 +0000 Received: from localhost ([127.0.0.1]:55806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ru6hk-000483-VV for submit@debbugs.gnu.org; Sun, 05 Feb 2012 13:20:50 -0500 Received: from mail-yw0-f44.google.com ([209.85.213.44]:62852) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ru6hj-00047p-7K for 10261@debbugs.gnu.org; Sun, 05 Feb 2012 13:20:48 -0500 Received: by yhkk25 with SMTP id k25so2091731yhk.3 for <10261@debbugs.gnu.org>; Sun, 05 Feb 2012 10:19:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=lLZkUTqJXHqVsFvrR3YzI5h7dFYXzB31QGKLsjj/NYk=; b=gEXo3dYzgI6V8A9hMnA+Dy2iucYmQaQhQnu34PIrDdjxmXZ3Y9VoyeLIG9pgZkeAHh PFssC+L0IN9IAjir6yHn81iDA+Q2XM2l+2H+zzOD9cyitpLNaxdAM/3e4xNwp+wBoblj kP60zLPi9C9deH+dKCxGgsI6L9TV3nT7rCzQ0= Received: by 10.236.184.196 with SMTP id s44mr21454956yhm.9.1328465996386; Sun, 05 Feb 2012 10:19:56 -0800 (PST) Received: from MARVIN (174-29-192-218.hlrn.qwest.net. [174.29.192.218]) by mx.google.com with ESMTPS id i6sm29611767and.3.2012.02.05.10.19.54 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Feb 2012 10:19:56 -0800 (PST) From: Christoph Scholtes To: Eli Zaretskii Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option In-Reply-To: <83ehu9cjn4.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Feb 2012 18:47:11 +0200") References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (windows-nt) Date: Sun, 05 Feb 2012 11:19:53 -0700 Message-ID: <86obtd16t2.fsf@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10261 Cc: 10261@debbugs.gnu.org, dmoncayo@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.3 (--) Eli Zaretskii writes: >> Date: Sat, 04 Feb 2012 15:46:04 -0700 >> From: Christoph Scholtes >> CC: 10261@debbugs.gnu.org, Eli Zaretskii >> >> Any issues with applying this patch? > > No. (And sorry I missed this.) Thanks. I will commit this later today. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 15:23:42 2012 Received: (at 10261-done) by debbugs.gnu.org; 5 Feb 2012 20:23:42 +0000 Received: from localhost ([127.0.0.1]:55860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ru8ce-00074Q-Br for submit@debbugs.gnu.org; Sun, 05 Feb 2012 15:23:41 -0500 Received: from mail-iy0-f172.google.com ([209.85.210.172]:36651) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ru8cb-00074C-Pk for 10261-done@debbugs.gnu.org; Sun, 05 Feb 2012 15:23:38 -0500 Received: by iagf6 with SMTP id f6so7952524iag.3 for <10261-done@debbugs.gnu.org>; Sun, 05 Feb 2012 12:22:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=xmhYXdAnsfpIDoQkhhvJj83+8w7eQF7l3slTDmBZdEU=; b=LmfxSkHq6q6xc3xrmwK1lDd048DWta+A9N8btBcVEwWBJgTMB6AylfBiPd6NskGcIC IVMdDxPgLFEDfeWcoRQlernKf3fR1TXEz1YyosG5XUzmUhvpw3ihlWe+pkEUZXzaUNmb +ugvzJjr+5fdD2vaCdrsvRPeWvUN5lNABvEnw= Received: by 10.42.150.200 with SMTP id b8mr14439832icw.43.1328473366377; Sun, 05 Feb 2012 12:22:46 -0800 (PST) Received: from MARVIN (174-29-192-218.hlrn.qwest.net. [174.29.192.218]) by mx.google.com with ESMTPS id ko6sm12422636igc.2.2012.02.05.12.22.44 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Feb 2012 12:22:45 -0800 (PST) From: Christoph Scholtes To: Eli Zaretskii Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option In-Reply-To: <83ehu9cjn4.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 05 Feb 2012 18:47:11 +0200") References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (windows-nt) Date: Sun, 05 Feb 2012 13:22:43 -0700 Message-ID: <86vcnlyqr0.fsf@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10261-done Cc: 10261-done@debbugs.gnu.org, dmoncayo@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.3 (--) Fixed in Emacs trunk r107121. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 17:00:04 2012 Received: (at 10261-done) by debbugs.gnu.org; 5 Feb 2012 22:00:04 +0000 Received: from localhost ([127.0.0.1]:55909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RuA7w-0000pv-I2 for submit@debbugs.gnu.org; Sun, 05 Feb 2012 17:00:04 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:39112) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RuA7u-0000of-Ih for 10261-done@debbugs.gnu.org; Sun, 05 Feb 2012 17:00:03 -0500 Received: by obbwd15 with SMTP id wd15so6047964obb.3 for <10261-done@debbugs.gnu.org>; Sun, 05 Feb 2012 13:59:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=SDOaIdwDh/Z3iRbszWXN1dlBdTA2WpIITBdeOTxTVYk=; b=iRBaOBWJ4KQkoD+n0laNYJt+rtJu3iAowDyERkkua+Twu4+XQCVeEIz1FDnXG60Btr nn9G7+KrAcJmwC5vtwJcQfJtwg18BewczJLAXnCTTfXkwbvqEBIxKIb/cIspY9QzF7uL 38U3JVgLCim1CfSxPSjMKRt+efRmFStUvRIpQ= MIME-Version: 1.0 Received: by 10.182.38.70 with SMTP id e6mr14547790obk.13.1328479150644; Sun, 05 Feb 2012 13:59:10 -0800 (PST) Received: by 10.60.1.130 with HTTP; Sun, 5 Feb 2012 13:59:10 -0800 (PST) In-Reply-To: <86vcnlyqr0.fsf@googlemail.com> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> Date: Sun, 5 Feb 2012 22:59:10 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Christoph Scholtes Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261-done Cc: Eli Zaretskii , 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Feb 5, 2012 at 21:22, Christoph Scholtes wrote: > Fixed in Emacs trunk r107121. I'll check this the next time I build Emacs. Thank you. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 14:22:37 2012 Received: (at 10261-done) by debbugs.gnu.org; 14 Feb 2012 19:22:37 +0000 Received: from localhost ([127.0.0.1]:40655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxNxU-0003FY-Ux for submit@debbugs.gnu.org; Tue, 14 Feb 2012 14:22:37 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:54490) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxNxS-0003FK-AG for 10261-done@debbugs.gnu.org; Tue, 14 Feb 2012 14:22:35 -0500 Received: by obbwd15 with SMTP id wd15so341544obb.3 for <10261-done@debbugs.gnu.org>; Tue, 14 Feb 2012 11:20:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=IZ9BXVdRTOSY7ldI7EfYRVl0H+T52tjzNf0f8kfcVXc=; b=rvkXnuksMH4HiUPXdJWWyT5G/5fzUFkBRAdODf41J1Eu2/J/gLAF+iu+GTdTTuVaAM vNk72NKbu+NUBs0zJ982zlzET3l26c6VgIjNX+UikkQ8WIM0C/eperAgT2vt8NW6Iq5m Nproc7N0XzHACslTIS8uqg0ry4rsHlUBrtSgs= MIME-Version: 1.0 Received: by 10.60.6.164 with SMTP id c4mr1197885oea.43.1329247251115; Tue, 14 Feb 2012 11:20:51 -0800 (PST) Received: by 10.60.1.130 with HTTP; Tue, 14 Feb 2012 11:20:51 -0800 (PST) In-Reply-To: References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> Date: Tue, 14 Feb 2012 20:20:51 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Christoph Scholtes Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261-done Cc: Eli Zaretskii , 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> Fixed in Emacs trunk r107121. > > I'll check this the next time I build Emacs. I've just tried this. After a successful "mingw32-make bootstrap", and "mingw32-make info", the "mingw32-make dist" ends up with this error: if [ ! -s ../same-dir.tst ] ; then cp -rf ../etc C:/emacs/trunk/nt/.. ; fi cp -rf icons C:/emacs/trunk/nt/../etc if [ ! -s ../same-dir.tst ] ; then cp -rf ../info C:/emacs/trunk/nt/.. ; fi if [ ! -s ../same-dir.tst ] ; then cp -f ../COPYING C:/emacs/trunk/nt/.. ; fi cp -f ../COPYING C:/emacs/trunk/nt/../bin rm ../same-dir.tst rm C:/emacs/trunk/nt/../same-dir.tst rm: cannot lstat `C:/emacs/trunk/nt/../same-dir.tst': No such file or directory mingw32-make: [install-bin] Error 1 (ignored) mkdir "emacs-24.0.93" mkdir "emacs-24.0.93/bin" /usr/bin/sh: -c: line 2: syntax error: unexpected end of file mingw32-make: *** [maybe-copy-distfiles-SH] Error 258 I see that $(SHELLTYPE) has been set to SH, but that is wrong, because I'm using the windows standard cmd.exe shell. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 14:53:16 2012 Received: (at 10261-done) by debbugs.gnu.org; 14 Feb 2012 19:53:16 +0000 Received: from localhost ([127.0.0.1]:40672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxORA-00049x-0c for submit@debbugs.gnu.org; Tue, 14 Feb 2012 14:53:16 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:47709) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxOR7-00049g-SH for 10261-done@debbugs.gnu.org; Tue, 14 Feb 2012 14:53:14 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LZE00E00EYWRE00@a-mtaout23.012.net.il> for 10261-done@debbugs.gnu.org; Tue, 14 Feb 2012 21:51:14 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.150.51]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LZE00E1FF5DPK80@a-mtaout23.012.net.il>; Tue, 14 Feb 2012 21:51:14 +0200 (IST) Date: Tue, 14 Feb 2012 21:51:17 +0200 From: Eli Zaretskii Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option In-reply-to: X-012-Sender: halo1@inter.net.il To: Dani Moncayo Message-id: <837gzpxkga.fsf@gnu.org> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 10261-done Cc: cschol2112@googlemail.com, 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Tue, 14 Feb 2012 20:20:51 +0100 > From: Dani Moncayo > Cc: Eli Zaretskii , 10261-done@debbugs.gnu.org > > After a successful "mingw32-make bootstrap", and "mingw32-make info", > the "mingw32-make dist" ends up with this error: > > if [ ! -s ../same-dir.tst ] ; then cp -rf ../etc C:/emacs/trunk/nt/.. ; fi > cp -rf icons C:/emacs/trunk/nt/../etc > if [ ! -s ../same-dir.tst ] ; then cp -rf ../info C:/emacs/trunk/nt/.. ; fi > if [ ! -s ../same-dir.tst ] ; then cp -f ../COPYING C:/emacs/trunk/nt/.. ; fi > cp -f ../COPYING C:/emacs/trunk/nt/../bin > rm ../same-dir.tst > rm C:/emacs/trunk/nt/../same-dir.tst > rm: cannot lstat `C:/emacs/trunk/nt/../same-dir.tst': No such file or directory > mingw32-make: [install-bin] Error 1 (ignored) > mkdir "emacs-24.0.93" > mkdir "emacs-24.0.93/bin" > /usr/bin/sh: -c: line 2: syntax error: unexpected end of file > mingw32-make: *** [maybe-copy-distfiles-SH] Error 258 > > > I see that $(SHELLTYPE) has been set to SH That in itself cannot be the problem, because the Makefile must be workable with SH as well. > but that is wrong, because I'm using the windows standard cmd.exe > shell. If Make can find some sh.exe somewhere on PATH, it will always use it, unless you explicitly say "make ... SHELL=cmd.exe". From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 15:53:07 2012 Received: (at 10261-done) by debbugs.gnu.org; 14 Feb 2012 20:53:07 +0000 Received: from localhost ([127.0.0.1]:40728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxPN4-0005Vn-GT for submit@debbugs.gnu.org; Tue, 14 Feb 2012 15:53:07 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:41004) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxPN2-0005VI-5m for 10261-done@debbugs.gnu.org; Tue, 14 Feb 2012 15:53:04 -0500 Received: by obbwd15 with SMTP id wd15so442572obb.3 for <10261-done@debbugs.gnu.org>; Tue, 14 Feb 2012 12:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WTu5aGIaw5MyEaZ2Ne5V4SujOYpiMAwsh8YeMj5wBhI=; b=ehxWf2QYY8TeMoi+HKkKV4v1lWRItNqTdTaBNKVl0Rfy+uwyaZsH4/lvzzcRn+W0lI uBl2LqkWmbr7sUMk+4NJDPziuR/uUQUgjNnXIAn256VSBK6Q57hnjeT742V1tZDeyc0u GhHq7t11Hnd6yKoE0F0+FENhV1RZGk9EJHzXY= MIME-Version: 1.0 Received: by 10.182.167.37 with SMTP id zl5mr15863702obb.73.1329252680719; Tue, 14 Feb 2012 12:51:20 -0800 (PST) Received: by 10.60.1.130 with HTTP; Tue, 14 Feb 2012 12:51:20 -0800 (PST) In-Reply-To: <837gzpxkga.fsf@gnu.org> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> Date: Tue, 14 Feb 2012 21:51:20 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261-done Cc: cschol2112@googlemail.com, 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> I see that $(SHELLTYPE) has been set to SH > > That in itself cannot be the problem, because the Makefile must be > workable with SH as well. > >> but that is wrong, because I'm using the windows standard cmd.exe >> shell. > > If Make can find some sh.exe somewhere on PATH, it will always use it, > unless you explicitly say "make ... SHELL=cmd.exe". Indeed, I had a "sh.exe" program in the PATH of that cmd session (the one that comes with MSYS), and after renaming it to something else, the "dist" target seem to work fine now. (thank you) But I still wonder the reason of the former failure: If a "sh.exe" shell is supported too, what was wrong with my initial setup? And BTW, I'm wondering too: what's the point of the "barebin" file? In which cases is it useful? Is that documented somewhere? Should not be separate targets for making the "bin" and "barebin" files? TIA. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 16:10:08 2012 Received: (at 10261-done) by debbugs.gnu.org; 14 Feb 2012 21:10:08 +0000 Received: from localhost ([127.0.0.1]:40731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxPdX-0005tW-2a for submit@debbugs.gnu.org; Tue, 14 Feb 2012 16:10:08 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:54686) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxPdH-0005sl-Fm for 10261-done@debbugs.gnu.org; Tue, 14 Feb 2012 16:10:05 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LZE00E00IGKXG00@a-mtaout23.012.net.il> for 10261-done@debbugs.gnu.org; Tue, 14 Feb 2012 23:08:06 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.150.51]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LZE00E0GIPFVO90@a-mtaout23.012.net.il>; Tue, 14 Feb 2012 23:08:06 +0200 (IST) Date: Tue, 14 Feb 2012 23:08:07 +0200 From: Eli Zaretskii Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option In-reply-to: X-012-Sender: halo1@inter.net.il To: Dani Moncayo Message-id: <834nutxgw8.fsf@gnu.org> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 10261-done Cc: cschol2112@googlemail.com, 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Tue, 14 Feb 2012 21:51:20 +0100 > From: Dani Moncayo > Cc: cschol2112@googlemail.com, 10261-done@debbugs.gnu.org > > But I still wonder the reason of the former failure: If a "sh.exe" > shell is supported too, what was wrong with my initial setup? I don't know. Please try to find out, because it should work. My first guess would be that this command: maybe-copy-distfiles-SH: doit @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin fi should instead say @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) = "" ] ; then \ i.e., one '=', not 2. > And BTW, I'm wondering too: what's the point of the "barebin" file? For people who want to be able to dump their own Emacs after preloading a different collection of Lisp files, I think. I never used it, FWIW. > Should not be separate targets for making the "bin" and "barebin" > files? I actually think we need to deprecate it and eventual stop building and distributing it. I doubt anyone ever used it. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 03:32:17 2012 Received: (at 10261-done) by debbugs.gnu.org; 15 Feb 2012 08:32:17 +0000 Received: from localhost ([127.0.0.1]:41028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxaHh-0005y8-BT for submit@debbugs.gnu.org; Wed, 15 Feb 2012 03:32:17 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:34024) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxaHg-0005xw-5O for 10261-done@debbugs.gnu.org; Wed, 15 Feb 2012 03:32:16 -0500 Received: by obbwd15 with SMTP id wd15so1141424obb.3 for <10261-done@debbugs.gnu.org>; Wed, 15 Feb 2012 00:30:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=o7lmWlrTT/+Y+H8Z65n3JvcEXxG4ay6zDFJpZfb2S1Q=; b=nJd6AlKtp0YUg5730ISo9p6JXvN73VsGSOijdnyDpk/WMI7CHefm7WOFS/RajXMNTi 3RL4GcNEA0XS4X5wlAQI0EeEudZXI+BKw/dJFNyXF3mTSr9mdhcg2F3vVbJkncTokAhN 0T+XuSz7p3Csxvr/wkEqZJAW7y2LMOiXkKf9E= MIME-Version: 1.0 Received: by 10.182.159.105 with SMTP id xb9mr17494229obb.63.1329294629748; Wed, 15 Feb 2012 00:30:29 -0800 (PST) Received: by 10.60.1.130 with HTTP; Wed, 15 Feb 2012 00:30:29 -0800 (PST) In-Reply-To: <834nutxgw8.fsf@gnu.org> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> Date: Wed, 15 Feb 2012 09:30:29 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261-done Cc: cschol2112@googlemail.com, 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> But I still wonder the reason of the former failure: If a "sh.exe" >> shell is supported too, what was wrong with my initial setup? > > I don't know. =A0Please try to find out, because it should work. =A0My > first guess would be that this command: > > =A0maybe-copy-distfiles-SH: doit > =A0 =A0 =A0 =A0 =A0@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=3D=3D"" ] = ; then \ > =A0 =A0 =A0 =A0 =A0 =A0$(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin > =A0 =A0 =A0 =A0 =A0fi > > should instead say > > =A0 @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) =3D "" ] ; then \ > > i.e., one '=3D', not 2. For the record: I tried this, and it didn't make a difference. Currently I don't know where is the problem. --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 12:07:45 2012 Received: (at 10261-done) by debbugs.gnu.org; 15 Feb 2012 17:07:45 +0000 Received: from localhost ([127.0.0.1]:41652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxiKS-0002P7-63 for submit@debbugs.gnu.org; Wed, 15 Feb 2012 12:07:44 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:46571) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxiKM-0002Ok-I9 for 10261-done@debbugs.gnu.org; Wed, 15 Feb 2012 12:07:38 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LZG0000022MF300@a-mtaout21.012.net.il> for 10261-done@debbugs.gnu.org; Wed, 15 Feb 2012 19:05:07 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.150.51]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LZG000YZ24H7L80@a-mtaout21.012.net.il>; Wed, 15 Feb 2012 19:05:07 +0200 (IST) Date: Wed, 15 Feb 2012 19:05:10 +0200 From: Eli Zaretskii Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option In-reply-to: To: Dani Moncayo Message-id: <83wr7ovxh5.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 10261-done Cc: cschol2112@googlemail.com, 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > Date: Wed, 15 Feb 2012 09:30:29 +0100 > From: Dani Moncayo > Cc: cschol2112@googlemail.com, 10261-done@debbugs.gnu.org >=20 > > =A0 @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) =3D "" ] ; then \ > > > > i.e., one '=3D', not 2. >=20 > For the record: I tried this, and it didn't make a difference. If you remove the @ prefix from that line, what does Make display for this command? (I want to see what does the $(ARGQUOTE) magic expand to.) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 13:52:15 2012 Received: (at 10261-done) by debbugs.gnu.org; 15 Feb 2012 18:52:15 +0000 Received: from localhost ([127.0.0.1]:41777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rxjxf-0004tP-AI for submit@debbugs.gnu.org; Wed, 15 Feb 2012 13:52:15 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:54872) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rxjxc-0004tA-RR for 10261-done@debbugs.gnu.org; Wed, 15 Feb 2012 13:52:13 -0500 Received: by obbwd15 with SMTP id wd15so1799618obb.3 for <10261-done@debbugs.gnu.org>; Wed, 15 Feb 2012 10:50:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Taxey/uzw+JMBU6zYjjx29Sol7v+CfB4vye1WDt76QI=; b=WSohmbLPQCFK0hPaJFmfBoRvlutUUw0vbpeZ1bIYpTJ/tFgCfLNLqp2q1I1Phj0ve3 uxKT+0DwGle1MdDFUOUEaTLVSAy5UW7CXiFG1LWmBKq0RJJ13/VfZUcdYciSFSgVSf5x GP4GgGtKqM0dbZJZHrPqdLEQDWEJmCOGE5xz0= MIME-Version: 1.0 Received: by 10.182.159.105 with SMTP id xb9mr18939692obb.63.1329331823997; Wed, 15 Feb 2012 10:50:23 -0800 (PST) Received: by 10.60.1.130 with HTTP; Wed, 15 Feb 2012 10:50:23 -0800 (PST) In-Reply-To: <83wr7ovxh5.fsf@gnu.org> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> <83wr7ovxh5.fsf@gnu.org> Date: Wed, 15 Feb 2012 19:50:23 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261-done Cc: cschol2112@googlemail.com, 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> > =A0 @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) =3D "" ] ; then \ >> > >> > i.e., one '=3D', not 2. >> >> For the record: I tried this, and it didn't make a difference. > > If you remove the @ prefix from that line, what does Make display for > this command? =A0(I want to see what does the $(ARGQUOTE) magic expand > to.) It displays this: [...] mingw32-make: [install-bin] Error 1 (ignored) mkdir "emacs-24.0.93" mkdir "emacs-24.0.93/bin" if [ ! ''=3D=3D"" ] ; then \ cp -rf emacs-24.0.93/bin /usr/bin/sh: -c: line 2: syntax error: unexpected end of file mingw32-make: *** [maybe-copy-distfiles-SH] Error 258 The problem was I think I've found the problem: the "cp -rf" line is lacking a final " ; \", and because of that, the shell sees an "if" without a matching "fi". The following patch should fix this problem: =3D=3D=3D modified file 'nt/makefile.w32-in' --- nt/makefile.w32-in 2012-02-05 20:14:54 +0000 +++ nt/makefile.w32-in 2012-02-15 18:32:45 +0000 @@ -264,7 +264,7 @@ maybe-copy-distfiles-SH: doit @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=3D=3D"" ] ; then \ - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ fi create-tmp-dist-dir: I've not bootstrapped again with this patch applied, but I've done the changes directly in nt/makefile and now the "dist" target does its job successfully. One question, BTW: if we have the $(ARGQUOTE) variable to stand for a suitable/shell-specific quote, why don't we use it in the right side of the "=3D=3D" too? i.e., why don't we do: @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=3D=3D$(ARGQUOTE)$(ARGQUOTE) ]= ; then \ instead of @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=3D=3D"" ] ; then \ ? --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 22:10:06 2012 Received: (at 10261-done) by debbugs.gnu.org; 16 Feb 2012 03:10:06 +0000 Received: from localhost ([127.0.0.1]:41986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxrjO-0000hb-Mj for submit@debbugs.gnu.org; Wed, 15 Feb 2012 22:10:06 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:63273) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RxrjI-0000h4-Uw for 10261-done@debbugs.gnu.org; Wed, 15 Feb 2012 22:10:01 -0500 Received: by obbwd15 with SMTP id wd15so2329825obb.3 for <10261-done@debbugs.gnu.org>; Wed, 15 Feb 2012 19:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=SUw4BOgNmHUGiQLedX6Cqr6sUYezjHK7g+v+UGrvsm4=; b=l2WEJJi3Fm+vbWkMiG1tu3oxvii7QZUFURDiiZncvBHY7vx5XBfwxC5a+KDnQTWIUW ek1IkR4RWYv/KaZvqvPTf6opjfcUB6uYC63gXuZlVCeAfw+dwHcvuq00kEfUIYpACUwJ K3P9TtgwK6SBwr16DwLX2+Yg8xZLUWPVcd7EA= Received: by 10.50.202.97 with SMTP id kh1mr859498igc.19.1329361685415; Wed, 15 Feb 2012 19:08:05 -0800 (PST) Received: from [192.168.1.3] (71-212-159-35.hlrn.qwest.net. [71.212.159.35]) by mx.google.com with ESMTPS id h9sm9149894ibh.11.2012.02.15.19.08.03 (version=SSLv3 cipher=OTHER); Wed, 15 Feb 2012 19:08:03 -0800 (PST) Message-ID: <4F3C7313.4070403@gmail.com> Date: Wed, 15 Feb 2012 20:08:03 -0700 From: Christoph Scholtes User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1 MIME-Version: 1.0 To: Dani Moncayo Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> <83wr7ovxh5.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 10261-done Cc: Eli Zaretskii , 10261-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.3 (--) On 2/15/2012 11:50 AM, Dani Moncayo wrote: > The following patch should fix this problem: > > === modified file 'nt/makefile.w32-in' > --- nt/makefile.w32-in 2012-02-05 20:14:54 +0000 > +++ nt/makefile.w32-in 2012-02-15 18:32:45 +0000 > @@ -264,7 +264,7 @@ > > maybe-copy-distfiles-SH: doit > @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ > - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin > + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ > fi > > create-tmp-dist-dir: Thank you for debugging my bugging. :) > One question, BTW: if we have the $(ARGQUOTE) variable to stand for a > suitable/shell-specific quote, why don't we use it in the right side > of the "==" too? i.e., why don't we do: > @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)==$(ARGQUOTE)$(ARGQUOTE) ] ; then \ > instead of > @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ > ? IIRC, I took the ARGQUOTE piece from some other piece of some Windows makefile. I now remember that didn't have any way to test the sh behavior since I use cmd.exe. Thanks again for working on this. Christoph From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 02:25:08 2012 Received: (at 10261) by debbugs.gnu.org; 23 Feb 2012 07:25:08 +0000 Received: from localhost ([127.0.0.1]:51822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0T35-000165-Sy for submit@debbugs.gnu.org; Thu, 23 Feb 2012 02:25:08 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:38805) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0T32-00015c-Re for 10261@debbugs.gnu.org; Thu, 23 Feb 2012 02:25:05 -0500 Received: by obbwd15 with SMTP id wd15so1009290obb.3 for <10261@debbugs.gnu.org>; Wed, 22 Feb 2012 23:22:32 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.182.192.36 as permitted sender) client-ip=10.182.192.36; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.182.192.36 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.182.192.36]) by 10.182.192.36 with SMTP id hd4mr49810obc.60.1329981752504 (num_hops = 1); Wed, 22 Feb 2012 23:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Zl7JemgGqP5H/xDUnLIPCGCelEdwGcoIywoGQAFmRW8=; b=xcYD6enMdiQ6EwObkcv1PsSRiA5wbSJ7zWyRYBT/v25aO+XY03wl+/ZsP9LD6EuLI7 +pZvtcqIHSkG8u52f7uMFmdW87LyusVGPHmzDCqSZFpK6Ny8y6y/MygwjlYSlOpEa/VW CvdMJsfD6DkLpvTir1DErN+DaBw/u6FFb0M+A= MIME-Version: 1.0 Received: by 10.182.192.36 with SMTP id hd4mr45225obc.60.1329981752425; Wed, 22 Feb 2012 23:22:32 -0800 (PST) Received: by 10.60.42.193 with HTTP; Wed, 22 Feb 2012 23:22:32 -0800 (PST) In-Reply-To: References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> <83wr7ovxh5.fsf@gnu.org> Date: Thu, 23 Feb 2012 08:22:32 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Eli Zaretskii Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > The following patch should fix this problem: > > =3D=3D=3D modified file 'nt/makefile.w32-in' > --- nt/makefile.w32-in =A02012-02-05 20:14:54 +0000 > +++ nt/makefile.w32-in =A02012-02-15 18:32:45 +0000 > @@ -264,7 +264,7 @@ > > =A0maybe-copy-distfiles-SH: doit > =A0 =A0 =A0 =A0@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=3D=3D"" ] ; th= en \ > - =A0 =A0 =A0 =A0 $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin > + =A0 =A0 =A0 =A0 $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ > =A0 =A0 =A0 =A0fi > > =A0create-tmp-dist-dir: If this patch is ok, could someone commit it? --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 02:55:28 2012 Received: (at 10261) by debbugs.gnu.org; 23 Feb 2012 07:55:28 +0000 Received: from localhost ([127.0.0.1]:51831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0TWR-0001n9-Qo for submit@debbugs.gnu.org; Thu, 23 Feb 2012 02:55:28 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:65191) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0TWP-0001mw-8n for 10261@debbugs.gnu.org; Thu, 23 Feb 2012 02:55:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EAL/vRU9Ld/XJ/2dsb2JhbABEr2iCcoEIgXMBAQQBViMFCwsOJhIUGA0kiBS3D40AMAgLAwQLAgsCBQIXBgIDAQIChRcKhBsEiE+bGYRb X-IronPort-AV: E=Sophos;i="4.73,469,1325480400"; d="scan'208";a="164263733" Received: from 75-119-245-201.dsl.teksavvy.com (HELO pastel.home) ([75.119.245.201]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Feb 2012 02:52:52 -0500 Received: by pastel.home (Postfix, from userid 20848) id 73D7C5205F; Thu, 23 Feb 2012 02:52:52 -0500 (EST) From: Stefan Monnier To: Dani Moncayo Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option Message-ID: References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> <83wr7ovxh5.fsf@gnu.org> Date: Thu, 23 Feb 2012 02:52:52 -0500 In-Reply-To: (Dani Moncayo's message of "Thu, 23 Feb 2012 08:22:32 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, Eli Zaretskii , 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> The following patch should fix this problem: >>=20 >> =3D=3D=3D modified file 'nt/makefile.w32-in' >> --- nt/makefile.w32-in =A02012-02-05 20:14:54 +0000 >> +++ nt/makefile.w32-in =A02012-02-15 18:32:45 +0000 >> @@ -264,7 +264,7 @@ >>=20 >> =A0maybe-copy-distfiles-SH: doit >> =A0 =A0 =A0 =A0@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=3D=3D"" ] ; t= hen \ >> - =A0 =A0 =A0 =A0 $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin >> + =A0 =A0 =A0 =A0 $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ >> =A0 =A0 =A0 =A0fi >>=20 >> =A0create-tmp-dist-dir: > If this patch is ok, could someone commit it? Looks correct, committed (tho I couldn't find the original message you quote, so I don't know who to attribute that to). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 03:02:06 2012 Received: (at 10261) by debbugs.gnu.org; 23 Feb 2012 08:02:06 +0000 Received: from localhost ([127.0.0.1]:51836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0Tcr-0001xH-JF for submit@debbugs.gnu.org; Thu, 23 Feb 2012 03:02:06 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:33712) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0Tcp-0001wl-Eq for 10261@debbugs.gnu.org; Thu, 23 Feb 2012 03:02:04 -0500 Received: by obbwd15 with SMTP id wd15so1030070obb.3 for <10261@debbugs.gnu.org>; Wed, 22 Feb 2012 23:59:31 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.182.160.65 as permitted sender) client-ip=10.182.160.65; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.182.160.65 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.182.160.65]) by 10.182.160.65 with SMTP id xi1mr100624obb.40.1329983971254 (num_hops = 1); Wed, 22 Feb 2012 23:59:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=oRdvDLbAyfkrM7iGNxa2+JzP1H7qnMqxzTJxOVr77QE=; b=PZFY9Dhmv6a+/dpaRsG0sO2YgA0rpG06uAhEeW+PWSfpTh95rdmW4jmD/UdLE68d2w 1V+Cyne8H0/GTTV9rjbMSxijh4bryn9PCg+7ZnMAwSuaY2Wri/mBIKGcrfuquYZZu6RS p+z1mvO5JlcqnhPFIxJp8PuAss5/SrLUJcjC4= MIME-Version: 1.0 Received: by 10.182.160.65 with SMTP id xi1mr90385obb.40.1329983971173; Wed, 22 Feb 2012 23:59:31 -0800 (PST) Received: by 10.60.42.193 with HTTP; Wed, 22 Feb 2012 23:59:31 -0800 (PST) In-Reply-To: References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> <83wr7ovxh5.fsf@gnu.org> Date: Thu, 23 Feb 2012 08:59:31 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Stefan Monnier Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, Eli Zaretskii , 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> If this patch is ok, could someone commit it? > > Looks correct, committed (tho I couldn't find the original message you > quote, so I don't know who to attribute that to). You can see the thread here: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10261 But I don't understand why some messages don't appear in (http://lists.gnu.org/archive/html/bug-gnu-emacs). It seems like the messages sent to "(bug-number)@debbugs.org" are not showed there. IMO, they should. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 03:03:05 2012 Received: (at 10261) by debbugs.gnu.org; 23 Feb 2012 08:03:06 +0000 Received: from localhost ([127.0.0.1]:51855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0Tdp-0001zE-2p for submit@debbugs.gnu.org; Thu, 23 Feb 2012 03:03:05 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:55228) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0Tdl-0001ye-8C for 10261@debbugs.gnu.org; Thu, 23 Feb 2012 03:03:02 -0500 Received: by obbwd15 with SMTP id wd15so1030720obb.3 for <10261@debbugs.gnu.org>; Thu, 23 Feb 2012 00:00:29 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.182.141.9 as permitted sender) client-ip=10.182.141.9; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.182.141.9 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.182.141.9]) by 10.182.141.9 with SMTP id rk9mr96729obb.50.1329984029218 (num_hops = 1); Thu, 23 Feb 2012 00:00:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=HbOh6zKj0EOCUuhwnsmwTyL0zECtu0rKtwDxYsKSJO8=; b=p6AVJfIBCVKb5e6mzfKa3T6AjuPsVDICSTkqopaenHOo3zJoYN/kN7EJhq5orBRpQz 0b1QI2iym3DRnmojhT8+iCtONqlIFzX8X/kaKyFyuYNxI9e4PnGbPKY0Rswu50qomPcT wicG10uSzTxzPNw0GHCt8k3g8WX4K9y7rLBPs= MIME-Version: 1.0 Received: by 10.182.141.9 with SMTP id rk9mr85927obb.50.1329984029041; Thu, 23 Feb 2012 00:00:29 -0800 (PST) Received: by 10.60.42.193 with HTTP; Thu, 23 Feb 2012 00:00:28 -0800 (PST) In-Reply-To: References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> <83wr7ovxh5.fsf@gnu.org> Date: Thu, 23 Feb 2012 09:00:28 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Stefan Monnier Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, Eli Zaretskii , 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > But I don't understand why some messages don't appear in > (http://lists.gnu.org/archive/html/bug-gnu-emacs). =A0It seems like the > messages sent to "(bug-number)@debbugs.org" are not showed there. ^^^^^^^^^^^^^^^^^^^^^^^^^ > IMO, they should. Sorry, I mean "(bug-number)-done@debbugs.org" --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 23 03:39:50 2012 Received: (at 10261) by debbugs.gnu.org; 23 Feb 2012 08:39:50 +0000 Received: from localhost ([127.0.0.1]:51907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0UDK-0003ed-0f for submit@debbugs.gnu.org; Thu, 23 Feb 2012 03:39:49 -0500 Received: from fencepost.gnu.org ([140.186.70.10]:41073 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0UDG-0003eV-CQ for 10261@debbugs.gnu.org; Thu, 23 Feb 2012 03:39:44 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1S0UAr-0007vm-Tz; Thu, 23 Feb 2012 03:37:13 -0500 From: Glenn Morris To: Dani Moncayo Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> <83wr7ovxh5.fsf@gnu.org> X-Spook: ASLET industrial intelligence csim ASO brigand Legion of X-Ran: +iFlt`Mt[9,T!2&N%\O-"a]Hwy<&sv\*],0Q'_j|ggGA$5]B&HfF.Q/[Hz1,St_Ldym9Gr X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 23 Feb 2012 03:37:13 -0500 In-Reply-To: (Dani Moncayo's message of "Thu, 23 Feb 2012 09:00:28 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, 10261@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Dani Moncayo wrote: >> But I don't understand why some messages don't appear in >> (http://lists.gnu.org/archive/html/bug-gnu-emacs). =C2=A0It seems like t= he >> messages sent to "(bug-number)@debbugs.org" are not showed there. > ^^^^^^^^^^^^^^^^^^^^^^^^^ >> IMO, they should. > > Sorry, I mean "(bug-number)-done@debbugs.org" http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9467 (Basically, don't send to a -done address unless you want to close an open = bug. FWIW, Mail-Followup-To is set appropriately in -done messages.) From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 14:45:56 2012 Received: (at 10261) by debbugs.gnu.org; 27 Feb 2012 19:45:56 +0000 Received: from localhost ([127.0.0.1]:60183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S26WC-0007MR-Gj for submit@debbugs.gnu.org; Mon, 27 Feb 2012 14:45:56 -0500 Received: from mail-tul01m020-f172.google.com ([209.85.214.172]:48043) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S26WA-0007L0-3M for 10261@debbugs.gnu.org; Mon, 27 Feb 2012 14:45:54 -0500 Received: by obbeh20 with SMTP id eh20so1568627obb.3 for <10261@debbugs.gnu.org>; Mon, 27 Feb 2012 11:43:01 -0800 (PST) Received-SPF: pass (google.com: domain of dmoncayo@gmail.com designates 10.182.141.9 as permitted sender) client-ip=10.182.141.9; Authentication-Results: mr.google.com; spf=pass (google.com: domain of dmoncayo@gmail.com designates 10.182.141.9 as permitted sender) smtp.mail=dmoncayo@gmail.com; dkim=pass header.i=dmoncayo@gmail.com Received: from mr.google.com ([10.182.141.9]) by 10.182.141.9 with SMTP id rk9mr5500615obb.50.1330371781134 (num_hops = 1); Mon, 27 Feb 2012 11:43:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=uDQJZcjCgP/N5SspoRGq2vcpFSwqWue2CdYJcWYkEFU=; b=TpDA+ULrLtpVHA7PctISjKi837tY2rHyujarzIb/W8d+TJocrdhj5yHv/gUcdDRL3d Achw5qnIgFS3AOiup2wfOGyB7hcxk1my/+s4ROK1YCewZ4+M5tXf5Cfe6QyBfdKc46nT ME0lshrkGV/qadBwtQgT070/mxfcg7dpBVfh0= MIME-Version: 1.0 Received: by 10.182.141.9 with SMTP id rk9mr4912228obb.50.1330371781038; Mon, 27 Feb 2012 11:43:01 -0800 (PST) Received: by 10.60.42.193 with HTTP; Mon, 27 Feb 2012 11:43:00 -0800 (PST) In-Reply-To: <834nutxgw8.fsf@gnu.org> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> Date: Mon, 27 Feb 2012 20:43:00 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: 10261@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) I'm re-sending a message from Eli to this list, because I think it didn't arrive to you, since it was sent to a "-done" address (10261-done@debbugs.gnu.org). On Tue, Feb 14, 2012 at 22:08, Eli Zaretskii wrote: >>[...] >> And BTW, I'm wondering too: what's the point of the "barebin" file? > > For people who want to be able to dump their own Emacs after > preloading a different collection of Lisp files, I think. =A0I never > used it, FWIW. > >> Should not be separate targets for making the "bin" and "barebin" >> files? > > I actually think we need to deprecate it and eventual stop building > and distributing it. =A0I doubt anyone ever used it. If nobody uses this "barebin" target, I also suggest to deprecate/remove it= . --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 15:31:02 2012 Received: (at 10261) by debbugs.gnu.org; 23 Mar 2012 19:31:02 +0000 Received: from localhost ([127.0.0.1]:35711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBACP-0000fi-RO for submit@debbugs.gnu.org; Fri, 23 Mar 2012 15:30:59 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]:46574) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBAC1-0000fB-Ex for 10261@debbugs.gnu.org; Fri, 23 Mar 2012 15:30:55 -0400 Received: by eaaq11 with SMTP id q11so1163630eaa.3 for <10261@debbugs.gnu.org>; Fri, 23 Mar 2012 11:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=h6iSZgojQosxOvw/HkXB4TucNMMO1SQ12DRjumFmUxo=; b=N4blc5hn6Ry2Zggcc6erzdVBmURM35Y88Wuw0Q6U7ITc0fMsyICLzRNHrpDwhO7IV/ yw/bZzkz5uLmZ50pmfE+KW2wvJPF1dCqaIjLSD62ZNG1n1+0ts85+JcBbuSbq1b3FOIU heNesG5UOMSpCtCORu4+ZNKKHMbJtJK56xGiy0dHOlvQEiSxfmDN/7Q6FOFbX+0risdu 2DGNxMy7QTNDcZfiyEEv+yBUU/rrRrKNnyl9XFgYBFUsCptBEjTD+qoiu42jRmKLG0oN ahWtZ5d4a9fozlteChEpFd/AexrMXkG2/PuGIfCajeoIQt+7On1bfK4Y2MhPf9dCiW6/ zRjQ== MIME-Version: 1.0 Received: by 10.14.123.202 with SMTP id v50mr1798728eeh.95.1332529178218; Fri, 23 Mar 2012 11:59:38 -0700 (PDT) Received: by 10.14.100.74 with HTTP; Fri, 23 Mar 2012 11:59:38 -0700 (PDT) In-Reply-To: References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> Date: Fri, 23 Mar 2012 19:59:38 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: 10261@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Hi, In this bug report, the "dist" target of the nt/makefile was fixed because it failed when no --distfiles argument was given to configure (it always tried to run the "cp" command, and in this case failed). Well, now I've tried to build Emacs in my system, but this time giving a --distfiles argument to configure (for including the libXpm.dll in the binary distribution). I've found that the zip file has been generated without errors, but the dll file has not been included in the "bin" subdirectory. After doing a few experiments, I've found that the problem is in the "maybe-copy-distfiles-SH" target. Currently the target is defined like this: ------------------------- maybe-copy-distfiles-SH: doit @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ fi ------------------------- and I've seen that the "if" condition never evaluates to true, so that my distfiles are never copied to the bin subdirectory (regardless of the value of DIST_FILES). I think I've found a solution (I've tested it): write the "if" condition like this: if [ -n $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) ] ; then \ This is the corresponding patch: === modified file 'nt/makefile.w32-in' --- nt/makefile.w32-in 2012-02-27 03:20:00 +0000 +++ nt/makefile.w32-in 2012-03-23 18:57:00 +0000 @@ -263,7 +263,7 @@ @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin maybe-copy-distfiles-SH: doit - @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ + @if [ -n $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) ] ; then \ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ fi Do you find it correct? If so, please install it. Thanks. -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 23 15:55:54 2012 Received: (at 10261) by debbugs.gnu.org; 23 Mar 2012 19:55:54 +0000 Received: from localhost ([127.0.0.1]:35740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBAaX-00023B-Kl for submit@debbugs.gnu.org; Fri, 23 Mar 2012 15:55:53 -0400 Received: from mail-ee0-f44.google.com ([74.125.83.44]:65308) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBAaU-000231-Sl for 10261@debbugs.gnu.org; Fri, 23 Mar 2012 15:55:51 -0400 Received: by eeke51 with SMTP id e51so1187873eek.3 for <10261@debbugs.gnu.org>; Fri, 23 Mar 2012 12:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=X3X/r+7MxlqvVB/C/xd7vV2Y1pKtv8IZLZmMXqr+ouo=; b=OX9eYZCAL5J8UgmGj9loywU4MPoHN7B+cQdfNPsipjsSZM+ekCGPGh8pU4Rf56Mm2E x5NwHRiYW5WQvuTsyM+CjsQOpZcZ2egxwNq7phhzi+0fVyG8SGwmtIaUCdvGxhXfd8S4 CCnQZc8Vn0djloVT6sm5EdntVsKeWZs3eovX6r9uyDU2QCwtAWDSvgi2cRCBuf4YUm+G mEp2UT/x5vWBOYVfAllY4TftzMm12/73vbe4NtKj8SdBQAASy8xaO1CDvLionY648pQT XMsDbl5LolMLM8aHddeIOFc4YhiZsDPeFr7BEfWa/2+H0aDarqH5YfF1w3dkdY/qa7Al VRpA== MIME-Version: 1.0 Received: by 10.213.31.207 with SMTP id z15mr623715ebc.65.1332530695503; Fri, 23 Mar 2012 12:24:55 -0700 (PDT) Received: by 10.14.100.74 with HTTP; Fri, 23 Mar 2012 12:24:55 -0700 (PDT) In-Reply-To: References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> Date: Fri, 23 Mar 2012 20:24:55 +0100 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: 10261@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > ------------------------- > maybe-copy-distfiles-SH: doit > > =A0 =A0 =A0 =A0@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=3D=3D"" ] ; th= en \ > > =A0 =A0 =A0 =A0 =A0$(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ > > =A0 =A0 =A0 =A0fi > ------------------------- I've done a few more test, and actually the problem was in that the "=3D=3D" should be surrounded by spaces. So install the fix that you prefer (this one or the one I sent before). --=20 Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 11 02:35:12 2012 Received: (at 10261) by debbugs.gnu.org; 11 Apr 2012 06:35:12 +0000 Received: from localhost ([127.0.0.1]:50175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHr93-0002G7-UL for submit@debbugs.gnu.org; Wed, 11 Apr 2012 02:35:11 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:54505) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHr90-0002Fw-Qf for 10261@debbugs.gnu.org; Wed, 11 Apr 2012 02:35:07 -0400 Received: from [155.69.16.95] (port=49345 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SHr7v-00036s-3C; Wed, 11 Apr 2012 02:33:59 -0400 From: Chong Yidong To: Dani Moncayo Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> Date: Wed, 11 Apr 2012 14:33:52 +0800 In-Reply-To: (Dani Moncayo's message of "Fri, 23 Mar 2012 20:24:55 +0100") Message-ID: <877gxmeq0f.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Dani Moncayo writes: > I've done a few more test, and actually the problem was in that the > "==" should be surrounded by spaces. > > So install the fix that you prefer (this one or the one I sent before). Done. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 11 09:13:10 2012 Received: (at 10261) by debbugs.gnu.org; 11 Apr 2012 13:13:10 +0000 Received: from localhost ([127.0.0.1]:50737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHxME-0002Gw-6u for submit@debbugs.gnu.org; Wed, 11 Apr 2012 09:13:10 -0400 Received: from mail-gx0-f172.google.com ([209.85.161.172]:64109) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHxMB-0002Go-0p for 10261@debbugs.gnu.org; Wed, 11 Apr 2012 09:13:07 -0400 Received: by ggmi1 with SMTP id i1so382398ggm.3 for <10261@debbugs.gnu.org>; Wed, 11 Apr 2012 06:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=h/LN7Nv1Js2c9yNKEkKfcbAcjvdaPWnO3jCJ4M1rfcg=; b=ba2E2rJlR05qA22zuWHaq+NW1fbmtaP2tSC3ZxflDgeZxDTUDyYlIfYX7icgET92Th F6T5tsvRr9TydTNNys7+H4VcYaBQx+nUR7IxhzhL7KXGvTMP+kCG6PX+CTbS/I4UvwWT 7r/qrIs7/Hf2Lyp6RhWiifW2pOvdTaq92f0pIW2dDj1a545KFDHirI+Vjc/RG0x10Li3 a1DHcNMFtKfAT/a3JODtyFsxlv7tHVLx1yHN332xnYCvPJFk+QVwrMzEQJqKG9tc/p9g DppHZcMU+knmPHACGnCbCKn94rht64epYcUAFQV0q6gfVjdO+FIkAdsxNTmU2goZ09Ll qbBQ== MIME-Version: 1.0 Received: by 10.60.3.99 with SMTP id b3mr21724902oeb.72.1334149918354; Wed, 11 Apr 2012 06:11:58 -0700 (PDT) Received: by 10.60.118.69 with HTTP; Wed, 11 Apr 2012 06:11:58 -0700 (PDT) In-Reply-To: <877gxmeq0f.fsf@gnu.org> References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> <877gxmeq0f.fsf@gnu.org> Date: Wed, 11 Apr 2012 15:11:58 +0200 Message-ID: Subject: Re: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option From: Dani Moncayo To: Chong Yidong Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10261 Cc: cschol2112@googlemail.com, 10261@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > > I've done a few more test, and actually the problem was in that the > > "==" should be surrounded by spaces. > > > > So install the fix that you prefer (this one or the one I sent before). > > Done. Thanks. Actually the bug was only about the "maybe-copy-distfiles-SH" target ("maybe-copy-distfiles-CMD" is not executed in my current environment), but I guess that the additional change in "maybe-copy-distfiles-CMD" is fine too. So, I guess this bug report could be closed. Thanks again. -- Dani Moncayo From unknown Tue Aug 19 10:00:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 May 2012 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator