GNU bug report logs -
#10261
24.0.92; The "dist" makefile target & the "--distfiles" configure option
Previous Next
Reported by: Dani Moncayo <dmoncayo <at> gmail.com>
Date: Sat, 10 Dec 2011 11:12:01 UTC
Severity: normal
Found in version 24.0.92
Done: Christoph Scholtes <cschol2112 <at> googlemail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10261 in the body.
You can then email your comments to 10261 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs.
(Sat, 10 Dec 2011 11:12:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Dani Moncayo <dmoncayo <at> gmail.com>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Sat, 10 Dec 2011 11:12:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Hi,
After bootstrapping Emacs on my system (MS-Windows 7 64-bit; mingw32),
if I try the "dist" target (mingw32-make dist), I get this error:
--------------------------------------[...]cp -rf
"C:/emacs/trunk/nt/../leim" emacs-24.0.92
cp -rf "C:/emacs/trunk/nt/../site-lisp" emacs-24.0.92
cp -rf emacs-24.0.92/bin
cp: missing destination file operand after `emacs-24.0.92/bin'
Try `cp --help' for more information.
mingw32-make: *** [dist] Error 1
--------------------------------------
Looking at the file "nt/makefile", the failing sentence seems to be
this one: $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
The problem is that `$(DIST_FILES)' expands to nothing, because I
specified no "--distfiles" argument to configure.bat. In fact, if I
comment out that line, everything seem to go fine.
Therefore, I request to allow making a binary distribution even in
this case, i.e., that the above-mentioned like of nt/makefile was not
written by the configure script when there is no --distfiles
arguments.
TIA
In GNU Emacs 24.0.92.1 (i386-mingw-nt6.1.7601)
of 2011-12-09 on DANI-PC
Windowing system distributor `Microsoft Corp.', version 6.1.7601
configured using `configure --with-gcc (4.6) --no-opt --cflags
-fno-omit-frame-pointer'
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs.
(Sat, 10 Dec 2011 11:27:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 10261 <at> debbugs.gnu.org (full text, mbox):
[Sorry, the OP is badly formatted, due to some "feature" of GMail.
Here is the message again, hopefully well formatted].
After bootstrapping Emacs on my system (MS-Windows 7 64-bit; mingw32),
if I try the "dist" target (mingw32-make dist), I get this error:
--------------------------------------
[...]
cp -rf "C:/emacs/trunk/nt/../leim" emacs-24.0.92
cp -rf "C:/emacs/trunk/nt/../site-lisp" emacs-24.0.92
cp -rf emacs-24.0.92/bin
cp: missing destination file operand after `emacs-24.0.92/bin'
Try `cp --help' for more information.
mingw32-make: *** [dist] Error 1
--------------------------------------
Looking at the file "nt/makefile", the failing sentence seems to be this one:
$(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
The problem is that `$(DIST_FILES)' expands to nothing, because I
specified no "--distfiles" argument to configure.bat. In fact, if I
comment out that line, everything seem to go fine.
Therefore, I request to allow making a binary distribution even in
this case, i.e., that the above-mentioned like of nt/makefile was not
written by the configure script when there is no --distfiles
arguments.
TIA.
In GNU Emacs 24.0.92.1 (i386-mingw-nt6.1.7601)
of 2011-12-09 on DANI-PC
Windowing system distributor `Microsoft Corp.', version 6.1.7601
configured using `configure --with-gcc (4.6) --no-opt --cflags
-fno-omit-frame-pointer'
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs.
(Sat, 10 Dec 2011 14:34:01 GMT)
Full text and
rfc822 format available.
Message #11 received at 10261 <at> debbugs.gnu.org (full text, mbox):
On 12/10/2011 4:25 AM, Dani Moncayo wrote:
> Therefore, I request to allow making a binary distribution even in
> this case, i.e., that the above-mentioned like of nt/makefile was not
> written by the configure script when there is no --distfiles
> arguments.
I will look into it.
Just out of curiosity, don't you want to package at least libXpm.dll in
your distribution via ---distfiles?
Christoph
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs.
(Sat, 10 Dec 2011 15:08:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 10261 <at> debbugs.gnu.org (full text, mbox):
>> Therefore, I request to allow making a binary distribution even in
>> this case, i.e., that the above-mentioned like of nt/makefile was not
^^^^
I meant "line". Sorry.
>> written by the configure script when there is no --distfiles
>> arguments.
>
>
> I will look into it.
Thank you.
> Just out of curiosity, don't you want to package at least libXpm.dll in your
> distribution via ---distfiles?
Currently I have no need to package any library, even libXpm.dll. I
use Emacs for editing text and source code, and I don't want to use
toolbars (at all! :)), so I don't see why I would need that libraries.
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs.
(Mon, 02 Jan 2012 22:12:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 10261 <at> debbugs.gnu.org (full text, mbox):
On 12/10/2011 4:25 AM, Dani Moncayo wrote:
> The problem is that `$(DIST_FILES)' expands to nothing, because I
> specified no "--distfiles" argument to configure.bat. In fact, if I
> comment out that line, everything seem to go fine.
>
> Therefore, I request to allow making a binary distribution even in
> this case, i.e., that the above-mentioned like of nt/makefile was not
> written by the configure script when there is no --distfiles
> arguments.
The following patch should fix the problem. It only copies the dist
files if any files were specified in the DIST_FILES variable via
configure.bat.
Eli, could you please review this to ensure that I am not
over-complicating things. Thanks.
=== modified file 'nt/makefile.w32-in'
--- nt/makefile.w32-in 2011-11-30 16:23:05 +0000
+++ nt/makefile.w32-in 2012-01-02 22:03:04 +0000
@@ -257,8 +257,22 @@
install-shortcuts:
"$(INSTALL_DIR)/bin/addpm" -q
-dist: install-bin
- mkdir $(TMP_DIST_DIR)
+maybe-copy-distfiles: maybe-copy-distfiles-$(SHELLTYPE)
+
+maybe-copy-distfiles-CMD: doit
+ @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR)
$(DIST_FILES) $(TMP_DIST_DIR)/bin
+
+maybe-copy-distfiles-SH: doit
+ @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
+ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
+ fi
+
+create-tmp-dist-dir:
+ mkdir "$(TMP_DIST_DIR)"
+# Also create bin directory for dist files.
+ mkdir "$(TMP_DIST_DIR)/bin"
+
+dist: install-bin create-tmp-dist-dir maybe-copy-distfiles
$(CP) "$(INSTALL_DIR)/BUGS" $(TMP_DIST_DIR)
$(CP) "$(INSTALL_DIR)/COPYING" $(TMP_DIST_DIR)
$(CP) "$(INSTALL_DIR)/README" $(TMP_DIST_DIR)
@@ -269,7 +283,6 @@
$(CP_DIR) "$(INSTALL_DIR)/lisp" $(TMP_DIST_DIR)
$(CP_DIR) "$(INSTALL_DIR)/leim" $(TMP_DIST_DIR)
$(CP_DIR) "$(INSTALL_DIR)/site-lisp" $(TMP_DIST_DIR)
- $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
$(COMSPEC)$(ComSpec) /c $(ARGQUOTE)zipdist.bat $(VERSION)$(ARGQUOTE)
$(DEL_TREE) $(TMP_DIST_DIR)
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Sat, 04 Feb 2012 22:47:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 10261 <at> debbugs.gnu.org (full text, mbox):
On 1/2/2012 3:08 PM, Christoph Scholtes wrote:
> On 12/10/2011 4:25 AM, Dani Moncayo wrote:
>
>> The problem is that `$(DIST_FILES)' expands to nothing, because I
>> specified no "--distfiles" argument to configure.bat. In fact, if I
>> comment out that line, everything seem to go fine.
>>
>> Therefore, I request to allow making a binary distribution even in
>> this case, i.e., that the above-mentioned like of nt/makefile was not
>> written by the configure script when there is no --distfiles
>> arguments.
>
> The following patch should fix the problem. It only copies the dist
> files if any files were specified in the DIST_FILES variable via
> configure.bat.
>
> Eli, could you please review this to ensure that I am not
> over-complicating things. Thanks.
>
> === modified file 'nt/makefile.w32-in'
> --- nt/makefile.w32-in 2011-11-30 16:23:05 +0000
> +++ nt/makefile.w32-in 2012-01-02 22:03:04 +0000
> @@ -257,8 +257,22 @@
> install-shortcuts:
> "$(INSTALL_DIR)/bin/addpm" -q
>
> -dist: install-bin
> - mkdir $(TMP_DIST_DIR)
> +maybe-copy-distfiles: maybe-copy-distfiles-$(SHELLTYPE)
> +
> +maybe-copy-distfiles-CMD: doit
> + @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR)
> $(DIST_FILES) $(TMP_DIST_DIR)/bin
> +
> +maybe-copy-distfiles-SH: doit
> + @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
> + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
> + fi
> +
> +create-tmp-dist-dir:
> + mkdir "$(TMP_DIST_DIR)"
> +# Also create bin directory for dist files.
> + mkdir "$(TMP_DIST_DIR)/bin"
> +
> +dist: install-bin create-tmp-dist-dir maybe-copy-distfiles
> $(CP) "$(INSTALL_DIR)/BUGS" $(TMP_DIST_DIR)
> $(CP) "$(INSTALL_DIR)/COPYING" $(TMP_DIST_DIR)
> $(CP) "$(INSTALL_DIR)/README" $(TMP_DIST_DIR)
> @@ -269,7 +283,6 @@
> $(CP_DIR) "$(INSTALL_DIR)/lisp" $(TMP_DIST_DIR)
> $(CP_DIR) "$(INSTALL_DIR)/leim" $(TMP_DIST_DIR)
> $(CP_DIR) "$(INSTALL_DIR)/site-lisp" $(TMP_DIST_DIR)
> - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
> $(COMSPEC)$(ComSpec) /c $(ARGQUOTE)zipdist.bat $(VERSION)$(ARGQUOTE)
> $(DEL_TREE) $(TMP_DIST_DIR)
Any issues with applying this patch?
Christoph
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Sun, 05 Feb 2012 16:49:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 10261 <at> debbugs.gnu.org (full text, mbox):
> Date: Sat, 04 Feb 2012 15:46:04 -0700
> From: Christoph Scholtes <cschol2112 <at> googlemail.com>
> CC: 10261 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
>
> Any issues with applying this patch?
No. (And sorry I missed this.)
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Sun, 05 Feb 2012 18:21:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 10261 <at> debbugs.gnu.org (full text, mbox):
Eli Zaretskii <eliz <at> gnu.org> writes:
>> Date: Sat, 04 Feb 2012 15:46:04 -0700
>> From: Christoph Scholtes <cschol2112 <at> googlemail.com>
>> CC: 10261 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
>>
>> Any issues with applying this patch?
>
> No. (And sorry I missed this.)
Thanks. I will commit this later today.
Reply sent
to
Christoph Scholtes <cschol2112 <at> googlemail.com>:
You have taken responsibility.
(Sun, 05 Feb 2012 20:24:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Dani Moncayo <dmoncayo <at> gmail.com>:
bug acknowledged by developer.
(Sun, 05 Feb 2012 20:24:02 GMT)
Full text and
rfc822 format available.
Message #31 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
Fixed in Emacs trunk r107121.
Message #32 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
On Sun, Feb 5, 2012 at 21:22, Christoph Scholtes
<cschol2112 <at> googlemail.com> wrote:
> Fixed in Emacs trunk r107121.
I'll check this the next time I build Emacs.
Thank you.
--
Dani Moncayo
Message #33 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
>> Fixed in Emacs trunk r107121.
>
> I'll check this the next time I build Emacs.
I've just tried this.
After a successful "mingw32-make bootstrap", and "mingw32-make info",
the "mingw32-make dist" ends up with this error:
if [ ! -s ../same-dir.tst ] ; then cp -rf ../etc C:/emacs/trunk/nt/.. ; fi
cp -rf icons C:/emacs/trunk/nt/../etc
if [ ! -s ../same-dir.tst ] ; then cp -rf ../info C:/emacs/trunk/nt/.. ; fi
if [ ! -s ../same-dir.tst ] ; then cp -f ../COPYING C:/emacs/trunk/nt/.. ; fi
cp -f ../COPYING C:/emacs/trunk/nt/../bin
rm ../same-dir.tst
rm C:/emacs/trunk/nt/../same-dir.tst
rm: cannot lstat `C:/emacs/trunk/nt/../same-dir.tst': No such file or directory
mingw32-make: [install-bin] Error 1 (ignored)
mkdir "emacs-24.0.93"
mkdir "emacs-24.0.93/bin"
/usr/bin/sh: -c: line 2: syntax error: unexpected end of file
mingw32-make: *** [maybe-copy-distfiles-SH] Error 258
I see that $(SHELLTYPE) has been set to SH, but that is wrong, because
I'm using the windows standard cmd.exe shell.
--
Dani Moncayo
Message #34 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
> Date: Tue, 14 Feb 2012 20:20:51 +0100
> From: Dani Moncayo <dmoncayo <at> gmail.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 10261-done <at> debbugs.gnu.org
>
> After a successful "mingw32-make bootstrap", and "mingw32-make info",
> the "mingw32-make dist" ends up with this error:
>
> if [ ! -s ../same-dir.tst ] ; then cp -rf ../etc C:/emacs/trunk/nt/.. ; fi
> cp -rf icons C:/emacs/trunk/nt/../etc
> if [ ! -s ../same-dir.tst ] ; then cp -rf ../info C:/emacs/trunk/nt/.. ; fi
> if [ ! -s ../same-dir.tst ] ; then cp -f ../COPYING C:/emacs/trunk/nt/.. ; fi
> cp -f ../COPYING C:/emacs/trunk/nt/../bin
> rm ../same-dir.tst
> rm C:/emacs/trunk/nt/../same-dir.tst
> rm: cannot lstat `C:/emacs/trunk/nt/../same-dir.tst': No such file or directory
> mingw32-make: [install-bin] Error 1 (ignored)
> mkdir "emacs-24.0.93"
> mkdir "emacs-24.0.93/bin"
> /usr/bin/sh: -c: line 2: syntax error: unexpected end of file
> mingw32-make: *** [maybe-copy-distfiles-SH] Error 258
>
>
> I see that $(SHELLTYPE) has been set to SH
That in itself cannot be the problem, because the Makefile must be
workable with SH as well.
> but that is wrong, because I'm using the windows standard cmd.exe
> shell.
If Make can find some sh.exe somewhere on PATH, it will always use it,
unless you explicitly say "make ... SHELL=cmd.exe".
Message #35 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
>> I see that $(SHELLTYPE) has been set to SH
>
> That in itself cannot be the problem, because the Makefile must be
> workable with SH as well.
>
>> but that is wrong, because I'm using the windows standard cmd.exe
>> shell.
>
> If Make can find some sh.exe somewhere on PATH, it will always use it,
> unless you explicitly say "make ... SHELL=cmd.exe".
Indeed, I had a "sh.exe" program in the PATH of that cmd session (the
one that comes with MSYS), and after renaming it to something else,
the "dist" target seem to work fine now. (thank you)
But I still wonder the reason of the former failure: If a "sh.exe"
shell is supported too, what was wrong with my initial setup?
And BTW, I'm wondering too: what's the point of the "barebin" file?
In which cases is it useful? Is that documented somewhere? Should
not be separate targets for making the "bin" and "barebin" files?
TIA.
--
Dani Moncayo
Message #36 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
> Date: Tue, 14 Feb 2012 21:51:20 +0100
> From: Dani Moncayo <dmoncayo <at> gmail.com>
> Cc: cschol2112 <at> googlemail.com, 10261-done <at> debbugs.gnu.org
>
> But I still wonder the reason of the former failure: If a "sh.exe"
> shell is supported too, what was wrong with my initial setup?
I don't know. Please try to find out, because it should work. My
first guess would be that this command:
maybe-copy-distfiles-SH: doit
@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
$(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
fi
should instead say
@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) = "" ] ; then \
i.e., one '=', not 2.
> And BTW, I'm wondering too: what's the point of the "barebin" file?
For people who want to be able to dump their own Emacs after
preloading a different collection of Lisp files, I think. I never
used it, FWIW.
> Should not be separate targets for making the "bin" and "barebin"
> files?
I actually think we need to deprecate it and eventual stop building
and distributing it. I doubt anyone ever used it.
Message #37 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
>> But I still wonder the reason of the former failure: If a "sh.exe"
>> shell is supported too, what was wrong with my initial setup?
>
> I don't know. Please try to find out, because it should work. My
> first guess would be that this command:
>
> maybe-copy-distfiles-SH: doit
> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
> $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
> fi
>
> should instead say
>
> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) = "" ] ; then \
>
> i.e., one '=', not 2.
For the record: I tried this, and it didn't make a difference.
Currently I don't know where is the problem.
--
Dani Moncayo
Message #38 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
> Date: Wed, 15 Feb 2012 09:30:29 +0100
> From: Dani Moncayo <dmoncayo <at> gmail.com>
> Cc: cschol2112 <at> googlemail.com, 10261-done <at> debbugs.gnu.org
>
> > @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) = "" ] ; then \
> >
> > i.e., one '=', not 2.
>
> For the record: I tried this, and it didn't make a difference.
If you remove the @ prefix from that line, what does Make display for
this command? (I want to see what does the $(ARGQUOTE) magic expand
to.)
Message #39 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
>> > @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) = "" ] ; then \
>> >
>> > i.e., one '=', not 2.
>>
>> For the record: I tried this, and it didn't make a difference.
>
> If you remove the @ prefix from that line, what does Make display for
> this command? (I want to see what does the $(ARGQUOTE) magic expand
> to.)
It displays this:
[...]
mingw32-make: [install-bin] Error 1 (ignored)
mkdir "emacs-24.0.93"
mkdir "emacs-24.0.93/bin"
if [ ! ''=="" ] ; then \
cp -rf emacs-24.0.93/bin
/usr/bin/sh: -c: line 2: syntax error: unexpected end of file
mingw32-make: *** [maybe-copy-distfiles-SH] Error 258
The problem was
I think I've found the problem: the "cp -rf" line is lacking a final "
; \", and because of that, the shell sees an "if" without a matching
"fi".
The following patch should fix this problem:
=== modified file 'nt/makefile.w32-in'
--- nt/makefile.w32-in 2012-02-05 20:14:54 +0000
+++ nt/makefile.w32-in 2012-02-15 18:32:45 +0000
@@ -264,7 +264,7 @@
maybe-copy-distfiles-SH: doit
@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
- $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
+ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \
fi
create-tmp-dist-dir:
I've not bootstrapped again with this patch applied, but I've done the
changes directly in nt/makefile and now the "dist" target does its job
successfully.
One question, BTW: if we have the $(ARGQUOTE) variable to stand for a
suitable/shell-specific quote, why don't we use it in the right side
of the "==" too? i.e., why don't we do:
@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)==$(ARGQUOTE)$(ARGQUOTE) ] ; then \
instead of
@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
?
--
Dani Moncayo
Message #40 received at 10261-done <at> debbugs.gnu.org (full text, mbox):
On 2/15/2012 11:50 AM, Dani Moncayo wrote:
> The following patch should fix this problem:
>
> === modified file 'nt/makefile.w32-in'
> --- nt/makefile.w32-in 2012-02-05 20:14:54 +0000
> +++ nt/makefile.w32-in 2012-02-15 18:32:45 +0000
> @@ -264,7 +264,7 @@
>
> maybe-copy-distfiles-SH: doit
> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
> - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
> + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \
> fi
>
> create-tmp-dist-dir:
Thank you for debugging my bugging. :)
> One question, BTW: if we have the $(ARGQUOTE) variable to stand for a
> suitable/shell-specific quote, why don't we use it in the right side
> of the "==" too? i.e., why don't we do:
> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)==$(ARGQUOTE)$(ARGQUOTE) ] ; then \
> instead of
> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
> ?
IIRC, I took the ARGQUOTE piece from some other piece of some Windows
makefile. I now remember that didn't have any way to test the sh
behavior since I use cmd.exe. Thanks again for working on this.
Christoph
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Thu, 23 Feb 2012 07:26:02 GMT)
Full text and
rfc822 format available.
Message #43 received at 10261 <at> debbugs.gnu.org (full text, mbox):
> The following patch should fix this problem:
>
> === modified file 'nt/makefile.w32-in'
> --- nt/makefile.w32-in 2012-02-05 20:14:54 +0000
> +++ nt/makefile.w32-in 2012-02-15 18:32:45 +0000
> @@ -264,7 +264,7 @@
>
> maybe-copy-distfiles-SH: doit
> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
> - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
> + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \
> fi
>
> create-tmp-dist-dir:
If this patch is ok, could someone commit it?
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Thu, 23 Feb 2012 07:56:01 GMT)
Full text and
rfc822 format available.
Message #46 received at 10261 <at> debbugs.gnu.org (full text, mbox):
>> The following patch should fix this problem:
>>
>> === modified file 'nt/makefile.w32-in'
>> --- nt/makefile.w32-in 2012-02-05 20:14:54 +0000
>> +++ nt/makefile.w32-in 2012-02-15 18:32:45 +0000
>> @@ -264,7 +264,7 @@
>>
>> maybe-copy-distfiles-SH: doit
>> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
>> - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
>> + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \
>> fi
>>
>> create-tmp-dist-dir:
> If this patch is ok, could someone commit it?
Looks correct, committed (tho I couldn't find the original message you
quote, so I don't know who to attribute that to).
Stefan
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Thu, 23 Feb 2012 08:03:02 GMT)
Full text and
rfc822 format available.
Message #49 received at 10261 <at> debbugs.gnu.org (full text, mbox):
>> If this patch is ok, could someone commit it?
>
> Looks correct, committed (tho I couldn't find the original message you
> quote, so I don't know who to attribute that to).
You can see the thread here:
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10261
But I don't understand why some messages don't appear in
(http://lists.gnu.org/archive/html/bug-gnu-emacs). It seems like the
messages sent to "(bug-number)@debbugs.org" are not showed there.
IMO, they should.
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Thu, 23 Feb 2012 08:04:01 GMT)
Full text and
rfc822 format available.
Message #52 received at 10261 <at> debbugs.gnu.org (full text, mbox):
> But I don't understand why some messages don't appear in
> (http://lists.gnu.org/archive/html/bug-gnu-emacs). It seems like the
> messages sent to "(bug-number)@debbugs.org" are not showed there.
^^^^^^^^^^^^^^^^^^^^^^^^^
> IMO, they should.
Sorry, I mean "(bug-number)-done <at> debbugs.org"
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Thu, 23 Feb 2012 08:40:02 GMT)
Full text and
rfc822 format available.
Message #55 received at 10261 <at> debbugs.gnu.org (full text, mbox):
Dani Moncayo wrote:
>> But I don't understand why some messages don't appear in
>> (http://lists.gnu.org/archive/html/bug-gnu-emacs). It seems like the
>> messages sent to "(bug-number)@debbugs.org" are not showed there.
> ^^^^^^^^^^^^^^^^^^^^^^^^^
>> IMO, they should.
>
> Sorry, I mean "(bug-number)-done <at> debbugs.org"
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9467
(Basically, don't send to a -done address unless you want to close an open bug.
FWIW, Mail-Followup-To is set appropriately in -done messages.)
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Mon, 27 Feb 2012 19:46:02 GMT)
Full text and
rfc822 format available.
Message #58 received at 10261 <at> debbugs.gnu.org (full text, mbox):
I'm re-sending a message from Eli to this list, because I think it
didn't arrive to you, since it was sent to a "-done" address
(10261-done <at> debbugs.gnu.org).
On Tue, Feb 14, 2012 at 22:08, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>[...]
>> And BTW, I'm wondering too: what's the point of the "barebin" file?
>
> For people who want to be able to dump their own Emacs after
> preloading a different collection of Lisp files, I think. I never
> used it, FWIW.
>
>> Should not be separate targets for making the "bin" and "barebin"
>> files?
>
> I actually think we need to deprecate it and eventual stop building
> and distributing it. I doubt anyone ever used it.
If nobody uses this "barebin" target, I also suggest to deprecate/remove it.
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Fri, 23 Mar 2012 19:31:03 GMT)
Full text and
rfc822 format available.
Message #61 received at 10261 <at> debbugs.gnu.org (full text, mbox):
Hi,
In this bug report, the "dist" target of the nt/makefile was fixed
because it failed when no --distfiles argument was given to configure
(it always tried to run the "cp" command, and in this case failed).
Well, now I've tried to build Emacs in my system, but this time giving
a --distfiles argument to configure (for including the libXpm.dll in
the binary distribution).
I've found that the zip file has been generated without errors, but
the dll file has not been included in the "bin" subdirectory.
After doing a few experiments, I've found that the problem is in the
"maybe-copy-distfiles-SH" target. Currently the target is defined
like this:
-------------------------
maybe-copy-distfiles-SH: doit
@if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
$(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \
fi
-------------------------
and I've seen that the "if" condition never evaluates to true, so that
my distfiles are never copied to the bin subdirectory (regardless of
the value of DIST_FILES).
I think I've found a solution (I've tested it): write the "if"
condition like this:
if [ -n $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) ] ; then \
This is the corresponding patch:
=== modified file 'nt/makefile.w32-in'
--- nt/makefile.w32-in 2012-02-27 03:20:00 +0000
+++ nt/makefile.w32-in 2012-03-23 18:57:00 +0000
@@ -263,7 +263,7 @@
@if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR)
$(DIST_FILES) $(TMP_DIST_DIR)/bin
maybe-copy-distfiles-SH: doit
- @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
+ @if [ -n $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) ] ; then \
$(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \
fi
Do you find it correct? If so, please install it.
Thanks.
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Fri, 23 Mar 2012 19:56:01 GMT)
Full text and
rfc822 format available.
Message #64 received at 10261 <at> debbugs.gnu.org (full text, mbox):
> -------------------------
> maybe-copy-distfiles-SH: doit
>
> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \
>
> $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \
>
> fi
> -------------------------
I've done a few more test, and actually the problem was in that the
"==" should be surrounded by spaces.
So install the fix that you prefer (this one or the one I sent before).
--
Dani Moncayo
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Wed, 11 Apr 2012 06:36:01 GMT)
Full text and
rfc822 format available.
Message #67 received at 10261 <at> debbugs.gnu.org (full text, mbox):
Dani Moncayo <dmoncayo <at> gmail.com> writes:
> I've done a few more test, and actually the problem was in that the
> "==" should be surrounded by spaces.
>
> So install the fix that you prefer (this one or the one I sent before).
Done.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#10261; Package
emacs,w32.
(Wed, 11 Apr 2012 13:14:02 GMT)
Full text and
rfc822 format available.
Message #70 received at 10261 <at> debbugs.gnu.org (full text, mbox):
> > I've done a few more test, and actually the problem was in that the
> > "==" should be surrounded by spaces.
> >
> > So install the fix that you prefer (this one or the one I sent before).
>
> Done.
Thanks.
Actually the bug was only about the "maybe-copy-distfiles-SH" target
("maybe-copy-distfiles-CMD" is not executed in my current
environment), but I guess that the additional change in
"maybe-copy-distfiles-CMD" is fine too.
So, I guess this bug report could be closed.
Thanks again.
--
Dani Moncayo
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Thu, 10 May 2012 11:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 13 years and 104 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.