From unknown Fri Aug 15 16:56:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10245: 23.3; handle Common Lisp :documentation strings Resent-From: Robert Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Dec 2011 17:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 10245@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13232806002231 (code B ref -1); Wed, 07 Dec 2011 17:57:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Dec 2011 17:56:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RYLjU-0000Zv-Cz for submit@debbugs.gnu.org; Wed, 07 Dec 2011 12:56:40 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RYLjR-0000Zm-TL for submit@debbugs.gnu.org; Wed, 07 Dec 2011 12:56:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RYLif-0000yD-7I for submit@debbugs.gnu.org; Wed, 07 Dec 2011 12:55:53 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([140.186.70.17]:49584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYLif-0000y4-5d for submit@debbugs.gnu.org; Wed, 07 Dec 2011 12:55:49 -0500 Received: from eggs.gnu.org ([140.186.70.92]:44526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYLia-00054t-9B for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2011 12:55:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RYLiY-0000xM-Rj for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2011 12:55:44 -0500 Received: from mail-ee0-f73.google.com ([74.125.83.73]:43075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RYLiY-0000x6-J2 for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2011 12:55:42 -0500 Received: by eekb57 with SMTP id b57so16410eek.0 for ; Wed, 07 Dec 2011 09:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=from:to:subject:date:message-id:mime-version:content-type :x-system-of-record; bh=w1d/ZItFRXTtacv1INTuBHC6zUV1XAgnfhz5GB8c3cs=; b=pCpoUVn/0WJHpiJ9D/PZYMA1P5sXEoFTuIKmKeP81HwZyvGy4MSOcbDwCd4u3b3iAL emceUtla1yuprf8RsiQg== Received: by 10.14.16.11 with SMTP id g11mr2240224eeg.16.1323280541284; Wed, 07 Dec 2011 09:55:41 -0800 (PST) Received: by 10.14.16.11 with SMTP id g11mr2240218eeg.16.1323280541132; Wed, 07 Dec 2011 09:55:41 -0800 (PST) Received: from hpza9.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id i11si1722878eea.0.2011.12.07.09.55.41 (version=TLSv1/SSLv3 cipher=AES128-SHA); Wed, 07 Dec 2011 09:55:41 -0800 (PST) Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73]) by hpza9.eem.corp.google.com (Postfix) with ESMTPS id CDDAB5C0050 for ; Wed, 7 Dec 2011 09:55:40 -0800 (PST) Received: from paradicsom.nyc.corp.google.com.google.com (paradicsom.nyc.corp.google.com [172.26.76.220]) by wpaz9.hot.corp.google.com with ESMTP id pB7Htcwk018571 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Wed, 7 Dec 2011 09:55:39 -0800 From: Robert Brown Date: Wed, 07 Dec 2011 12:55:38 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) Several Common Lisp forms, such as defgeneric and defclass, support documentation strings following a :documentation keyword. Here's an example of a point class with documentation strings: (defclass foo () ((x :reader x :initarg :x :documentation "X coordinate") (y :reader y :initarg :y :documentation "Y coordinate")) (:documentation "A point in the plane")) Emacs currently fontifies the documentation strings above using font-lock-string-face instead of font-lock-doc-face. The code below fixes the problem for me. It is a refactoring of lisp-font-lock-syntactic-face-function in lisp/emacs-lisp/lisp-mode.el with the addition of a new function to detect documentation keywords. If lisp-font-lock-syntactic-face-function is replaced with the code below, Emacs fontifies strings after :documentation keywords using font-lock-doc-face. (defun string-in-doc-position-p (state) (let* ((listbeg (nth 1 state)) (firstsym (and listbeg (save-excursion (goto-char listbeg) (and (looking-at "([ \t\n]*\\(\\(\\sw\\|\\s_\\)+\\)") (match-string 1))))) (docelt (and firstsym (get (intern-soft firstsym) lisp-doc-string-elt-property)))) (and docelt ;; It's a string in a form that can have a docstring. ;; Check whether it's in docstring position. (save-excursion (when (functionp docelt) (goto-char (match-end 1)) (setq docelt (funcall docelt))) (goto-char listbeg) (forward-char 1) (condition-case nil (while (and (> docelt 0) (< (point) startpos) (progn (forward-sexp 1) t)) (setq docelt (1- docelt))) (error nil)) (and (zerop docelt) (<= (point) startpos) (progn (forward-comment (point-max)) t) (= (point) (nth 8 state))))))) (defun string-after-documentation-keyword-p (state) (and (nth 1 state) ; we are inside a Lisp form (let ((startpos (nth 8 state))) (and startpos (let ((ok nil) (prevsym (save-excursion (goto-char startpos) (condition-case nil (progn (backward-sexp 1) (setf ok t)) (error nil)) (and ok (looking-at "\\(\\sw+\\)") (match-string 1))))) (equal prevsym ":documentation")))))) (defun lisp-font-lock-syntactic-face-function (state) (if (nth 3 state) ;; This might be a (doc)string or a |...| symbol. (let ((startpos (nth 8 state))) (if (eq (char-after startpos) ?|) ;; This is not a string, but a |...| symbol. nil (if (or (string-in-doc-position-p state) (string-after-documentation-keyword-p state)) font-lock-doc-face font-lock-string-face))) font-lock-comment-face)) In GNU Emacs 23.3.1 (x86_64-unknown-linux-gnu) of 2011-07-15 on paradicsom.nyc.corp.google.com configured using `configure '--prefix' '/local/software/package/emacs-23.3.1' '--without-x'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Recent input: ESC [ > 1 ; 2 3 0 5 ; 0 c ESC x b u g - TAB ESC DEL ESC DEL r e p o r t - TAB RET Recent messages: ("emacs") Loading /local/software/source-trees/emacs-jabber/jabber-autoloads.el (source)...done Load-path shadows: /local/software/source-trees/cc-mode/cc-fonts hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-fonts /local/software/source-trees/cc-mode/cc-align hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-align /local/software/source-trees/cc-mode/cc-menus hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-menus /local/software/source-trees/cc-mode/cc-engine hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-engine /local/software/source-trees/cc-mode/cc-mode hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-mode /local/software/source-trees/cc-mode/cc-awk hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-awk /local/software/source-trees/cc-mode/cc-defs hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-defs /local/software/source-trees/cc-mode/cc-vars hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-vars /local/software/source-trees/cc-mode/cc-styles hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-styles /local/software/source-trees/cc-mode/cc-bytecomp hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-bytecomp /local/software/source-trees/cc-mode/cc-compat hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-compat /local/software/source-trees/cc-mode/cc-cmds hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-cmds /local/software/source-trees/cc-mode/cc-langs hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-langs Features: (shadow sort mail-extr message ecomplete rfc822 mml easymenu mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1 hex-util hashcash mail-utils warnings emacsbug uniquify advice help-fns advice-preload slime-autoloads regexp-opt cl cl-19 ediff-hook vc-hooks lisp-float-type lisp-mode register page menu-bar rfn-eshadow timer jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 07 19:05:06 2011 Received: (at control) by debbugs.gnu.org; 8 Dec 2011 00:05:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RYRU1-0003Mj-Ob for submit@debbugs.gnu.org; Wed, 07 Dec 2011 19:05:05 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RYRTz-0003Mb-GT for control@debbugs.gnu.org; Wed, 07 Dec 2011 19:05:03 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RYRTF-0003C1-2G for control@debbugs.gnu.org; Wed, 07 Dec 2011 19:04:17 -0500 Date: Wed, 07 Dec 2011 19:04:17 -0500 Message-Id: Subject: control message for bug 10245 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) forcemerge 9130 10245 From unknown Fri Aug 15 16:56:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10245: 23.3; handle Common Lisp :documentation strings Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2011 13:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Brown Cc: 10245@debbugs.gnu.org Received: via spool by 10245-submit@debbugs.gnu.org id=B10245.132335107624611 (code B ref 10245); Thu, 08 Dec 2011 13:32:01 +0000 Received: (at 10245) by debbugs.gnu.org; 8 Dec 2011 13:31:16 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RYe4C-0006Ou-Aa for submit@debbugs.gnu.org; Thu, 08 Dec 2011 08:31:16 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RYe49-0006Ok-FQ for 10245@debbugs.gnu.org; Thu, 08 Dec 2011 08:31:14 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pB8DUMDG017263; Thu, 8 Dec 2011 08:30:23 -0500 Received: by pastel.home (Postfix, from userid 20848) id 372F059403; Thu, 8 Dec 2011 08:30:22 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Thu, 08 Dec 2011 08:30:22 -0500 In-Reply-To: (Robert Brown's message of "Wed, 07 Dec 2011 12:55:38 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4064=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4064> : streams <708844> : uri <1024019> X-Spam-Score: -4.6 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) > Several Common Lisp forms, such as defgeneric and defclass, support > documentation strings following a :documentation keyword. > Here's an example of a point class with documentation strings: > (defclass foo () > ((x :reader x :initarg :x :documentation "X coordinate") > (y :reader y :initarg :y :documentation "Y coordinate")) > (:documentation "A point in the plane")) > Emacs currently fontifies the documentation strings above using > font-lock-string-face instead of font-lock-doc-face. > The code below fixes the problem for me. It is a refactoring of > lisp-font-lock-syntactic-face-function in lisp/emacs-lisp/lisp-mode.el > with the addition of a new function to detect documentation keywords. > If lisp-font-lock-syntactic-face-function is replaced with the code > below, Emacs fontifies strings after :documentation keywords using > font-lock-doc-face. Thanks. This would be a welcomed addition, for 24.2 (24.1 is in testing already so it's too late to add such features). But I think it needs a bit of massaging first, so that this new feature is not enabled in emacs-lisp-mode. E.g. I'd maybe change lisp-font-lock-syntactic-face-function to (run-hook-with-args-until-success 'lisp-string-in-doc-position-functions state) and then add string-after-documentation-keyword-p to this hook when in Common Lisp mode. If you can provide such a thing as a patch (i.e. output of "bzr diff" or "diff -u"), that would be even better. Stefan > (defun string-in-doc-position-p (state) > (let* ((listbeg (nth 1 state)) > (firstsym (and listbeg > (save-excursion > (goto-char listbeg) > (and (looking-at "([ \t\n]*\\(\\(\\sw\\|\\s_\\)+\\)") > (match-string 1))))) > (docelt (and firstsym (get (intern-soft firstsym) > lisp-doc-string-elt-property)))) > (and docelt > ;; It's a string in a form that can have a docstring. > ;; Check whether it's in docstring position. > (save-excursion > (when (functionp docelt) > (goto-char (match-end 1)) > (setq docelt (funcall docelt))) > (goto-char listbeg) > (forward-char 1) > (condition-case nil > (while (and (> docelt 0) (< (point) startpos) > (progn (forward-sexp 1) t)) > (setq docelt (1- docelt))) > (error nil)) > (and (zerop docelt) (<= (point) startpos) > (progn (forward-comment (point-max)) t) > (= (point) (nth 8 state))))))) > (defun string-after-documentation-keyword-p (state) > (and (nth 1 state) ; we are inside a Lisp form > (let ((startpos (nth 8 state))) > (and startpos > (let ((ok nil) > (prevsym (save-excursion > (goto-char startpos) > (condition-case nil > (progn (backward-sexp 1) (setf ok t)) > (error nil)) > (and ok > (looking-at "\\(\\sw+\\)") > (match-string 1))))) > (equal prevsym ":documentation")))))) > (defun lisp-font-lock-syntactic-face-function (state) > (if (nth 3 state) > ;; This might be a (doc)string or a |...| symbol. > (let ((startpos (nth 8 state))) > (if (eq (char-after startpos) ?|) > ;; This is not a string, but a |...| symbol. > nil > (if (or (string-in-doc-position-p state) > (string-after-documentation-keyword-p state)) > font-lock-doc-face > font-lock-string-face))) > font-lock-comment-face)) > In GNU Emacs 23.3.1 (x86_64-unknown-linux-gnu) > of 2011-07-15 on paradicsom.nyc.corp.google.com > configured using `configure '--prefix' '/local/software/package/emacs-23.3.1' '--without-x'' > Important settings: > value of $LC_ALL: nil > value of $LC_COLLATE: nil > value of $LC_CTYPE: nil > value of $LC_MESSAGES: nil > value of $LC_MONETARY: nil > value of $LC_NUMERIC: nil > value of $LC_TIME: nil > value of $LANG: en_US.UTF-8 > value of $XMODIFIERS: nil > locale-coding-system: utf-8-unix > default enable-multibyte-characters: t > Major mode: Lisp Interaction > Minor modes in effect: > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > auto-encryption-mode: t > auto-compression-mode: t > line-number-mode: t > Recent input: > ESC [ > 1 ; 2 3 0 5 ; 0 c ESC x b u g - TAB ESC DEL > ESC DEL r e p o r t - TAB RET > Recent messages: > ("emacs") > Loading /local/software/source-trees/emacs-jabber/jabber-autoloads.el (source)...done > Load-path shadows: > /local/software/source-trees/cc-mode/cc-fonts hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-fonts > /local/software/source-trees/cc-mode/cc-align hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-align > /local/software/source-trees/cc-mode/cc-menus hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-menus > /local/software/source-trees/cc-mode/cc-engine hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-engine > /local/software/source-trees/cc-mode/cc-mode hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-mode > /local/software/source-trees/cc-mode/cc-awk hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-awk > /local/software/source-trees/cc-mode/cc-defs hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-defs > /local/software/source-trees/cc-mode/cc-vars hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-vars > /local/software/source-trees/cc-mode/cc-styles hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-styles > /local/software/source-trees/cc-mode/cc-bytecomp hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-bytecomp > /local/software/source-trees/cc-mode/cc-compat hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-compat > /local/software/source-trees/cc-mode/cc-cmds hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-cmds > /local/software/source-trees/cc-mode/cc-langs hides /local/software/package/emacs-23.3.1/share/emacs/23.3/lisp/progmodes/cc-langs > Features: > (shadow sort mail-extr message ecomplete rfc822 mml easymenu mml-sec > password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 > rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc > time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1 > hex-util hashcash mail-utils warnings emacsbug uniquify advice help-fns > advice-preload slime-autoloads regexp-opt cl cl-19 ediff-hook vc-hooks > lisp-float-type lisp-mode register page menu-bar rfn-eshadow timer > jit-lock font-lock syntax facemenu font-core frame cham georgian > utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean > japanese hebrew greek romanian slovak czech european ethiopic indian > cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev > loaddefs button minibuffer faces cus-face files text-properties overlay > md5 base64 format env code-pages mule custom widget > hashtable-print-readable backquote make-network-process multi-tty emacs) From unknown Fri Aug 15 16:56:54 2025 X-Loop: help-debbugs@gnu.org Subject: bug#10245: 23.3; handle Common Lisp :documentation strings Resent-From: Robert Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Dec 2011 16:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: 10245@debbugs.gnu.org Received: via spool by 10245-submit@debbugs.gnu.org id=B10245.13233605216810 (code B ref 10245); Thu, 08 Dec 2011 16:09:01 +0000 Received: (at 10245) by debbugs.gnu.org; 8 Dec 2011 16:08:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RYgWX-0001ln-5a for submit@debbugs.gnu.org; Thu, 08 Dec 2011 11:08:41 -0500 Received: from mail-ey0-f202.google.com ([209.85.215.202]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RYgWU-0001lc-W0 for 10245@debbugs.gnu.org; Thu, 08 Dec 2011 11:08:40 -0500 Received: by eaak10 with SMTP id k10so38272eaa.3 for <10245@debbugs.gnu.org>; Thu, 08 Dec 2011 08:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=from:mime-version:content-type:content-transfer-encoding:message-id :date:to:cc:subject:in-reply-to:references:x-mailer :x-system-of-record; bh=vLfJjCgm495RwNc5sCUHVaKIh2rouBqUmvdvDgR7NuA=; b=KyDjLkkgyFbkRMZZybTPmE4itM7Ha+nt90QIaQ7kwoW31nDPXl5crRjWP77ooJSfVl DYVLDZfGSkiErg6GVaIw== Received: by 10.14.17.39 with SMTP id i39mr242744eei.4.1323360468254; Thu, 08 Dec 2011 08:07:48 -0800 (PST) Received: by 10.14.17.39 with SMTP id i39mr242737eei.4.1323360468160; Thu, 08 Dec 2011 08:07:48 -0800 (PST) Received: from hpza9.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id a53si3789843eeg.1.2011.12.08.08.07.48 (version=TLSv1/SSLv3 cipher=AES128-SHA); Thu, 08 Dec 2011 08:07:48 -0800 (PST) Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by hpza9.eem.corp.google.com (Postfix) with ESMTPS id E3C825C0063; Thu, 8 Dec 2011 08:07:47 -0800 (PST) Received: from paradicsom.nyc.corp.google.com.google.com (paradicsom.nyc.corp.google.com [172.26.76.220]) by wpaz5.hot.corp.google.com with ESMTP id pB8G7j1P007070 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 8 Dec 2011 08:07:46 -0800 From: Robert Brown MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20192.57553.363945.632173@paradicsom.nyc.corp.google.com> Date: Thu, 8 Dec 2011 11:07:45 -0500 In-Reply-To: References: X-Mailer: VM 7.19 under Emacs 23.3.1 X-System-Of-Record: true X-Spam-Score: -4.8 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Stefan Monnier writes: > Thanks. This would be a welcomed addition, for 24.2 (24.1 is in testing > already so it's too late to add such features). But I think it needs > a bit of massaging first, so that this new feature is not enabled in > emacs-lisp-mode. E.g. I'd maybe change > lisp-font-lock-syntactic-face-function to > (run-hook-with-args-until-success 'lisp-string-in-doc-position-functions > state) and then add string-after-documentation-keyword-p to this hook > when in Common Lisp mode. If you can provide such a thing as a patch > (i.e. output of "bzr diff" or "diff -u"), that would be even better. OK, I'll give that a try. I'll have to look at how Emacs Lisp mode and Common Lisp mode interact. The latter seems to inherit a lot of functionality from the former ... I'm not even sure they are really distinct. bob From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 16 12:05:30 2015 Received: (at control) by debbugs.gnu.org; 16 Dec 2015 17:05:30 +0000 Received: from localhost ([127.0.0.1]:53777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a9FW5-0008Lp-K8 for submit@debbugs.gnu.org; Wed, 16 Dec 2015 12:05:30 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:33765) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1a9FW0-0008LZ-In for control@debbugs.gnu.org; Wed, 16 Dec 2015 12:05:28 -0500 Received: by mail-ob0-f174.google.com with SMTP id sd4so37590869obb.0 for ; Wed, 16 Dec 2015 09:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=lap7Z9tpIjA9O7hrBK4A8p9T3nx3a8WW20qcwA06vWc=; b=roSRe5AZzygzQEaHQiDf9LPFkuEpnq+pdbjj9K2rDKuYQeWFieXRuKhcdLWOTVgyzl 3HOX6pRD1KnoJPvKKyfel7RTbhPIzebUnZiPrTgQLXQmhJpcMdP+2e+FKHWHQ8yo6snl kxmT0JAgB+GbYJMNpVwI0seV90hGT0qxNOJHuYpxyt5VJyUD3OvujuEqVBL1Z0jXKhAw aThopydKrTqXdbXo4gc5SmnvuJdY+zkAy8GQvezyyvSmhUIYBF5OCRMkjxCfJ5i8VepM k/U2peZGyrvm0XLTOYyNlwCtatYvhnhlTGnu6IYdLu3GoUlcU43SY/G0UfM3+viKm0i9 7Sag== MIME-Version: 1.0 X-Received: by 10.60.115.194 with SMTP id jq2mr35738231oeb.7.1450285518837; Wed, 16 Dec 2015 09:05:18 -0800 (PST) Received: by 10.182.24.8 with HTTP; Wed, 16 Dec 2015 09:05:18 -0800 (PST) Date: Wed, 16 Dec 2015 22:35:18 +0530 Message-ID: Subject: From: Shakthi Kannan To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 9130 -- Shakthi Kannan http://www.shakthimaan.com [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.174 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (shakthimaan[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.214.174 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 TVD_SPACE_RATIO No description available. 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unarchive 9130 -- Shakthi Kannan http://www.shakthimaan.com [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.214.174 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.214.174 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (shakthimaan[at]gmail.com) -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 TVD_SPACE_RATIO No description available. 2.0 BLANK_SUBJECT Subject is present but empty unarchive 9130 -- Shakthi Kannan http://www.shakthimaan.com