GNU bug report logs - #10220
Make check errors!

Previous Next

Package: coreutils;

Reported by: Basavaraj B <basavaraja.b <at> gmail.com>

Date: Mon, 5 Dec 2011 11:31:02 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 10220-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Basavaraj B <basavaraja.b <at> gmail.com>
Cc: 10220-done <at> debbugs.gnu.org
Subject: Re: bug#10220: Make check errors!
Date: Mon, 05 Dec 2011 14:07:33 -0800
Thanks for reporting that.  I installed the following
fix into the trunk, and something like it should appear
in the next coreutils version.  If you want to work around
it by hand without installing the autotools, you can
substitute \043 for \# in src/Makefile before typing
'make'.

2011-12-05  Paul Eggert  <eggert <at> cs.ucla.edu>

	maint: don't assume GNU make \# syntax
	Problem reported by Basavaraj B (Bug#10220).
	(fs_normalize_perl_subst): Use \043 rather than \#.
	\043 is portable to all ASCIIish platforms, whereas \# is portable
	only to platforms that are compatible with GNU make (and are
	incompatible with POSIX make).  Porting this to EBCDIC is left as
	an exercise for the reader....

diff --git a/src/Makefile.am b/src/Makefile.am
index b0b7eb5..f36e138 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -571,11 +571,11 @@ fs_normalize_perl_subst =			\
   -e 's/(\s+0x)(\X{6})\b/$${1}00$$2/;'		\
   -e 's/(\s+0x)(\X{7})\b/$${1}0$$2/;'		\
   -e 's/^\s+//;'				\
-  -e 's/^\#define\s+//;'			\
+  -e 's/^\043define\s+//;'			\
   -e 's/^_(XIAFS)/$$1/;'			\
   -e 's/^USBDEVICE/USBDEVFS/;'			\
   -e 's/NTFS_SB/NTFS/;'				\
-  -e 's/^/\# define S_MAGIC_/;'			\
+  -e 's/^/\043 define S_MAGIC_/;'		\
   -e 's,\s*/\* .*? \*/,,;'
 
 CLEANFILES += fs-magic




This bug report was last modified 13 years and 170 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.