GNU bug report logs - #10181
24.0.92; [wishlist] split `diff-refine-change' in several faces

Previous Next

Package: emacs;

Reported by: Dani Moncayo <dmoncayo <at> gmail.com>

Date: Thu, 1 Dec 2011 15:57:01 UTC

Severity: wishlist

Found in version 24.0.92

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

Full log


Message #53 received at 10181 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 10181 <at> debbugs.gnu.org
Subject: Re: bug#10181: 24.0.92;
	[wishlist] split `diff-refine-change' in several faces
Date: Fri, 25 May 2012 23:35:58 +0300
> Good point.  We should change eval-defun-1 to look inside `progn'.
> Or alternatively, we should use eval-sexp-add-defvars after the
> macroexpand+specialcaseing.

`edebug-eval-defun' uses `eval-sexp-add-defvars' after the specialcaseing,
so `eval-defun-1' could do the same:

=== modified file 'lisp/emacs-lisp/lisp-mode.el'
--- lisp/emacs-lisp/lisp-mode.el	2012-05-24 23:24:47 +0000
+++ lisp/emacs-lisp/lisp-mode.el	2012-05-25 20:28:17 +0000
@@ -830,10 +830,10 @@ (defun eval-defun-2 ()
 	   (end-of-defun)
 	   (beginning-of-defun)
 	   (setq beg (point))
-	   (setq form (eval-sexp-add-defvars (read (current-buffer))))
+	   (setq form (read (current-buffer)))
 	   (setq end (point)))
 	 ;; Alter the form if necessary.
-	 (setq form (eval-defun-1 (macroexpand form)))
+	 (setq form (eval-sexp-add-defvars (eval-defun-1 (macroexpand form))))
 	 (list beg end standard-output
 	       `(lambda (ignore)
 		 ;; Skipping to the end of the specified region





This bug report was last modified 10 years and 341 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.