GNU bug report logs - #10168
"Complete, but not unique" wrong

Previous Next

Package: emacs;

Reported by: jidanni <at> jidanni.org

Date: Wed, 30 Nov 2011 12:11:02 UTC

Severity: normal

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10168 in the body.
You can then email your comments to 10168 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#10168; Package emacs. (Wed, 30 Nov 2011 12:11:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to jidanni <at> jidanni.org:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 30 Nov 2011 12:11:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: bug-gnu-emacs <at> gnu.org
Subject: "Complete, but not unique" wrong
Date: Wed, 30 Nov 2011 19:18:33 +0800

ESC x m a n RET d l o TAB
gives
Manual entry: dlo [Complete, but not unique]

Possible completions are:
dlocate(1)
dlopen(3)

So we see "[Complete, but not unique]" is wrong here, as it is not complete.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10168; Package emacs. (Thu, 01 Dec 2011 19:38:01 GMT) Full text and rfc822 format available.

Message #8 received at 10168 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: jidanni <at> jidanni.org
Cc: 10168 <at> debbugs.gnu.org
Subject: Re: bug#10168: "Complete, but not unique" wrong
Date: Thu, 01 Dec 2011 14:37:29 -0500

> ESC x m a n RET d l o TAB
> gives
> Manual entry: dlo [Complete, but not unique]

> Possible completions are:
> dlocate(1)
> dlopen(3)

> So we see "[Complete, but not unique]" is wrong here, as it is not complete.

Indeed.  I've installed the patch below which should fix those problems.


        Stefan


--- lisp/man.el	2011-11-27 04:43:11 +0000
+++ lisp/man.el	2011-12-01 19:33:36 +0000
@@ -754,8 +754,10 @@
 
 (defun Man-completion-table (string pred action)
   (cond
-   ((eq action 'lambda)
-    (not (string-match "([^)]*\\'" string)))
+   ;; This ends up returning t for pretty much any string, and hence leads to
+   ;; spurious "complete but not unique" messages.  And since `man' doesn't
+   ;; require-match anyway, there's not point being clever.
+   ;;((eq action 'lambda) (not (string-match "([^)]*\\'" string)))
    ((equal string "-k")
     ;; Let SPC (minibuffer-complete-word) insert the space.
     (complete-with-action action '("-k ") string pred))
Reply sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
You have taken responsibility. (Thu, 01 Dec 2011 22:18:01 GMT) Full text and rfc822 format available.
Notification sent to jidanni <at> jidanni.org:
bug acknowledged by developer. (Thu, 01 Dec 2011 22:18:02 GMT) Full text and rfc822 format available.

Message #13 received at 10168-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 10168-done <at> debbugs.gnu.org
Subject: Re: bug#10168: "Complete, but not unique" wrong
Date: Thu, 01 Dec 2011 17:16:55 -0500

Should be fixed now,


        Stefan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 30 Dec 2011 12:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 13 years and 175 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.