GNU bug report logs - #10162
24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set

Previous Next

Full log

Message #27 received at 10162 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Steve Scott <steve <at> stevescott.ca>
Cc: 10162 <at> debbugs.gnu.org
Subject: Re: bug#10162: [PATCH] 24.0.91;
 rcirc autojoin broken (freenode/oftc) when
 rcirc-authenticate-before-join is set
Date: Mon, 03 Jun 2019 18:16:01 -0400

Steve Scott <steve <at> stevescott.ca> writes:

> Since the hostname returned by irc.freenode.net can be something other
> than irc.freenode.net, e.g. niven.freenode.net, the entries for
> rcirc-authinfo and rcirc-server-alist will not match.

Thanks, I was hitting this, and based on your explanation, I changed my
rcirc-authinfo entry to "[.]freenode[.]net\\'" instead of
"irc.freenode.net" and autojoin started working.

> +    (if (and rcirc-auto-authenticate-flag
> +	     ;; We have to ensure that there's an authentication
> +	     ;; entry for that server.  Otherwise,
> +             ;; there's no point in calling authenticate.
> +	     (let (auth-required)
> +	       (dolist (s rcirc-authinfo auth-required)
> +		 (when (string-match (car s) rcirc-server)
> +		   (setq auth-required t)))))
> +        (if rcirc-authenticate-before-join

But it looks like we're still calling authenticate, even in the
"otherwise" case, even though you say there's no point?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.