From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 19:50:37 2011 Received: (at submit) by debbugs.gnu.org; 30 Nov 2011 00:50:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVYNg-0006Hq-Mp for submit@debbugs.gnu.org; Tue, 29 Nov 2011 19:50:37 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVYNe-0006Hj-0Z for submit@debbugs.gnu.org; Tue, 29 Nov 2011 19:50:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVYNb-00044z-63 for submit@debbugs.gnu.org; Tue, 29 Nov 2011 19:50:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:46334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVYNb-00044v-4V for submit@debbugs.gnu.org; Tue, 29 Nov 2011 19:50:31 -0500 Received: from eggs.gnu.org ([140.186.70.92]:40217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVYNZ-0004N6-Or for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 19:50:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVYNY-00042b-5L for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 19:50:29 -0500 Received: from mail-yx0-f169.google.com ([209.85.213.169]:62261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVYNX-00042W-Uq for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 19:50:28 -0500 Received: by yenl12 with SMTP id l12so3305311yen.0 for ; Tue, 29 Nov 2011 16:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; bh=IZ3l5qcFXHWg8m+wVJ1QELqylvr8017EiiyYxGljb1s=; b=sL59QAuUC/8+v5Z0sNH4HgpqtHL+WXk6DcXOZW0g2BThR7wVUH4npjZLEpB9yVeqCT Vp8z+UFkYxDb6eDhNbG/aLQ7e4vvP0iqP8joG2mJ2d/nQXZjlUdoU1LGMSDpqIlMkSS9 cAGZTZTQkzls4uQVqnj8wJKvzuDYo0Da9J74Y= Received: by 10.101.11.40 with SMTP id o40mr11454432ani.42.1322614227200; Tue, 29 Nov 2011 16:50:27 -0800 (PST) Received: from localhost (office.cyber.com.au. [203.7.155.20]) by mx.google.com with ESMTPS id f17sm538513ang.20.2011.11.29.16.50.25 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 29 Nov 2011 16:50:26 -0800 (PST) From: trentbuck@gmail.com (Trent W. Buck) To: bug-gnu-emacs@gnu.org Subject: 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set Date: Wed, 30 Nov 2011 11:50:08 +1100 Message-ID: <87ipm2o2m7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) When doing emacs -f irc or M-x irc, Emacs would connect to all three servers, but not autojoin channels in Freenode with this setting: (setq rcirc-server-alist `(("irc.freenode.net" :channels ("##workingset" "#collectd" "#emacs" "#lxcontainers" "#netfilter" "#paredit" "#screen" "#ubuntu-hardened" "#ubuntu-server")) ("irc.oftc.net" :channels ("#debian-au" "#debian-derivatives" "#debian-eeepc" "#debian-haskell" "#debian-mentors" "#debian-next")) ("irc.cyber.com.au" :channels ("#cyber")))) I tried moving freenode to be the last of the three; the result was that only #cyber was joined. As a random guess, I tried (setq rcirc-authenticate-before-join nil) -- this fixed the problem. I speculate there is an issue with this new feature when >1 server is in the server alist. I could reproduce this behaviour reliably with a dozen or so attempts under emacs-snapshot; I never had this behaviour under 23 (which predates authenticate-before-join). I also had this problem several months ago with the emacs-snapshot that was current then; I didn't bother to investigate at the time -- it was easier to just switch back to 23. irc.cyber.com.au is an internal (private) office IRC server; running ircd-irc2 2.11.2p1+dfsg-2 on Ubuntu 10.04 (Lucid). A complete (but slightly older) copy of my emacs configuration can be found at http://cyber.com.au/~twb/.emacs and http://cyber.com.au/~twb/.rcirc.el. In GNU Emacs 24.0.91.1 (x86_64-pc-linux-gnu) of 2011-11-04 on zelenka, modified by Debian (emacs-snapshot package, version 1:20111104-1) configured using `configure '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/24.0.91/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.0.91/site-lisp:/usr/share/emacs/site-lisp' '--without-compress-info' '--with-crt-dir=/usr/lib/x86_64-linux-gnu/' '--with-x=no' '--without-dbus' '--without-sound' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: C value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_AU.utf8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: xterm-mouse-mode: t ido-everywhere: t savehist-mode: t icomplete-mode: t show-paren-mode: t delete-selection-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: ESC x r e p o r t SPC e m a c s SPC b u f DEL g RE T Recent messages: Loading /etc/emacs/site-start.d/50emacs-goodies-el.el (source)...done Loading /etc/emacs/site-start.d/50ledger.el (source)...done Loading /etc/emacs/site-start.d/50magit.el (source)...done Loading /etc/emacs/site-start.d/50paredit-el.el (source)...done Loading /etc/emacs/site-start.d/50psvn.el (source)...done Loading /etc/emacs/site-start.d/50puppet-el.el (source)...done Loading /etc/emacs/site-start.d/50w3m-el-snapshot.el (source)...done Loading /etc/emacs/site-start.d/51debian-el.el (source)...done Loading term/xterm...done For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: /home/twb/.emacs.d/lisp/magit/magit-svn hides /usr/share/emacs/24.0.91/site-lisp/magit/magit-svn /home/twb/.emacs.d/lisp/magit/magit-key-mode hides /usr/share/emacs/24.0.91/site-lisp/magit/magit-key-mode /home/twb/.emacs.d/lisp/magit/magit hides /usr/share/emacs/24.0.91/site-lisp/magit/magit /home/twb/.emacs.d/lisp/magit/magit-topgit hides /usr/share/emacs/24.0.91/site-lisp/magit/magit-topgit /usr/share/emacs/24.0.91/site-lisp/puppet-el/puppet-mode hides /usr/share/emacs/site-lisp/puppet-mode /usr/share/emacs/24.0.91/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup /home/twb/.emacs.d/lisp/gnus/.dir-locals hides /usr/share/emacs/24.0.91/lisp/gnus/.dir-locals Features: (shadow sort gnus-util mail-extr message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug jka-compr edmacro kmacro xt-mouse ido savehist icomplete time-date paren delsel saveplace debian-el debian-el-loaddefs w3m-load emacs-goodies-el emacs-goodies-custom emacs-goodies-loaddefs easy-mmode dpkg-dev-el dpkg-dev-el-loaddefs ediff-hook vc-hooks lisp-float-type lisp-mode register page menu-bar rfn-eshadow timer select mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 29 07:26:38 2012 Received: (at 10162) by debbugs.gnu.org; 29 Oct 2012 11:26:38 +0000 Received: from localhost ([127.0.0.1]:37536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSnUL-0007Q1-Jy for submit@debbugs.gnu.org; Mon, 29 Oct 2012 07:26:38 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:63900) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSnUI-0007Pt-6u for 10162@debbugs.gnu.org; Mon, 29 Oct 2012 07:26:36 -0400 Received: by mail-pb0-f44.google.com with SMTP id ro8so4056009pbb.3 for <10162@debbugs.gnu.org>; Mon, 29 Oct 2012 04:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=8/TedWUqpEFqd9K2t+D6KSXuyTQTpNBFQw41pKE+KBU=; b=I9hZhP1PziFt1xzV0zEJHFsJlaLhrrJV3ZRlECHwVhdfIreWMwfprG4Za1LTiIjctF qmDbo4OLnxGbeWkvO/AF7TF5A62tyyZQBS9XN8ZSvmfrmRiSiSLIgI+JHIzRf7m3QDJE 4QNa9wAr1hWmUwCGab2r68pg7nrhJSozcDmJyHH+cWFzL4hGrhXpduYHNOLAu1SRxUDQ Da56/NpQ/hoNk7jiQu13Sf6A2/hkJ9R4QypCPKYXd9dHuQX/+rQqi0a4wsGJ4hSP8qGF m5Ati7GViSgicHaJMvvvIJ5C4V5YeuSqf+7Dq72X4YavfL1WQMojkJFv19NXFanSlQcl 7jng== Received: by 10.66.73.161 with SMTP id m1mr83025910pav.9.1351509846693; Mon, 29 Oct 2012 04:24:06 -0700 (PDT) Received: from ulysses ([155.69.16.22]) by mx.google.com with ESMTPS id qi2sm4579512pbc.22.2012.10.29.04.24.02 (version=SSLv3 cipher=OTHER); Mon, 29 Oct 2012 04:24:05 -0700 (PDT) From: Chong Yidong To: Ryan Yeske , Deniz Dogan Subject: Re: bug#10162: 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set References: <87ipm2o2m7.fsf@gmail.com> Date: Mon, 29 Oct 2012 19:23:59 +0800 In-Reply-To: <87ipm2o2m7.fsf@gmail.com> (Trent W. Buck's message of "Wed, 30 Nov 2011 11:50:08 +1100") Message-ID: <87sj8x34j4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 10162 Cc: "Trent W. Buck" , 10162@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) Hi Ryan, Deniz, Could either of you please take a look at this bug? This appears to be a regression, so it would be good to fix it for Emacs 24.3. Thanks. trentbuck@gmail.com (Trent W. Buck) writes: > When doing emacs -f irc or M-x irc, Emacs would connect to all three > servers, but not autojoin channels in Freenode with this setting: > > (setq rcirc-server-alist > `(("irc.freenode.net" :channels ("##workingset" > "#collectd" > "#emacs" > "#lxcontainers" > "#netfilter" > "#paredit" > "#screen" > "#ubuntu-hardened" > "#ubuntu-server")) > ("irc.oftc.net" :channels ("#debian-au" > "#debian-derivatives" > "#debian-eeepc" > "#debian-haskell" > "#debian-mentors" > "#debian-next")) > ("irc.cyber.com.au" :channels ("#cyber")))) > > I tried moving freenode to be the last of the three; the result was that > only #cyber was joined. > > As a random guess, I tried (setq rcirc-authenticate-before-join nil) -- > this fixed the problem. > > I speculate there is an issue with this new feature when >1 server is in > the server alist. I could reproduce this behaviour reliably with a > dozen or so attempts under emacs-snapshot; I never had this behaviour > under 23 (which predates authenticate-before-join). > > I also had this problem several months ago with the emacs-snapshot that > was current then; I didn't bother to investigate at the time -- it was > easier to just switch back to 23. > > irc.cyber.com.au is an internal (private) office IRC server; running > ircd-irc2 2.11.2p1+dfsg-2 on Ubuntu 10.04 (Lucid). > > A complete (but slightly older) copy of my emacs configuration can be > found at http://cyber.com.au/~twb/.emacs and > http://cyber.com.au/~twb/.rcirc.el. > > In GNU Emacs 24.0.91.1 (x86_64-pc-linux-gnu) > of 2011-11-04 on zelenka, modified by Debian > (emacs-snapshot package, version 1:20111104-1) From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 18:33:57 2012 Received: (at 10162) by debbugs.gnu.org; 4 Dec 2012 23:33:57 +0000 Received: from localhost ([127.0.0.1]:53809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg1zx-00083L-6V for submit@debbugs.gnu.org; Tue, 04 Dec 2012 18:33:57 -0500 Received: from giraff.friprogramvarusyndikatet.se ([94.246.92.54]:60929 helo=smtp.fripost.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg1zu-00083B-Ie for 10162@debbugs.gnu.org; Tue, 04 Dec 2012 18:33:55 -0500 Received: from [192.168.1.2] (h-169-224.a336.priv.bahnhof.se [176.10.169.224]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: damd@fripost.org) by smtp.fripost.org (Postfix) with ESMTPSA id 55327633C3; Wed, 5 Dec 2012 00:33:08 +0100 (CET) Message-ID: <50BE8823.2090706@dogan.se> Date: Wed, 05 Dec 2012 00:32:51 +0100 From: Deniz Dogan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: 10162@debbugs.gnu.org, trentbuck@gmail.com Subject: Re: 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 10162 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.8 (/) Hi, I'm actually unable to reproduce this problem using the latest version from Bazaar. Could you provide a minimal recipe to reproduce this? Cheers, Deniz From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 19:33:30 2012 Received: (at 10162) by debbugs.gnu.org; 5 Dec 2012 00:33:30 +0000 Received: from localhost ([127.0.0.1]:53847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg2va-0000y3-AE for submit@debbugs.gnu.org; Tue, 04 Dec 2012 19:33:30 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:41800) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tg2vY-0000xv-6Y for 10162@debbugs.gnu.org; Tue, 04 Dec 2012 19:33:29 -0500 Received: by mail-pa0-f44.google.com with SMTP id hz11so2961254pad.3 for <10162@debbugs.gnu.org>; Tue, 04 Dec 2012 16:33:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=MPtsAXdewH9pyoO9mQ2UE+dEZHW/E0NmC0xKAlWgPis=; b=Skhk2j7U3zM9dv6NkZ+ef9SEoEYSeBfMlhksx9xTQCdQL8KJdF1OQ1e2xPY4EI7Z8b GuI0tTuWxeFtQ/DiTR7LhRPGF/IsvQCueSUTZXBRviXxQnM74xPoIO9/rdc6/MVO2n1X N/xgCg7MRF/m/THUUeeD3TqKf4BD7/EZYWA5bVWiq7rWNrob7DT/yTevO4aBDJmNNVFH H0Jg9gkiKNIcL11QarU8bEZ+/QwSwDCFmCpJE55MLuIA3M+pq8TsnbXZ7tTVHrfIJgIM yqChUVYo5hRj3EiHo5iBmn9TzPZuorXk69hHDYB+61eCh+90O5O3X0f19dbG8fde4ajL IZJw== Received: by 10.68.242.40 with SMTP id wn8mr44132067pbc.16.1354667602979; Tue, 04 Dec 2012 16:33:22 -0800 (PST) Received: from elba ([203.7.155.74]) by mx.google.com with ESMTPS id ju7sm1800833pbb.60.2012.12.04.16.33.19 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 04 Dec 2012 16:33:22 -0800 (PST) Date: Wed, 5 Dec 2012 11:33:13 +1100 From: "Trent W. Buck" To: Deniz Dogan Subject: Re: 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set Message-ID: <20121205003310.GA13026@elba> References: <50BE8823.2090706@dogan.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50BE8823.2090706@dogan.se> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 10162 Cc: 10162@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) Deniz Dogan wrote: > I'm actually unable to reproduce this problem using the latest > version from Bazaar. Could you provide a minimal recipe to > reproduce this? I discussed this with damd (Deniz) on IRC and he can now reproduce the symptoms. I leave it to him to finish debugging the issue :-) From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 17 20:16:27 2013 Received: (at control) by debbugs.gnu.org; 18 Mar 2013 00:16:27 +0000 Received: from localhost ([127.0.0.1]:60473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHNkW-0008SS-Lc for submit@debbugs.gnu.org; Sun, 17 Mar 2013 20:16:25 -0400 Received: from mail-pb0-f54.google.com ([209.85.160.54]:56037) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHNkT-0008SB-TV for control@debbugs.gnu.org; Sun, 17 Mar 2013 20:16:23 -0400 Received: by mail-pb0-f54.google.com with SMTP id rr4so5909063pbb.13 for ; Sun, 17 Mar 2013 17:14:45 -0700 (PDT) X-Received: by 10.68.29.98 with SMTP id j2mr30350802pbh.216.1363565685269; Sun, 17 Mar 2013 17:14:45 -0700 (PDT) Received: from localhost ([203.7.155.68]) by mx.google.com with ESMTPS id 1sm18041236pba.32.2013.03.17.17.14.42 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 17 Mar 2013 17:14:44 -0700 (PDT) From: Trent W. Buck To: control@debbugs.gnu.org Subject: found 10162 in 24.3.1 Date: Mon, 18 Mar 2013 11:14:36 +1100 User-Agent: devscripts bts/2.11.1ubuntu3.1 Message-ID: <1363565676-213-bts-trentbuck@gmail.com> X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) found 10162 24.3.1 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 19:57:32 2017 Received: (at control) by debbugs.gnu.org; 17 Feb 2017 00:57:32 +0000 Received: from localhost ([127.0.0.1]:42835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceWrc-0002Fp-CH for submit@debbugs.gnu.org; Thu, 16 Feb 2017 19:57:32 -0500 Received: from mail-pg0-f50.google.com ([74.125.83.50]:33325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceWra-0002Fb-Dr for control@debbugs.gnu.org; Thu, 16 Feb 2017 19:57:30 -0500 Received: by mail-pg0-f50.google.com with SMTP id y6so6860155pgy.0 for ; Thu, 16 Feb 2017 16:57:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:user-agent:message-id; bh=ELD7QCpJUo/GiacpBodbITuq3kZZcd6607yfMj1XWjY=; b=p3VikTGKIlGIYs052Zu6Cpu+lmOF3q5r8CJ7jMNe0PVaeqUV5DV913aELxJPimKasB o2Xd9s/pfjv2cDpOpicP5FhNeJgmzUM45sONy+QZ1ScvLdjBvWbteKEAXXgRoiWnF7AU jYs4zTr4tlZiaZA9onQqhmTwBEhl0PLv95/B7LnQEUYtvOK9ElWLx/bTUJTFZDy1wc37 EQ5cv7nIzGZiqiAVNCGm8U/ESehA2uNFQsY1kj4jUByYwBL8ZJjFwGJc9+iCKUrzWiVk HW+0+/pqMGavGULbwRlXTFm6n/sHsqsysf6YCE9XjeTfpuLDpH+q262wH2e1Bc3J9dlK hhsw== X-Gm-Message-State: AMke39le8hkXpQ29wjktHEJtlAJ5JKjVu7HCaHBfofxW8W2KTChVOajcaWJhbUER4dBqMQ== X-Received: by 10.84.241.138 with SMTP id b10mr7395036pll.32.1487293044129; Thu, 16 Feb 2017 16:57:24 -0800 (PST) Received: from localhost ([203.7.155.122]) by smtp.gmail.com with ESMTPSA id o66sm15616704pfa.119.2017.02.16.16.57.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 16:57:23 -0800 (PST) From: Trent W. Buck To: control@debbugs.gnu.org Subject: found 10162 in 24.5.1 Date: Fri, 17 Feb 2017 11:57:20 +1100 User-Agent: devscripts bts/2.15.3+deb8u1 Message-ID: <1487293040-4064-bts-trentbuck@gmail.com> X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) # The #emacs IRC channel recently got +r mode (registered accounts only) to mitigate persistent Judenhass trolling, which means that M-x irc opens an #emacs buffer, but it just says something like "only registered users can join #emacs". If I then type /join #emacs, I get in, because by then *irc.freenode.net* has "-NickServ- You are now identified for trentbuck.". I tried setting rcirc-authenticate-before-join back to t to fix that, and the symptoms of this bug (#10162) reappeared. I am using emacs24-nox=24.5+1-6~bpo8+1 package from Debian 8 Jessie. According to the bug history, damd can reproduce the issue --- any luck fixing it? found 10162 24.5.1 thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 20:18:34 2017 Received: (at 10162) by debbugs.gnu.org; 17 Feb 2017 01:18:34 +0000 Received: from localhost ([127.0.0.1]:42846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceXBy-0004T6-BF for submit@debbugs.gnu.org; Thu, 16 Feb 2017 20:18:34 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ceXBv-0004Ss-US for 10162@debbugs.gnu.org; Thu, 16 Feb 2017 20:18:32 -0500 Received: by mail-pg0-f65.google.com with SMTP id a123so584136pgc.3 for <10162@debbugs.gnu.org>; Thu, 16 Feb 2017 17:18:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=hPqzc2g6PjkisH3LZcjjiKicPeemLbhFQ/2FkG3rZK8=; b=MxvFaNnoYhXZb7sKmrwRKJjmqNbqnt4JReOWkIBd3G4rDgdPfc5yImWl+kvA3dQukL ACZ2eV/6TqqmEfulORa6Igcc+HsE6lSP+F/UGi2hk7xhL6prMEIOkDCTSi+GQOf4KdnM 9+9HBCr74zrz4y85z9LdZeZVlwcNixKhGoI8vWcjiPHmb0hlqfJYcdHCm5bjGGP7eLJC eH+FCH01cfuHqwfLP3sPJIWbTQuXIgw4Cmee5yTn09LeUPEuPiVvvq21aw8lGRpuOC6I RCYlOvNLaTHYd3IRZmUZUzYi2PYx2bxX2dC6nAGzakj7RVC/tgiGEqXi/GqTujnCYdMF EKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=hPqzc2g6PjkisH3LZcjjiKicPeemLbhFQ/2FkG3rZK8=; b=gQldynFHy2wm7vYA+KZjtwVMlMgJJZsvO3G3KXlgg4LG1jK0XtWUCZXpHZrL2ymxDJ J8B371mqkZCEsvSnKcysrTP90Z4n8TkB2TtpC6+8gSfW62gFb7+h8+lk/C3HJetsRV9X y2HRYdeANOT25iG+zL9X6DGfbl1Ya4Zt8maLetZIteaCMKPsDD6iwW1K8c6haKPCDi1y 26uQR4Vj0qwt9eU+Gb0Ozs3yBI72NUL85x5WAHkRs53oho3XIJW1E09417OtcYNtIbaI apTEnMtHEKxq9nEs96PEXTV+8+1rmofeKZHh6+0et18dovbpCkyoloJRCn8IHrH5qdvO UMkA== X-Gm-Message-State: AMke39kyFvaVAPrHj3jH1gcyAwPBPhk+rrgbljqmGsONysW7bt+vCFhoFBdK9qfAae3A6Q== X-Received: by 10.84.196.36 with SMTP id k33mr7462643pld.125.1487294306312; Thu, 16 Feb 2017 17:18:26 -0800 (PST) Received: from localhost ([203.7.155.122]) by smtp.gmail.com with ESMTPSA id k76sm15720946pfg.42.2017.02.16.17.18.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 17:18:25 -0800 (PST) Date: Fri, 17 Feb 2017 12:18:22 +1100 From: "Trent W. Buck" To: deniz@dogan.se Subject: bug#10162: 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set Message-ID: <20170217011820.GA2371@frey> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 10162 Cc: cyd@gnu.org, rcyeske@gmail.com, 10162@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) This bug still affected 24.3 in 2013, and 24.5 today. Due to me misunderstanding how GNU's debbugs instance is configured, I don't think anyone was CC'd when I told debbug, so here's today's comment again: The #emacs IRC channel recently got +r mode (registered accounts only) to mitigate persistent Judenhass trolling, which means that M-x irc opens an #emacs buffer, but it just says something like "only registered users can join #emacs". If I then type /join #emacs, I get in, because by then *irc.freenode.net* has "-NickServ- You are now identified for trentbuck.". I tried setting rcirc-authenticate-before-join back to t to fix that, and the symptoms of this bug (#10162) reappeared. I am using emacs24-nox=24.5+1-6~bpo8+1 package from Debian 8 Jessie. According to the bug history, damd can reproduce the issue --- any luck fixing it? PS: I don't have a record of the recipe I gave damd to reproduce the bug :-( From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 02 22:11:44 2019 Received: (at submit) by debbugs.gnu.org; 3 Jun 2019 02:11:44 +0000 Received: from localhost ([127.0.0.1]:41270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXcRr-0008Lq-OV for submit@debbugs.gnu.org; Sun, 02 Jun 2019 22:11:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXbmO-0007GW-C5 for submit@debbugs.gnu.org; Sun, 02 Jun 2019 21:28:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:43916) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hXbmH-00053h-P3 for submit@debbugs.gnu.org; Sun, 02 Jun 2019 21:28:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXbmG-0002l1-G1 for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2019 21:28:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_50,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXbaO-0003X3-UL for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2019 21:16:33 -0400 Received: from 23.ip-144-217-85.net ([144.217.85.23]:43208 helo=mailserv.stevescott.ca) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hXbaO-0003WX-Q1 for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2019 21:16:28 -0400 Received: from localhost (mailserv.stevescott.ca [127.0.0.1]) by mailserv.stevescott.ca (Postfix) with ESMTP id 8EC253EA4B for ; Sun, 2 Jun 2019 21:55:36 -0300 (ADT) X-Virus-Scanned: Debian amavisd-new at mailserv.stevescott.ca Received: from mailserv.stevescott.ca ([127.0.0.1]) by localhost (mailserv.stevescott.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hWidqxchhZ5s for ; Sun, 2 Jun 2019 21:55:35 -0300 (ADT) From: Steve Scott DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=stevescott.ca; s=dkim; t=1559523335; bh=rc1CliMEarIcXxN7dcRCLYocBJObRm8eIq4Z/8cJGV8=; h=From:To:Subject:Date:From; b=EuZKeEG3HNFsrJfY5gTUYeL2e/8C8MIan29LDnSEcxmT57kXZpIIALBHeq0vSVZbG oJKf/p0BjfG8gt2HtYqkNAj84ilRgsbvX+5Jf8FCDdKz9bJaVpFn8hk2OdiMTNQG5y lMAzzkNlveCc6/knos66O8RcIhvAH7jnZNO5kzxA= To: bug-gnu-emacs@gnu.org Subject: bug#10162: [PATCH] 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set Date: Sun, 02 Jun 2019 21:55:34 -0300 Message-ID: <875zpn5vy1.fsf@stevescott.ca> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 144.217.85.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 02 Jun 2019 22:11:41 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Since the hostname returned by irc.freenode.net can be something other than irc.freenode.net, e.g. niven.freenode.net, the entries for rcirc-authinfo and rcirc-server-alist will not match. Hence checking rcirc-server-name (the hostname returned) instead of rcirc-server (the hostname connected to) will cause the auth-required condition to fail because of the mismatch. The hostname in rcirc-authinfo won't be found and the authentication hook will be skipped. The authenticate and join functions still get called in the ELSE in this case but there is no waiting for the authentication to be successful before joining the channels. Moreover, if rcirc-auto-authenticate-flag is set, there should indeed be a check for the corresponding rcirc-authinfo, regardless of whether the rcirc-authenticate-before-join must happen. Otherwise, there's no point in calling authenticate. My proposed patch enclosed. Thanks, Steve Scott diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 9c3828caf5..0f1904ea0e 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -2545,16 +2545,15 @@ rcirc-handler-001 (setq rcirc-server-name sender) (setq rcirc-nick (car args)) (rcirc-update-prompt) - (if rcirc-auto-authenticate-flag - (if (and rcirc-authenticate-before-join - ;; We have to ensure that there's an authentication - ;; entry for that server. Else, - ;; rcirc-authenticated-hook won't be triggered, and - ;; autojoin won't happen at all. - (let (auth-required) - (dolist (s rcirc-authinfo auth-required) - (when (string-match (car s) rcirc-server-name) - (setq auth-required t))))) + (if (and rcirc-auto-authenticate-flag + ;; We have to ensure that there's an authentication + ;; entry for that server. Otherwise, + ;; there's no point in calling authenticate. + (let (auth-required) + (dolist (s rcirc-authinfo auth-required) + (when (string-match (car s) rcirc-server) + (setq auth-required t))))) + (if rcirc-authenticate-before-join (progn (add-hook 'rcirc-authenticated-hook 'rcirc-join-channels-post-auth t t) (rcirc-authenticate)) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 18:16:13 2019 Received: (at 10162) by debbugs.gnu.org; 3 Jun 2019 22:16:13 +0000 Received: from localhost ([127.0.0.1]:43345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXvFV-0004Z5-D1 for submit@debbugs.gnu.org; Mon, 03 Jun 2019 18:16:13 -0400 Received: from mail-io1-f47.google.com ([209.85.166.47]:33256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXvFR-0004Yp-8B for 10162@debbugs.gnu.org; Mon, 03 Jun 2019 18:16:10 -0400 Received: by mail-io1-f47.google.com with SMTP id u13so15724288iop.0 for <10162@debbugs.gnu.org>; Mon, 03 Jun 2019 15:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=pNffeyFdwhH4UNpTca7WAp2x3lIJLJrTQ1IVie6jGfE=; b=emI9dxH08GFfMnb3/Us50eWrqp/p1/QKgkrLgW2U+8YmpXsaT4h6UvpgbMk2fztoX+ FWeV8XdOeaGbu5NivhknAWSzU5/XEGAVR+DwLI/iNbc9MisD0hbAza80w5VIdeix8OpK U44uvNDN1NZGWqWSgj8w6ITb5wiQJlLsCMO0LHS1SwRcAyCqOqJFuXZcmFQUJBcLhXuS D+CgG91P2G7UrMEH2q1KvkNDX+gXWHP3OBq0Jk9owcjb5ythoU3UNqUbOl8wmvzXcqNK TKLprkq9yofyf4K5G6VgygHvTIJapp6CaEf5kVEWMqm0LeTfOvX+kHMdsJEByamFkQ4V ALBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=pNffeyFdwhH4UNpTca7WAp2x3lIJLJrTQ1IVie6jGfE=; b=MRgPQySmxqBdTjsyUKdPG0BBZoCuc3AD64rXEv751menKk+/nIVz5q2U47w229H19o Gss23pBS71MdzM5IlvzB9atYpqRqpWz71lC8p2d0BfRbHu3NJ/bi3ekXDHtF+x/p7zzU ahzvL4FqKJGQ64UyWN0McQsfbToWJVEXHeVNT4DjJS1VpERblAyCgbom9d5tsOG8cGoN efFflDETCioQZE61wGUD7MjXMlhEY6duv39EC8VJCpecAwSKD2ldP7TbXuMRcXFiOmA0 dLin4CGH3SJvVQjM0Jc1YVO5eDhZTnCk5u5GnCZfH17syd4/JO3l0VmtDfWNCMAPeDcC wzbw== X-Gm-Message-State: APjAAAUlfIWx92MY+653KBtMghvVKSuahdz4jfR0yCmYayntBAD01cBx lOk/UK8NJTHfUxBTchasX+0scYhd X-Google-Smtp-Source: APXvYqy7br1AwTFj0PtHhT9uSW9Pq4f3LxHJTWSnXOdaOXMQuUqOn9MJFT43C9TCt1bbknB43QGZjw== X-Received: by 2002:a5d:8ccc:: with SMTP id k12mr324189iot.141.1559600163278; Mon, 03 Jun 2019 15:16:03 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id m68sm7043494itm.1.2019.06.03.15.16.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jun 2019 15:16:02 -0700 (PDT) From: Noam Postavsky To: Steve Scott Subject: Re: bug#10162: [PATCH] 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set References: <87ipm2o2m7.fsf@gmail.com> <875zpn5vy1.fsf@stevescott.ca> Date: Mon, 03 Jun 2019 18:16:01 -0400 In-Reply-To: <875zpn5vy1.fsf@stevescott.ca> (Steve Scott's message of "Sun, 02 Jun 2019 21:55:34 -0300") Message-ID: <87y32i48ny.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10162 Cc: 10162@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Steve Scott writes: > Since the hostname returned by irc.freenode.net can be something other > than irc.freenode.net, e.g. niven.freenode.net, the entries for > rcirc-authinfo and rcirc-server-alist will not match. Thanks, I was hitting this, and based on your explanation, I changed my rcirc-authinfo entry to "[.]freenode[.]net\\'" instead of "irc.freenode.net" and autojoin started working. > + (if (and rcirc-auto-authenticate-flag > + ;; We have to ensure that there's an authentication > + ;; entry for that server. Otherwise, > + ;; there's no point in calling authenticate. > + (let (auth-required) > + (dolist (s rcirc-authinfo auth-required) > + (when (string-match (car s) rcirc-server) > + (setq auth-required t))))) > + (if rcirc-authenticate-before-join But it looks like we're still calling authenticate, even in the "otherwise" case, even though you say there's no point? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 03 18:56:26 2019 Received: (at 10162) by debbugs.gnu.org; 3 Jun 2019 22:56:26 +0000 Received: from localhost ([127.0.0.1]:43369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXvsP-0005SC-Pb for submit@debbugs.gnu.org; Mon, 03 Jun 2019 18:56:26 -0400 Received: from 23.ip-144-217-85.net ([144.217.85.23]:55694 helo=mailserv.stevescott.ca) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXvqS-0005P2-2p for 10162@debbugs.gnu.org; Mon, 03 Jun 2019 18:54:24 -0400 Received: from localhost (mailserv.stevescott.ca [127.0.0.1]) by mailserv.stevescott.ca (Postfix) with ESMTP id 704C13EA4B; Mon, 3 Jun 2019 19:54:18 -0300 (ADT) X-Virus-Scanned: Debian amavisd-new at mailserv.stevescott.ca Received: from mailserv.stevescott.ca ([127.0.0.1]) by localhost (mailserv.stevescott.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UUvC0Oc4-yOD; Mon, 3 Jun 2019 19:54:17 -0300 (ADT) References: <87ipm2o2m7.fsf@gmail.com> <875zpn5vy1.fsf@stevescott.ca> <87y32i48ny.fsf@gmail.com> DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=stevescott.ca; s=dkim; t=1559602457; bh=XOfz1Tc/Xki9wWsjs/sDt66Ig7I9VO46XGYGNHC0PgQ=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=UrWFr5mB5bvfqK7LfziASKjF/4E7Q73nTJAT3cy2MDguLLKw7myQ2bB20A/B3+UnB EpdnY6jwm2TTUSx0TrBPap5GThXS28UyyqnXOQ1HGvqBJQL7PRx4rkpdj5zNZE7oHI peYkAeeO0urmIGK3ntFzD7eGtVGYyYmPk2AGqQiI= From: Steve Scott To: Noam Postavsky Subject: Re: bug#10162: [PATCH] 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set In-reply-to: <87y32i48ny.fsf@gmail.com> Date: Mon, 03 Jun 2019 19:54:16 -0300 Message-ID: <87ef4a9t5z.fsf@stevescott.ca> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 10162 X-Mailman-Approved-At: Mon, 03 Jun 2019 18:56:24 -0400 Cc: 10162@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) There are three cases, and authenticate needs to be called for two of them: 1) auto-authenticate + authenticate-before-join Use the hook to ensure authentication completes before joining. 2) auto-authenticate but not "before join" In this case, authenticate must still be called but the hook is not required because the order is not important. 3) no auto-authenticate Just join the channels without authenticating. The "Otherwise" comment refers to the 3rd case: if auto-authenticate is set but no authinfo is specified we just join the channels. I'm not sure authenticate-before-join is even necessary. I would recommend authenticating before joining be the way it works but that's probably a separate discussion. Noam Postavsky writes: > Steve Scott writes: > >> Since the hostname returned by irc.freenode.net can be something other >> than irc.freenode.net, e.g. niven.freenode.net, the entries for >> rcirc-authinfo and rcirc-server-alist will not match. > > Thanks, I was hitting this, and based on your explanation, I changed my > rcirc-authinfo entry to "[.]freenode[.]net\\'" instead of > "irc.freenode.net" and autojoin started working. > >> + (if (and rcirc-auto-authenticate-flag >> + ;; We have to ensure that there's an authentication >> + ;; entry for that server. Otherwise, >> + ;; there's no point in calling authenticate. >> + (let (auth-required) >> + (dolist (s rcirc-authinfo auth-required) >> + (when (string-match (car s) rcirc-server) >> + (setq auth-required t))))) >> + (if rcirc-authenticate-before-join > > But it looks like we're still calling authenticate, even in the > "otherwise" case, even though you say there's no point? From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 05 20:34:44 2019 Received: (at 10162) by debbugs.gnu.org; 6 Jun 2019 00:34:44 +0000 Received: from localhost ([127.0.0.1]:48526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYgMd-0000ZT-Rk for submit@debbugs.gnu.org; Wed, 05 Jun 2019 20:34:44 -0400 Received: from mail-it1-f182.google.com ([209.85.166.182]:52188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hYgMb-0000ZA-JN; Wed, 05 Jun 2019 20:34:42 -0400 Received: by mail-it1-f182.google.com with SMTP id m3so498556itl.1; Wed, 05 Jun 2019 17:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=tLFNSv3OK6wpJCQ8OrtoVKpA34cQBygqAf1z0HTV1Wo=; b=PDcXbXj2o+f/Ye6mPLt9JveaRev/CNDXgfEq8LQVvTY1wZg7fK5/QWxGBCED/pxpe5 SzfzDpsGB/TNQ1LP0f1SsafOSTZsVWcf6eNfGh7XG7DQQpfP1ELh9YyVOqYLMYaFcczm nY9nO6/I6tsYyLM3VCa+JbWiyqFjRVo4mHKshZUjKaDCbDjgLPtmgnAVCWuQuIxEbSAc hM6wX/L2HW706gpyLb+mmGQ563c4ZXe0ahnjppXa9xyYUBm7tAS0bhb0MrfnCYeG5hGA Rzbrbx1u8jxEj7Hn2QZbkINdnozuEPXFtupBdsPyNLJ1vT/cEFs054TuB4+2YMixdyFq T7Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=tLFNSv3OK6wpJCQ8OrtoVKpA34cQBygqAf1z0HTV1Wo=; b=bNDoitS227MUbvgjbriBPBuoAAsV0i0oV8BAQkhNgKfQJ+YulZOY2QqKT36iCJ3U2c KVlTEy133X/UAbaFoTF8hEQI2FM/BhjvITFBhLMqAJefwxqJpm05BBr9PcxgRRfQSz4K nEkrlTfYcz2AsvxQl+N+DIqbSKYpCxgklbJuc3QDlLZepdULxb4TmboSkNl5BV2PKp2A q7Ra1vZ/L57a1KLh0C3HB4L9ZIT8S0VL8yi503FztWG/Q6zJLhPI9lj3wiMGl3weYwLH t/Azo2SVd/WuPL0b7NrIPFyuxNoAv5jhhoTo4KrnuI+J/ZXO+VbmE+5KWHJmKOwJY0qT UX4w== X-Gm-Message-State: APjAAAXgrgr2VTvbE0L6+f98np2Arnpg9Z8X5zfvK9Ogkwptbtlc3j6F dM1iICOIZnidO7dx/anSCyav0Iby X-Google-Smtp-Source: APXvYqwq7Aj15RP5X6wr2WAN0AhqmkS1rooPCNsclz4C7bUO+wYNc+wjtcqsL2E2bWW83ZQYp3ra3g== X-Received: by 2002:a02:bb05:: with SMTP id y5mr27569849jan.93.1559781273760; Wed, 05 Jun 2019 17:34:33 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id q11sm207671itk.28.2019.06.05.17.34.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 17:34:33 -0700 (PDT) From: Noam Postavsky To: Steve Scott Subject: Re: bug#10162: [PATCH] 24.0.91; rcirc autojoin broken (freenode/oftc) when rcirc-authenticate-before-join is set References: <87ipm2o2m7.fsf@gmail.com> <875zpn5vy1.fsf@stevescott.ca> <87y32i48ny.fsf@gmail.com> <87ef4a9t5z.fsf@stevescott.ca> Date: Wed, 05 Jun 2019 20:34:32 -0400 In-Reply-To: <87ef4a9t5z.fsf@stevescott.ca> (Steve Scott's message of "Mon, 03 Jun 2019 19:54:16 -0300") Message-ID: <87o93b361z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 10162 Cc: 10162@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 10162 fixed close 10162 27.1 quit Steve Scott writes: > The "Otherwise" comment refers to the 3rd case: > if auto-authenticate is set but no authinfo is specified we just join > the channels. Ah right, I was misreading the nested conditionals. Anyway, I think this all makes sense so I pushed to master. cd3221ab0f 2019-06-05T20:30:23-04:00 "Check rcirc-server for auto authentication (Bug#10162)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cd3221ab0f8dbde584a76c2648cc9029e63bd8d1 > I'm not sure authenticate-before-join is even necessary. I would > recommend authenticating before joining be the way it works but that's > probably a separate discussion. Yeah, I kind of agree, but removing options is always a tough sell. From unknown Sun Jun 22 19:07:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 04 Jul 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator