From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 15:28:50 2011 Received: (at submit) by debbugs.gnu.org; 26 Nov 2011 20:28:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RUOri-00032M-Gx for submit@debbugs.gnu.org; Sat, 26 Nov 2011 15:28:50 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RUOrf-00032D-FR for submit@debbugs.gnu.org; Sat, 26 Nov 2011 15:28:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RUOpx-00026N-SA for submit@debbugs.gnu.org; Sat, 26 Nov 2011 15:27:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:34186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUOpx-00026G-Qi for submit@debbugs.gnu.org; Sat, 26 Nov 2011 15:27:01 -0500 Received: from eggs.gnu.org ([140.186.70.92]:33906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUOpw-0007Ju-A2 for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2011 15:27:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RUOpv-00025z-Bz for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2011 15:27:00 -0500 Received: from mail-yw0-f41.google.com ([209.85.213.41]:33635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RUOpv-00025v-9f for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2011 15:26:59 -0500 Received: by ywm14 with SMTP id 14so4094888ywm.0 for ; Sat, 26 Nov 2011 12:26:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; bh=z9/lIqmkL+ixB5ROKdLs5lMxy94p/CLNBCyIvGc40cY=; b=csFw6t3p3Y5N3Lwg0z2krFG6Nm2yRaAKu+ZJ/mMg3UgNmI+ncAD+cpMJo4ekaNLjG/ 374VkT7LKMH5cgvRe8gYx/1Pk9FsXC+EibsJPWnMGE+9PbPnPmhAoYCgZ4XhWybw1lbr NaSWju7rqBvZsbMGDsKwaVQzr0O3BCaRQjSdo= MIME-Version: 1.0 Received: by 10.236.79.38 with SMTP id h26mr54301037yhe.39.1322339218251; Sat, 26 Nov 2011 12:26:58 -0800 (PST) Received: by 10.236.161.201 with HTTP; Sat, 26 Nov 2011 12:26:58 -0800 (PST) Date: Sat, 26 Nov 2011 21:26:58 +0100 Message-ID: Subject: 24.0.91; Word Isearch backward From: Dani Moncayo To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -4.9 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.9 (----) Hi, from "emacs -Q", type: `a a RET b b RET M-s w C-r a a SPC b b'. At this point, the Isearch (word-type, backward) should succeed, but I see a failing one. In GNU Emacs 24.0.91.1 (i386-mingw-nt6.1.7601) of 2011-11-25 on DANI-PC Windowing system distributor `Microsoft Corp.', version 6.1.7601 configured using `configure --with-gcc (4.6) --cflags -fno-omit-frame-pointer' -- Dani Moncayo From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 19:45:33 2011 Received: (at 10145) by debbugs.gnu.org; 29 Nov 2011 00:45:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVBpE-00045N-Iz for submit@debbugs.gnu.org; Mon, 28 Nov 2011 19:45:33 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVBpA-00045C-Qv for 10145@debbugs.gnu.org; Mon, 28 Nov 2011 19:45:30 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 2F2226E809E; Mon, 28 Nov 2011 16:43:31 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id F07A3451C66B; Mon, 28 Nov 2011 16:43:19 -0800 (PST) From: Juri Linkov To: Dani Moncayo Subject: Re: bug#10145: 24.0.91; Word Isearch backward Organization: JURTA References: Date: Tue, 29 Nov 2011 02:33:06 +0200 In-Reply-To: (Dani Moncayo's message of "Sat, 26 Nov 2011 21:26:58 +0100") Message-ID: <87k46jyd79.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10145 Cc: 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > from "emacs -Q", type: `a a RET b b RET M-s w C-r a a SPC b b'. > > At this point, the Isearch (word-type, backward) should succeed, but I > see a failing one. Thanks, this is a bug. The comment in `isearch-search-and-update' says: ;; In reverse search, adding stuff at ;; the end may cause zero or many more chars to be ;; matched, in the string following point. ;; Allow all those possibilities without moving point as ;; long as the match does not extend past search origin. and it calls `looking-at' to implement this. But it doesn't take into account word search. The following patch fixes this bug by using `wordify' now exposed to Lisp: === modified file 'lisp/isearch.el' --- lisp/isearch.el 2011-11-28 06:59:03 +0000 +++ lisp/isearch.el 2011-11-29 00:30:33 +0000 @@ -1648,8 +1643,10 @@ (defun isearch-search-and-update () (if (and (eq case-fold-search t) search-upper-case) (setq case-fold-search (isearch-no-upper-case-p isearch-string isearch-regexp))) - (looking-at (if isearch-regexp isearch-string - (regexp-quote isearch-string)))) + (looking-at (cond + (isearch-regexp isearch-string) + (isearch-word (wordify isearch-string t)) + (t (regexp-quote isearch-string))))) (error nil)) (or isearch-yank-flag (<= (match-end 0) === modified file 'src/search.c' --- src/search.c 2011-11-27 18:17:40 +0000 +++ src/search.c 2011-11-29 00:29:22 +0000 @@ -2078,13 +2078,12 @@ (at your option) any later version. XSETBUFFER (last_thing_searched, current_buffer); } -/* Given STRING, a string of words separated by word delimiters, - compute a regexp that matches those exact words separated by - arbitrary punctuation. If LAX is nonzero, the end of the string - need not match a word boundary unless it ends in whitespace. */ - -static Lisp_Object -wordify (Lisp_Object string, int lax) +DEFUN ("wordify", Fwordify, Swordify, 1, 2, 0, + doc: /* Given STRING, a string of words separated by word delimiters, +compute a regexp that matches those exact words separated by +arbitrary punctuation. If LAX is non-nil, the end of the string +need not match a word boundary unless it ends in whitespace. */) + (Lisp_Object string, Lisp_Object lax) { register unsigned char *o; register EMACS_INT i, i_byte, len, punct_count = 0, word_count = 0; @@ -2125,7 +2124,7 @@ (at your option) any later version. } adjust = - punct_count + 5 * (word_count - 1) - + ((lax && !whitespace_at_end) ? 2 : 4); + + ((!NILP (lax) && !whitespace_at_end) ? 2 : 4); if (STRING_MULTIBYTE (string)) val = make_uninit_multibyte_string (len + adjust, SBYTES (string) @@ -2162,7 +2161,7 @@ (at your option) any later version. prev_c = c; } - if (!lax || whitespace_at_end) + if (NILP (lax) || whitespace_at_end) { *o++ = '\\'; *o++ = 'b'; @@ -2220,7 +2219,7 @@ (at your option) any later version. Optional fourth argument is repeat count--search for successive occurrences. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 0), bound, noerror, count, -1, 1, 0); + return search_command (Fwordify (string, Qnil), bound, noerror, count, -1, 1, 0); } DEFUN ("word-search-forward", Fword_search_forward, Sword_search_forward, 1, 4, @@ -2234,7 +2233,7 @@ (at your option) any later version. Optional fourth argument is repeat count--search for successive occurrences. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 0), bound, noerror, count, 1, 1, 0); + return search_command (Fwordify (string, Qnil), bound, noerror, count, 1, 1, 0); } DEFUN ("word-search-backward-lax", Fword_search_backward_lax, Sword_search_backward_lax, 1, 4, @@ -2252,7 +2251,7 @@ (at your option) any later version. Optional fourth argument is repeat count--search for successive occurrences. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 1), bound, noerror, count, -1, 1, 0); + return search_command (Fwordify (string, Qt), bound, noerror, count, -1, 1, 0); } DEFUN ("word-search-forward-lax", Fword_search_forward_lax, Sword_search_forward_lax, 1, 4, @@ -2270,7 +2269,7 @@ (at your option) any later version. Optional fourth argument is repeat count--search for successive occurrences. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 1), bound, noerror, count, 1, 1, 0); + return search_command (Fwordify (string, Qt), bound, noerror, count, 1, 1, 0); } DEFUN ("re-search-backward", Fre_search_backward, Sre_search_backward, 1, 4, @@ -3229,6 +3228,7 @@ (at your option) any later version. defsubr (&Sposix_string_match); defsubr (&Ssearch_forward); defsubr (&Ssearch_backward); + defsubr (&Swordify); defsubr (&Sword_search_forward); defsubr (&Sword_search_backward); defsubr (&Sword_search_forward_lax); Actually there are more places that require the Lisp call to `wordify' like in `isearch-occur': === modified file 'lisp/isearch.el' --- lisp/isearch.el 2011-11-28 06:59:03 +0000 +++ lisp/isearch.el 2011-11-29 00:30:33 +0000 @@ -1447,12 +1447,7 @@ (defun isearch-occur (regexp &optional n (interactive (list (cond - (isearch-word (concat "\\b" (replace-regexp-in-string - "\\W+" "\\W+" - (replace-regexp-in-string - "^\\W+\\|\\W+$" "" isearch-string) - nil t) - "\\b")) + (isearch-word (wordify isearch-string)) (isearch-regexp isearch-string) (t (regexp-quote isearch-string))) (if current-prefix-arg (prefix-numeric-value current-prefix-arg)))) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 03:42:12 2011 Received: (at 10145) by debbugs.gnu.org; 29 Nov 2011 08:42:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVJGV-0006fs-Aa for submit@debbugs.gnu.org; Tue, 29 Nov 2011 03:42:12 -0500 Received: from mail-out.m-online.net ([212.18.0.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVJGS-0006fk-Ne for 10145@debbugs.gnu.org; Tue, 29 Nov 2011 03:42:10 -0500 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id F1B011853BA2; Tue, 29 Nov 2011 09:43:32 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id DDFD51C000F5; Tue, 29 Nov 2011 09:40:07 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id rp5-mtn8vWw1; Tue, 29 Nov 2011 09:40:06 +0100 (CET) Received: from hase.home (ppp-88-217-120-39.dynamic.mnet-online.de [88.217.120.39]) by mail.mnet-online.de (Postfix) with ESMTP; Tue, 29 Nov 2011 09:40:05 +0100 (CET) From: Andreas Schwab To: Juri Linkov Subject: Re: bug#10145: 24.0.91; Word Isearch backward References: <87k46jyd79.fsf@mail.jurta.org> X-Yow: Where's the Coke machine? Tell me a joke!! Date: Tue, 29 Nov 2011 09:40:09 +0100 In-Reply-To: <87k46jyd79.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 29 Nov 2011 02:33:06 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10145 Cc: 10145@debbugs.gnu.org, Dani Moncayo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Juri Linkov writes: > + doc: /* Given STRING, a string of words separated by word delimiters, The first line needs to be a complete sentence. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 04:57:54 2011 Received: (at 10145) by debbugs.gnu.org; 30 Nov 2011 09:57:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVgvK-0001y6-BP for submit@debbugs.gnu.org; Wed, 30 Nov 2011 04:57:54 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVgvG-0001xl-MV for 10145@debbugs.gnu.org; Wed, 30 Nov 2011 04:57:51 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 0F699684068; Wed, 30 Nov 2011 01:57:48 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7376A451C558; Wed, 30 Nov 2011 01:57:35 -0800 (PST) From: Juri Linkov To: Andreas Schwab Subject: Re: bug#10145: 24.0.91; Word Isearch backward Organization: JURTA References: <87k46jyd79.fsf@mail.jurta.org> Date: Wed, 30 Nov 2011 11:46:38 +0200 In-Reply-To: (Andreas Schwab's message of "Tue, 29 Nov 2011 09:40:09 +0100") Message-ID: <8739d6j62p.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10145 Cc: 10145@debbugs.gnu.org, Dani Moncayo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> + doc: /* Given STRING, a string of words separated by word delimiters, > > The first line needs to be a complete sentence. In the patch below the first line is a complete sentence, and `wordify' is renamed to a better and more correct name `word-regexp': === modified file 'src/search.c' --- src/search.c 2011-11-27 18:17:40 +0000 +++ src/search.c 2011-11-30 09:41:35 +0000 @@ -2078,13 +2078,13 @@ (at your option) any later version. XSETBUFFER (last_thing_searched, current_buffer); } -/* Given STRING, a string of words separated by word delimiters, - compute a regexp that matches those exact words separated by - arbitrary punctuation. If LAX is nonzero, the end of the string - need not match a word boundary unless it ends in whitespace. */ - -static Lisp_Object -wordify (Lisp_Object string, int lax) +DEFUN ("word-regexp", Fword_regexp, Sword_regexp, 1, 2, 0, + doc: /* Return a regexp which matches words, ignoring punctuation. +Given STRING, a string of words separated by word delimiters, +compute a regexp that matches those exact words separated by +arbitrary punctuation. If LAX is non-nil, the end of the string +need not match a word boundary unless it ends in whitespace. */) + (Lisp_Object string, Lisp_Object lax) { register unsigned char *o; register EMACS_INT i, i_byte, len, punct_count = 0, word_count = 0; @@ -2125,7 +2125,7 @@ (at your option) any later version. } adjust = - punct_count + 5 * (word_count - 1) - + ((lax && !whitespace_at_end) ? 2 : 4); + + ((!NILP (lax) && !whitespace_at_end) ? 2 : 4); if (STRING_MULTIBYTE (string)) val = make_uninit_multibyte_string (len + adjust, SBYTES (string) @@ -2162,7 +2162,7 @@ (at your option) any later version. prev_c = c; } - if (!lax || whitespace_at_end) + if (NILP (lax) || whitespace_at_end) { *o++ = '\\'; *o++ = 'b'; @@ -2220,7 +2220,7 @@ (at your option) any later version. Optional fourth argument is repeat count--search for successive occurrences. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 0), bound, noerror, count, -1, 1, 0); + return search_command (Fword_regexp (string, Qnil), bound, noerror, count, -1, 1, 0); } DEFUN ("word-search-forward", Fword_search_forward, Sword_search_forward, 1, 4, @@ -2234,7 +2234,7 @@ (at your option) any later version. Optional fourth argument is repeat count--search for successive occurrences. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 0), bound, noerror, count, 1, 1, 0); + return search_command (Fword_regexp (string, Qnil), bound, noerror, count, 1, 1, 0); } DEFUN ("word-search-backward-lax", Fword_search_backward_lax, Sword_search_backward_lax, 1, 4, @@ -2252,7 +2252,7 @@ (at your option) any later version. Optional fourth argument is repeat count--search for successive occurrences. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 1), bound, noerror, count, -1, 1, 0); + return search_command (Fword_regexp (string, Qt), bound, noerror, count, -1, 1, 0); } DEFUN ("word-search-forward-lax", Fword_search_forward_lax, Sword_search_forward_lax, 1, 4, @@ -2270,7 +2270,7 @@ (at your option) any later version. Optional fourth argument is repeat count--search for successive occurrences. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 1), bound, noerror, count, 1, 1, 0); + return search_command (Fword_regexp (string, Qt), bound, noerror, count, 1, 1, 0); } DEFUN ("re-search-backward", Fre_search_backward, Sre_search_backward, 1, 4, @@ -3229,6 +3229,7 @@ (at your option) any later version. defsubr (&Sposix_string_match); defsubr (&Ssearch_forward); defsubr (&Ssearch_backward); + defsubr (&Sword_regexp); defsubr (&Sword_search_forward); defsubr (&Sword_search_backward); defsubr (&Sword_search_forward_lax); === modified file 'lisp/isearch.el' --- lisp/isearch.el 2011-11-29 18:39:16 +0000 +++ lisp/isearch.el 2011-11-30 09:41:35 +0000 @@ -1438,12 +1447,7 @@ (defun isearch-occur (regexp &optional n (interactive (list (cond - (isearch-word (concat "\\b" (replace-regexp-in-string - "\\W+" "\\W+" - (replace-regexp-in-string - "^\\W+\\|\\W+$" "" isearch-string) - nil t) - "\\b")) + (isearch-word (word-regexp isearch-string)) (isearch-regexp isearch-string) (t (regexp-quote isearch-string))) (if current-prefix-arg (prefix-numeric-value current-prefix-arg)))) @@ -1642,8 +1646,10 @@ (defun isearch-search-and-update () (if (and (eq case-fold-search t) search-upper-case) (setq case-fold-search (isearch-no-upper-case-p isearch-string isearch-regexp))) - (looking-at (if isearch-regexp isearch-string - (regexp-quote isearch-string)))) + (looking-at (cond + (isearch-regexp isearch-string) + (isearch-word (word-regexp isearch-string t)) + (t (regexp-quote isearch-string))))) (error nil)) (or isearch-yank-flag (<= (match-end 0) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 09:02:13 2011 Received: (at 10145) by debbugs.gnu.org; 30 Nov 2011 14:02:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVkjl-0008Sr-9W for submit@debbugs.gnu.org; Wed, 30 Nov 2011 09:02:13 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVkjj-0008Sj-9O for 10145@debbugs.gnu.org; Wed, 30 Nov 2011 09:02:12 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pAUE25Oe030355; Wed, 30 Nov 2011 09:02:06 -0500 Received: by pastel.home (Postfix, from userid 20848) id C0365593DC; Wed, 30 Nov 2011 09:02:05 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#10145: 24.0.91; Word Isearch backward Message-ID: References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> Date: Wed, 30 Nov 2011 09:02:05 -0500 In-Reply-To: <8739d6j62p.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 30 Nov 2011 11:46:38 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4056=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4056> : streams <706554> : uri <1019097> X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: 10145 Cc: Andreas Schwab , 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) > In the patch below the first line is a complete sentence, > and `wordify' is renamed to a better and more correct name > `word-regexp': While `wordify' was OK as a local function in search.c, I think that both `wordify' and `word-regexp' are too terse names for (global) Elisp functions. Maybe `search-words-regexp' would be appropriate. Of course, I also see no reason why it should be implemented in C, so moving it to Elisp would be welcome. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 10:45:19 2011 Received: (at 10145) by debbugs.gnu.org; 30 Nov 2011 15:45:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVmLW-0002du-RA for submit@debbugs.gnu.org; Wed, 30 Nov 2011 10:45:19 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVmLQ-0002dS-Cr for 10145@debbugs.gnu.org; Wed, 30 Nov 2011 10:45:13 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id CFAD768405A; Wed, 30 Nov 2011 07:45:07 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 20F10451C5C7; Wed, 30 Nov 2011 07:44:54 -0800 (PST) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#10145: 24.0.91; Word Isearch backward Organization: JURTA References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> Date: Wed, 30 Nov 2011 17:32:45 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 30 Nov 2011 09:02:05 -0500") Message-ID: <87aa7dd48q.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10145 Cc: Andreas Schwab , 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> In the patch below the first line is a complete sentence, >> and `wordify' is renamed to a better and more correct name >> `word-regexp': > > While `wordify' was OK as a local function in search.c, I think that > both `wordify' and `word-regexp' are too terse names for (global) > Elisp functions. Maybe `search-words-regexp' would be appropriate. I constructed that name based on the naming pattern of related functions `word-search-forward' and `word-search-backward'. A similar name would be `word-search-regexp'. However, it is used not only for search, but for `looking-at' too, so we have to eliminate the `search' part from the name. Therefore `word-regexp'. Another naming pattern would be `regexp-quote' that takes a string and returns a regexp. `quote' is a verb here, so using a verb would produce a name like `regexp-wordify'. Yet another naming pattern is `number-to-string'. Using that we get the name `words-to-regexp'. > Of course, I also see no reason why it should be implemented in C, so > moving it to Elisp would be welcome. I'll provide an Elisp version once the function name is agreed upon. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 14:11:27 2011 Received: (at 10145) by debbugs.gnu.org; 30 Nov 2011 19:11:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVpZ1-0007Zm-6A for submit@debbugs.gnu.org; Wed, 30 Nov 2011 14:11:27 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVpYy-0007Zd-V8 for 10145@debbugs.gnu.org; Wed, 30 Nov 2011 14:11:26 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pAUJBIX2029631; Wed, 30 Nov 2011 14:11:18 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id C484D13008C; Wed, 30 Nov 2011 14:11:18 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#10145: 24.0.91; Word Isearch backward Message-ID: References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> <87aa7dd48q.fsf@mail.jurta.org> Date: Wed, 30 Nov 2011 14:11:18 -0500 In-Reply-To: <87aa7dd48q.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 30 Nov 2011 17:32:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4057=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4057> : streams <706621> : uri <1019290> X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: 10145 Cc: Andreas Schwab , 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) > `word-search-forward' and `word-search-backward'. A similar name > would be `word-search-regexp'. However, it is used not only for search, > but for `looking-at' too, so we have to eliminate the `search' part > from the name. Therefore `word-regexp'. `word-search-regexp' is good, thank you. > I'll provide an Elisp version once the function name is agreed upon. Thanks. Of course, that would/will have to wait for 24.2. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 02:32:17 2011 Received: (at 10145) by debbugs.gnu.org; 1 Dec 2011 07:32:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RW17x-0007iX-GH for submit@debbugs.gnu.org; Thu, 01 Dec 2011 02:32:17 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RW17v-0007iP-0i for 10145@debbugs.gnu.org; Thu, 01 Dec 2011 02:32:16 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 91270684062; Wed, 30 Nov 2011 23:32:06 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 40BA0451C5C7; Wed, 30 Nov 2011 23:31:53 -0800 (PST) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#10145: 24.0.91; Word Isearch backward Organization: JURTA References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> <87aa7dd48q.fsf@mail.jurta.org> Date: Thu, 01 Dec 2011 09:27:14 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 30 Nov 2011 14:11:18 -0500") Message-ID: <878vmwu55q.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10145 Cc: 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > `word-search-regexp' is good, thank you. > >> I'll provide an Elisp version once the function name is agreed upon. > > Thanks. Of course, that would/will have to wait for 24.2. This is intended to fix a bug reported by Dani for 24.1. Below is a complete patch. Please decide what to do. The Elisp version passes all regression tests and its output is identical to the output of the C version: (word-search-regexp "") "" (word-search-regexp " ") "" (word-search-regexp "w") "\\bw\\b" (word-search-regexp " w") "\\bw\\b" (word-search-regexp "w ") "\\bw\\b" (word-search-regexp " w ") "\\bw\\b" (word-search-regexp "w w") "\\bw\\W\\W*w\\b" (word-search-regexp " w w") "\\bw\\W\\W*w\\b" (word-search-regexp "w w ") "\\bw\\W\\W*w\\b" (word-search-regexp " w w ") "\\bw\\W\\W*w\\b" (word-search-regexp "" t) "" (word-search-regexp " " t) "" (word-search-regexp "w" t) "\\bw" (word-search-regexp " w" t) "\\bw" (word-search-regexp "w " t) "\\bw\\b" (word-search-regexp " w " t) "\\bw\\b" (word-search-regexp "w w" t) "\\bw\\W\\W*w" (word-search-regexp " w w" t) "\\bw\\W\\W*w" (word-search-regexp "w w " t) "\\bw\\W\\W*w\\b" (word-search-regexp " w w " t) "\\bw\\W\\W*w\\b" === modified file 'lisp/isearch.el' --- lisp/isearch.el 2011-11-29 18:39:16 +0000 +++ lisp/isearch.el 2011-12-01 07:27:07 +0000 @@ -1380,6 +1389,20 @@ (defun isearch-toggle-case-fold () (sit-for 1) (isearch-update)) +(defun word-search-regexp (string &optional lax) + "Return a regexp which matches words, ignoring punctuation. +Given STRING, a string of words separated by word delimiters, +compute a regexp that matches those exact words separated by +arbitrary punctuation. If LAX is non-nil, the end of the string +need not match a word boundary unless it ends in whitespace. +Used in `word-search-forward' and `word-search-backward'." + (if (string-match-p "^\\W*$" string) + "" + (concat + "\\b" + (mapconcat 'identity (split-string string "\\W\\W*" t) "\\W\\W*") + (if (or (not lax) (string-match-p "\\W$" string)) "\\b")))) + (defun isearch-query-replace (&optional delimited regexp-flag) "Start `query-replace' with string to replace from last search string. The arg DELIMITED (prefix arg if interactive), if non-nil, means replace @@ -1642,8 +1660,10 @@ (defun isearch-search-and-update () (if (and (eq case-fold-search t) search-upper-case) (setq case-fold-search (isearch-no-upper-case-p isearch-string isearch-regexp))) - (looking-at (if isearch-regexp isearch-string - (regexp-quote isearch-string)))) + (looking-at (cond + (isearch-regexp isearch-string) + (isearch-word (word-search-regexp isearch-string t)) + (t (regexp-quote isearch-string))))) (error nil)) (or isearch-yank-flag (<= (match-end 0) === modified file 'src/search.c' --- src/search.c 2011-11-27 18:17:40 +0000 +++ src/search.c 2011-12-01 07:27:07 +0000 @@ -2078,99 +2077,6 @@ (at your option) any later version. XSETBUFFER (last_thing_searched, current_buffer); } -/* Given STRING, a string of words separated by word delimiters, - compute a regexp that matches those exact words separated by - arbitrary punctuation. If LAX is nonzero, the end of the string - need not match a word boundary unless it ends in whitespace. */ - -static Lisp_Object -wordify (Lisp_Object string, int lax) -{ - register unsigned char *o; - register EMACS_INT i, i_byte, len, punct_count = 0, word_count = 0; - Lisp_Object val; - int prev_c = 0; - EMACS_INT adjust; - int whitespace_at_end; - - CHECK_STRING (string); - len = SCHARS (string); - - for (i = 0, i_byte = 0; i < len; ) - { - int c; - - FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE (c, string, i, i_byte); - - if (SYNTAX (c) != Sword) - { - punct_count++; - if (SYNTAX (prev_c) == Sword) - word_count++; - } - - prev_c = c; - } - - if (SYNTAX (prev_c) == Sword) - { - word_count++; - whitespace_at_end = 0; - } - else - { - whitespace_at_end = 1; - if (!word_count) - return empty_unibyte_string; - } - - adjust = - punct_count + 5 * (word_count - 1) - + ((lax && !whitespace_at_end) ? 2 : 4); - if (STRING_MULTIBYTE (string)) - val = make_uninit_multibyte_string (len + adjust, - SBYTES (string) - + adjust); - else - val = make_uninit_string (len + adjust); - - o = SDATA (val); - *o++ = '\\'; - *o++ = 'b'; - prev_c = 0; - - for (i = 0, i_byte = 0; i < len; ) - { - int c; - EMACS_INT i_byte_orig = i_byte; - - FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE (c, string, i, i_byte); - - if (SYNTAX (c) == Sword) - { - memcpy (o, SDATA (string) + i_byte_orig, i_byte - i_byte_orig); - o += i_byte - i_byte_orig; - } - else if (SYNTAX (prev_c) == Sword && --word_count) - { - *o++ = '\\'; - *o++ = 'W'; - *o++ = '\\'; - *o++ = 'W'; - *o++ = '*'; - } - - prev_c = c; - } - - if (!lax || whitespace_at_end) - { - *o++ = '\\'; - *o++ = 'b'; - } - - return val; -} - DEFUN ("search-backward", Fsearch_backward, Ssearch_backward, 1, 4, "MSearch backward: ", doc: /* Search backward from point for STRING. @@ -2209,6 +2115,9 @@ (at your option) any later version. return search_command (string, bound, noerror, count, 1, 0, 0); } +/* Function that returns a regexp which matches words, ignoring punctuation. */ +static Lisp_Object Qword_search_regexp; + DEFUN ("word-search-backward", Fword_search_backward, Sword_search_backward, 1, 4, "sWord search backward: ", doc: /* Search backward from point for STRING, ignoring differences in punctuation. @@ -2217,10 +2126,15 @@ (at your option) any later version. The match found must not extend before that position. Optional third argument, if t, means if fail just return nil (no error). If not nil and not t, move to limit of search and return nil. -Optional fourth argument is repeat count--search for successive occurrences. */) +Optional fourth argument is repeat count--search for successive occurrences. + +Relies on the function `word-search-regexp' to convert a sequence +of words in STRING to a regexp used to search words without regard +to punctuation. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 0), bound, noerror, count, -1, 1, 0); + return search_command (call2 (Qword_search_regexp, string, Qnil), + bound, noerror, count, -1, 1, 0); } DEFUN ("word-search-forward", Fword_search_forward, Sword_search_forward, 1, 4, @@ -2231,10 +2145,15 @@ (at your option) any later version. The match found must not extend after that position. Optional third argument, if t, means if fail just return nil (no error). If not nil and not t, move to limit of search and return nil. -Optional fourth argument is repeat count--search for successive occurrences. */) +Optional fourth argument is repeat count--search for successive occurrences. + +Relies on the function `word-search-regexp' to convert a sequence +of words in STRING to a regexp used to search words without regard +to punctuation. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 0), bound, noerror, count, 1, 1, 0); + return search_command (call2 (Qword_search_regexp, string, Qnil), + bound, noerror, count, 1, 1, 0); } DEFUN ("word-search-backward-lax", Fword_search_backward_lax, Sword_search_backward_lax, 1, 4, @@ -2249,10 +2168,15 @@ (at your option) any later version. The match found must not extend before that position. Optional third argument, if t, means if fail just return nil (no error). If not nil and not t, move to limit of search and return nil. -Optional fourth argument is repeat count--search for successive occurrences. */) +Optional fourth argument is repeat count--search for successive occurrences. + +Relies on the function `word-search-regexp' to convert a sequence +of words in STRING to a regexp used to search words without regard +to punctuation. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 1), bound, noerror, count, -1, 1, 0); + return search_command (call2 (Qword_search_regexp, string, Qt), + bound, noerror, count, -1, 1, 0); } DEFUN ("word-search-forward-lax", Fword_search_forward_lax, Sword_search_forward_lax, 1, 4, @@ -2267,10 +2191,15 @@ (at your option) any later version. The match found must not extend after that position. Optional third argument, if t, means if fail just return nil (no error). If not nil and not t, move to limit of search and return nil. -Optional fourth argument is repeat count--search for successive occurrences. */) +Optional fourth argument is repeat count--search for successive occurrences. + +Relies on the function `word-search-regexp' to convert a sequence +of words in STRING to a regexp used to search words without regard +to punctuation. */) (Lisp_Object string, Lisp_Object bound, Lisp_Object noerror, Lisp_Object count) { - return search_command (wordify (string, 1), bound, noerror, count, 1, 1, 0); + return search_command (call2 (Qword_search_regexp, string, Qt), + bound, noerror, count, 1, 1, 0); } DEFUN ("re-search-backward", Fre_search_backward, Sre_search_backward, 1, 4, @@ -3243,4 +3172,5 @@ (at your option) any later version. defsubr (&Smatch_data); defsubr (&Sset_match_data); defsubr (&Sregexp_quote); + DEFSYM (Qword_search_regexp, "word-search-regexp"); } From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 02:35:06 2011 Received: (at control) by debbugs.gnu.org; 1 Dec 2011 07:35:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RW1Af-0007me-2x for submit@debbugs.gnu.org; Thu, 01 Dec 2011 02:35:05 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RW1Ad-0007mY-Iw for control@debbugs.gnu.org; Thu, 01 Dec 2011 02:35:03 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id C0A57684056 for ; Wed, 30 Nov 2011 23:34:55 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id CA8F8451C5C7 for ; Wed, 30 Nov 2011 23:34:42 -0800 (PST) From: Juri Linkov To: control@debbugs.gnu.org Subject: tags 10145 + patch Organization: JURTA Date: Thu, 01 Dec 2011 09:34:41 +0200 Message-ID: <877h2gu4mm.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 10145 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 11:00:35 2011 Received: (at 10145) by debbugs.gnu.org; 1 Dec 2011 16:00:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RW93o-0004Ye-K3 for submit@debbugs.gnu.org; Thu, 01 Dec 2011 11:00:34 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RW93m-0004YX-MN for 10145@debbugs.gnu.org; Thu, 01 Dec 2011 11:00:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhcFAHWj105Ld/3d/2dsb2JhbABEqEyCLIEGgXIBAQVWIxALNBIUGA0kwCCLIASIKJoQhE8 X-IronPort-AV: E=Sophos;i="4.71,279,1320642000"; d="scan'208";a="150386493" Received: from 75-119-253-221.dsl.teksavvy.com (HELO ceviche.home) ([75.119.253.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 01 Dec 2011 11:00:20 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 3D406660D4; Thu, 1 Dec 2011 11:00:20 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#10145: 24.0.91; Word Isearch backward Message-ID: References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> <87aa7dd48q.fsf@mail.jurta.org> <878vmwu55q.fsf@mail.jurta.org> Date: Thu, 01 Dec 2011 11:00:20 -0500 In-Reply-To: <878vmwu55q.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 01 Dec 2011 09:27:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10145 Cc: 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> `word-search-regexp' is good, thank you. >>> I'll provide an Elisp version once the function name is agreed upon. >> Thanks. Of course, that would/will have to wait for 24.2. > This is intended to fix a bug reported by Dani for 24.1. Yes, of course the fix needs to be installed now, only the move to Elisp needs to wait for 24.2. Stefan PS: BTW, I'd assume that word-search-{for,back}ward{-lax,} would want to move to Elisp. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 05:24:10 2011 Received: (at 10145) by debbugs.gnu.org; 2 Dec 2011 10:24:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWQHq-0006rv-7E for submit@debbugs.gnu.org; Fri, 02 Dec 2011 05:24:10 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWQHn-0006rl-0L for 10145@debbugs.gnu.org; Fri, 02 Dec 2011 05:24:08 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 05F88684063; Fri, 2 Dec 2011 02:23:52 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id C487F451C2F5; Fri, 2 Dec 2011 02:23:36 -0800 (PST) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#10145: 24.0.91; Word Isearch backward Organization: JURTA References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> <87aa7dd48q.fsf@mail.jurta.org> <878vmwu55q.fsf@mail.jurta.org> Date: Fri, 02 Dec 2011 12:22:11 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 01 Dec 2011 11:00:20 -0500") Message-ID: <878vmvff3g.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10145 Cc: 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Yes, of course the fix needs to be installed now, only the move to Elisp > needs to wait for 24.2. Installed without reimplementing in Lisp. > PS: BTW, I'd assume that word-search-{for,back}ward{-lax,} would want to > move to Elisp. I'll try to do that. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 05:49:30 2011 Received: (at 10145) by debbugs.gnu.org; 2 Dec 2011 10:49:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWQgM-0007TJ-1n for submit@debbugs.gnu.org; Fri, 02 Dec 2011 05:49:30 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWQgK-0007TC-8l for 10145@debbugs.gnu.org; Fri, 02 Dec 2011 05:49:29 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LVK00000OKSUS00@a-mtaout23.012.net.il> for 10145@debbugs.gnu.org; Fri, 02 Dec 2011 12:49:13 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.120.75]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LVK00046OPZV100@a-mtaout23.012.net.il>; Fri, 02 Dec 2011 12:49:12 +0200 (IST) Date: Fri, 02 Dec 2011 12:48:06 +0200 From: Eli Zaretskii Subject: Re: bug#10145: 24.0.91; Word Isearch backward In-reply-to: <878vmvff3g.fsf@mail.jurta.org> X-012-Sender: halo1@inter.net.il To: Juri Linkov Message-id: <83fwh3ckrd.fsf@gnu.org> References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> <87aa7dd48q.fsf@mail.jurta.org> <878vmwu55q.fsf@mail.jurta.org> <878vmvff3g.fsf@mail.jurta.org> X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 10145 Cc: monnier@iro.umontreal.ca, 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) > From: Juri Linkov > Date: Fri, 02 Dec 2011 12:22:11 +0200 > Cc: 10145@debbugs.gnu.org > > > PS: BTW, I'd assume that word-search-{for,back}ward{-lax,} would want to > > move to Elisp. > > I'll try to do that. Thanks, but I very much hope such changes will wait for 24.2. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 09:38:29 2011 Received: (at 10145) by debbugs.gnu.org; 2 Dec 2011 14:38:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWUFx-0007Dt-BG for submit@debbugs.gnu.org; Fri, 02 Dec 2011 09:38:29 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWUFv-0007Dk-2t for 10145@debbugs.gnu.org; Fri, 02 Dec 2011 09:38:27 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pB2EcAuh003841; Fri, 2 Dec 2011 09:38:11 -0500 Received: by pastel.home (Postfix, from userid 20848) id ABC6E58CC3; Fri, 2 Dec 2011 09:38:10 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#10145: 24.0.91; Word Isearch backward Message-ID: References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> <87aa7dd48q.fsf@mail.jurta.org> <878vmwu55q.fsf@mail.jurta.org> <878vmvff3g.fsf@mail.jurta.org> Date: Fri, 02 Dec 2011 09:38:10 -0500 In-Reply-To: <878vmvff3g.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 02 Dec 2011 12:22:11 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4058=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4058> : streams <707145> : uri <1020390> X-Spam-Score: -4.5 (----) X-Debbugs-Envelope-To: 10145 Cc: 10145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) >> Yes, of course the fix needs to be installed now, only the move to Elisp >> needs to wait for 24.2. > Installed without reimplementing in Lisp. Thank you, so we can close this bug, right? Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 12:19:10 2011 Received: (at 10145-done) by debbugs.gnu.org; 2 Dec 2011 17:19:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWWlS-0002hM-21 for submit@debbugs.gnu.org; Fri, 02 Dec 2011 12:19:10 -0500 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWWlK-0002gY-Dk for 10145-done@debbugs.gnu.org; Fri, 02 Dec 2011 12:19:03 -0500 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 50D5968406A; Fri, 2 Dec 2011 09:18:46 -0800 (PST) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id E4C3D451C5F0; Fri, 2 Dec 2011 09:18:31 -0800 (PST) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#10145: 24.0.91; Word Isearch backward Organization: JURTA References: <87k46jyd79.fsf@mail.jurta.org> <8739d6j62p.fsf@mail.jurta.org> <87aa7dd48q.fsf@mail.jurta.org> <878vmwu55q.fsf@mail.jurta.org> <878vmvff3g.fsf@mail.jurta.org> Date: Fri, 02 Dec 2011 19:11:29 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 02 Dec 2011 09:38:10 -0500") Message-ID: <87borqzyny.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10145-done Cc: 10145-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >>> Yes, of course the fix needs to be installed now, only the move to Elisp >>> needs to wait for 24.2. >> Installed without reimplementing in Lisp. > > Thank you, so we can close this bug, right? Right, I'll try not to forget installing the move to Elisp after feature freeze is over (the `pending' branch currently looks like abandoned - not updated for a long time). From unknown Fri Aug 08 15:17:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 31 Dec 2011 12:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator