From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 22 14:03:11 2011 Received: (at submit) by debbugs.gnu.org; 22 Nov 2011 19:03:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSvcc-0001CR-Cx for submit@debbugs.gnu.org; Tue, 22 Nov 2011 14:03:11 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSvca-0001CJ-GI for submit@debbugs.gnu.org; Tue, 22 Nov 2011 14:03:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSvbF-0002wN-LK for submit@debbugs.gnu.org; Tue, 22 Nov 2011 14:01:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:53398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSvbF-0002wC-Jo for submit@debbugs.gnu.org; Tue, 22 Nov 2011 14:01:45 -0500 Received: from eggs.gnu.org ([140.186.70.92]:52062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSvbE-0001f2-04 for bug-coreutils@gnu.org; Tue, 22 Nov 2011 14:01:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSvbC-0002vs-Ny for bug-coreutils@gnu.org; Tue, 22 Nov 2011 14:01:43 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:55477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSvbC-0002vm-Bx for bug-coreutils@gnu.org; Tue, 22 Nov 2011 14:01:42 -0500 Received: from [192.168.2.108] (p4FF766F1.dip.t-dialin.net [79.247.102.241]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0Lnjgd-1Qw41L0BpP-00hQL0; Tue, 22 Nov 2011 20:01:39 +0100 Message-ID: <4ECBF172.4020002@bernhard-voelker.de> Date: Tue, 22 Nov 2011 20:01:06 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111101 SUSE/3.1.16 Thunderbird/3.1.16 MIME-Version: 1.0 To: bug-coreutils@gnu.org Subject: tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on Linux Content-Type: multipart/mixed; boundary="------------080308060009060408060907" X-Provags-ID: V02:K0:nArK4V7M+BJP/vWoeATOLXyZMXmwI/4OSGt8NCcsM2I qbA3m99ovp1M85JJzazZ786/PmCzM/4y0sRMOUu87Fj7YvlR47 z1OuTncx7jBz0s0rBNWhhprZQa4bBH1ROVx0t4+9M6/0UEA6Zj a20z6yOOdGRj+QXVzOoy+Ofc0GXJ7RTR4kDEIETLByFXF+JsAT PRcphD9JxPganfJsWV7hGf/8wFN0qcy+OhYMqd0qA64APvd40W 18qLBlZSIh7U4qAiym+08yPVH+Cnc+H5nCFHJUgJsHWsPbl/+x ea8fqzqqoiGv0lArrtbeuIkkGC4xfkbR1SBfLNaxCUTnYgRVqA CsvGYqVdVg4P0OfoeAXx8onVRLwsJeDOuHoTk57l+ X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.8 (-----) This is a multi-part message in MIME format. --------------080308060009060408060907 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi, this new tests is skipped on my OpenSuSE-11.4 system: ... + require_gnu_ ++ uname + test Linux = GNU + skip_ 'not running on GNU/Hurd' + warn_ 'gnu-zero-uids: skipped test: not running on GNU/Hurd' + case $IFS in + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd' gnu-zero-uids: skipped test: not running on GNU/Hurd + test 9 = 2 + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd' + sed 1q + Exit 77 I'm confused by this message: I do not have a GNU/Hurd system, but the test is skipped. Shouldn't it be "skipping test: only running on GNU/Hurd"? Or should the test run on Linux and require_gnu_ is buggy? Have a nice day, Berny --------------080308060009060408060907 Content-Type: text/x-log; name="gnu-zero-uids.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gnu-zero-uids.log" SKIP: id/gnu-zero-uids (exit: 77) ================================= ++ initial_cwd_=/home/berny/git/coreutils/tests ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /home/berny/git/coreutils/tests gt-gnu-zero-uids.XXXX +++ case $# in +++ destdir_=/home/berny/git/coreutils/tests +++ template_=gt-gnu-zero-uids.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR ++++ mktemp -d -t -p /home/berny/git/coreutils/tests gt-gnu-zero-uids.XXXX +++ d=/home/berny/git/coreutils/tests/gt-gnu-zero-uids.ftiS +++ case $d in +++ test -d /home/berny/git/coreutils/tests/gt-gnu-zero-uids.ftiS ++++ ls -dgo /home/berny/git/coreutils/tests/gt-gnu-zero-uids.ftiS ++++ tr S - +++ perms='drwx------ 2 4096 Nov 22 19:48 /home/berny/git/coreutils/tests/gt-gnu-zero-uids.fti-' +++ case $perms in +++ test 0 = 0 +++ echo /home/berny/git/coreutils/tests/gt-gnu-zero-uids.ftiS +++ return ++ test_dir_=/home/berny/git/coreutils/tests/gt-gnu-zero-uids.ftiS ++ cd /home/berny/git/coreutils/tests/gt-gnu-zero-uids.ftiS ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ../src + test 1 '!=' 0 + path_dir_=../src + case $path_dir_ in ++ cd /home/berny/git/coreutils/tests/../src ++ echo /home/berny/git/coreutils/src + abs_path_dir_=/home/berny/git/coreutils/src + case $abs_path_dir_ in + PATH=/home/berny/git/coreutils/src:/home/berny/git/coreutils/src:/usr/lib64/mpi/gcc/openmpi/bin:/home/berny/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games + create_exe_shims_ /home/berny/git/coreutils/src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ id + test yes = yes + local i + for i in '$*' + env id --version id (GNU coreutils) 8.14.69-33314 Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by Arnold Robbins and David MacKenzie. + require_gnu_ ++ uname + test Linux = GNU + skip_ 'not running on GNU/Hurd' + warn_ 'gnu-zero-uids: skipped test: not running on GNU/Hurd' + case $IFS in + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd' gnu-zero-uids: skipped test: not running on GNU/Hurd + test 9 = 2 + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd' + sed 1q + Exit 77 + set +e + exit 77 + exit 77 + remove_tmp_ + __st=77 + cleanup_ + : + cd /home/berny/git/coreutils/tests + chmod -R u+rwx /home/berny/git/coreutils/tests/gt-gnu-zero-uids.ftiS + rm -rf /home/berny/git/coreutils/tests/gt-gnu-zero-uids.ftiS + exit 77 --------------080308060009060408060907-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 22 14:08:08 2011 Received: (at 10110) by debbugs.gnu.org; 22 Nov 2011 19:08:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSvhP-0001LG-2T for submit@debbugs.gnu.org; Tue, 22 Nov 2011 14:08:07 -0500 Received: from mx.meyering.net ([88.168.87.75]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSvhN-0001L9-3e for 10110@debbugs.gnu.org; Tue, 22 Nov 2011 14:08:05 -0500 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 3367D601AF; Tue, 22 Nov 2011 20:06:43 +0100 (CET) From: Jim Meyering To: Bernhard Voelker Subject: Re: bug#10110: tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on Linux In-Reply-To: <4ECBF172.4020002@bernhard-voelker.de> (Bernhard Voelker's message of "Tue, 22 Nov 2011 20:01:06 +0100") References: <4ECBF172.4020002@bernhard-voelker.de> Date: Tue, 22 Nov 2011 20:06:43 +0100 Message-ID: <87wras7z98.fsf@rho.meyering.net> Lines: 27 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 10110 Cc: 10110@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Bernhard Voelker wrote: > Hi, > > this new tests is skipped on my OpenSuSE-11.4 system: > > ... > + require_gnu_ > ++ uname > + test Linux = GNU > + skip_ 'not running on GNU/Hurd' > + warn_ 'gnu-zero-uids: skipped test: not running on GNU/Hurd' > + case $IFS in > + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd' > gnu-zero-uids: skipped test: not running on GNU/Hurd > + test 9 = 2 > + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd' > + sed 1q > + Exit 77 > > I'm confused by this message: > I do not have a GNU/Hurd system, but the test is skipped. > > Shouldn't it be "skipping test: only running on GNU/Hurd"? > Or should the test run on Linux and require_gnu_ is buggy? It's saying that the test is being skipped because it is "not running on GNU/Hurd" From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 22 14:10:06 2011 Received: (at control) by debbugs.gnu.org; 22 Nov 2011 19:10:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSvjK-0001Of-KP for submit@debbugs.gnu.org; Tue, 22 Nov 2011 14:10:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSvjG-0001OJ-VD; Tue, 22 Nov 2011 14:10:04 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAMJ8bFX015605 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Nov 2011 14:08:37 -0500 Received: from [10.3.113.144] (ovpn-113-144.phx2.redhat.com [10.3.113.144]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pAMJ8b0a002617; Tue, 22 Nov 2011 14:08:37 -0500 Message-ID: <4ECBF334.8040209@redhat.com> Date: Tue, 22 Nov 2011 12:08:36 -0700 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Bernhard Voelker Subject: Re: bug#10110: tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on Linux References: <4ECBF172.4020002@bernhard-voelker.de> In-Reply-To: <4ECBF172.4020002@bernhard-voelker.de> X-Enigmail-Version: 1.3.3 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig5AA2FF63E2E6563F00E6FD4A" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -10.3 (----------) X-Debbugs-Envelope-To: control Cc: 10110-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -10.3 (----------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5AA2FF63E2E6563F00E6FD4A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable tag 10110 notabug thanks On 11/22/2011 12:01 PM, Bernhard Voelker wrote: > Hi, >=20 > this new tests is skipped on my OpenSuSE-11.4 system: This may have been a question better for the coreutils@gnu.org list, rather than opening up a new bug report. As such, I tagged this as not a bug, and marked it closed; but we can reopen it if you can propose better wording that would avoid further confusion. >=20 > ... > + require_gnu_ > ++ uname > + test Linux =3D GNU > + skip_ 'not running on GNU/Hurd' > + warn_ 'gnu-zero-uids: skipped test: not running on GNU/Hurd' > + case $IFS in > + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd' > gnu-zero-uids: skipped test: not running on GNU/Hurd > + test 9 =3D 2 > + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd' > + sed 1q > + Exit 77 >=20 > I'm confused by this message: > I do not have a GNU/Hurd system, but the test is skipped. It made sense to me, short for: "We are skipping this test, since you are not running the test on GNU/Hurd, which is the only platform known to be affected by the problem exposed by the test" >=20 > Shouldn't it be "skipping test: only running on GNU/Hurd"? That doesn't read right to me, since you _aren't_ running on GNU/Hurd, but GNU/Linux. > Or should the test run on Linux and require_gnu_ is buggy? No. The test can only pass on a system where getuid() can fail, and the only known platform where that is the case is GNU/Hurd (GNU/Linux does not provide the extension of a getuid() that can fail by executing a process outside the realm of POSIX process ids). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig5AA2FF63E2E6563F00E6FD4A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJOy/M1AAoJEKeha0olJ0NqvyIH/1E/iTdhOL4EgHHYHq8mjQQU AdrE1ef1HgPIyr5H/Y4QumTHJEZ48oYo+qiktKIKEvXt0UDKPodGOzAFM9sXM2cw DDUIneqo4BhDow7PbZRkOReG2oLal3uMKjY0sVPuYpMcZh3ruXoTCZYhj4jWte+X /V7dRR7ivzc3XCgNfRzO/9vKUK8VG0LeC/uZOWKOjBbaUHld3wRHd6eo1NDsfLIo OdRfbV/HQ+jLUuq8XUnWbNIuiM48V234D36G0y1SNEBJEN5Qyotdo8yK7mYasjCN SkOpiGwGUodP2ii3I2iz0z6u55PcTlNIn2v075hvGem9kmYxTJFUOGbPBNkYOeE= =PNJC -----END PGP SIGNATURE----- --------------enig5AA2FF63E2E6563F00E6FD4A-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 23 02:37:26 2011 Received: (at 10110-done) by debbugs.gnu.org; 23 Nov 2011 07:37:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RT7OX-0003jA-Mc for submit@debbugs.gnu.org; Wed, 23 Nov 2011 02:37:26 -0500 Received: from moutng.kundenserver.de ([212.227.17.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RT7OV-0003j2-DI for 10110-done@debbugs.gnu.org; Wed, 23 Nov 2011 02:37:24 -0500 Received: from [192.168.2.108] (p4FF73ED4.dip.t-dialin.net [79.247.62.212]) by mrelayeu.kundenserver.de (node=mreu3) with ESMTP (Nemesis) id 0Mgltb-1RFjTw0FL5-00O1gk; Wed, 23 Nov 2011 08:35:55 +0100 Message-ID: <4ECCA259.6050204@bernhard-voelker.de> Date: Wed, 23 Nov 2011 08:35:53 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111101 SUSE/3.1.16 Thunderbird/3.1.16 MIME-Version: 1.0 To: Eric Blake Subject: Re: bug#10110: tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on Linux References: <4ECBF172.4020002@bernhard-voelker.de> <4ECBF334.8040209@redhat.com> In-Reply-To: <4ECBF334.8040209@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:v9+K/9aCXuZEgUMbXiPxuHah+VkT7g7WJSQOTVuP8+F tOM218HIxualEQnawnd21wDn4mncXyf6tpOpGuH0sPqzrS9TRI e61xkqWVhvjAXc9S4Uxa4Fdk7rwp0W207wNzShduLo4utzzpe0 oyQFNsbVor/wxSUtOfXU0vEQPDXNvBxA233lb5R/xqjLJvFX1F 1JJq3y22XwlKljSZBzbu7PKwNvdMhUnX73+cnTetJXchRzetRi 3EdFqWdPwYmhs2Jvrb7QNNNmRuG2Y5fC25Ut2NIvx2siy06SCE +jl9Kcijckx8UL0oS9iVy/KSfKqevkHcz3xPTcCGB6Ollc9D1Y EH0w9XvRDv6WFwirScBTc30l7fQeXSmXRFuZCnYGk X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 10110-done Cc: 10110-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) On 11/22/2011 08:08 PM, Eric Blake wrote: > tag 10110 notabug > thanks > > On 11/22/2011 12:01 PM, Bernhard Voelker wrote: >> Hi, >> >> this new tests is skipped on my OpenSuSE-11.4 system: > > This may have been a question better for the coreutils@gnu.org list, > rather than opening up a new bug report. As such, I tagged this as not > a bug, and marked it closed; but we can reopen it if you can propose > better wording that would avoid further confusion. sorry for that. I'll try to propose a better wording below. >> gnu-zero-uids: skipped test: not running on GNU/Hurd >> ... >> >> I'm confused by this message: >> I do not have a GNU/Hurd system, but the test is skipped. > > It made sense to me, short for: > > "We are skipping this test, since you are not running the test on > GNU/Hurd, which is the only platform known to be affected by the problem > exposed by the test" Sorry (again). English is not my mother tongue, so I was asking myself *what* is "not running on GNU/Hurd"? Now it's clear: my system (and not the test). >> Shouldn't it be "skipping test: only running on GNU/Hurd"? > > That doesn't read right to me, since you _aren't_ running on GNU/Hurd, > but GNU/Linux. I searched through init.cfg, and thought the following would fit best - what do you think? >From 3274bd90d4823ba57d3c1e797fa3aebb582937af Mon Sep 17 00:00:00 2001 From: Bernhard Voelker Date: Wed, 23 Nov 2011 08:10:48 +0100 Subject: [PATCH] tests: make skip message clearer for GNU/Hurd tests * tests/init.cfg (require_gnu_): enhance message --- tests/init.cfg | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/init.cfg b/tests/init.cfg index 9b05b34..da646ff 100644 --- a/tests/init.cfg +++ b/tests/init.cfg @@ -503,7 +503,7 @@ print_ver_() require_gnu_() { test "$(uname)" = GNU \ - || skip_ 'not running on GNU/Hurd' + || skip_ 'This test requires a GNU/Hurd system' } sanitize_path_ -- 1.7.3.4 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 23 05:06:28 2011 Received: (at 10110) by debbugs.gnu.org; 23 Nov 2011 10:06:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RT9im-0007Bs-Cc for submit@debbugs.gnu.org; Wed, 23 Nov 2011 05:06:28 -0500 Received: from shark.2a.pl ([195.117.102.3]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RT9ij-0007Bi-Nb for 10110@debbugs.gnu.org; Wed, 23 Nov 2011 05:06:27 -0500 Received: from av.2a.pl (av.2a.pl [195.117.102.9]) by shark.2a.pl (Postfix) with ESMTP id AAD1A2A6E0C for <10110@debbugs.gnu.org>; Wed, 23 Nov 2011 11:04:59 +0100 (CET) X-Virus-Scanned: amavisd-new at 2a.pl Received: from shark.2a.pl ([195.117.102.3]) by av.2a.pl (av.2a.pl [195.117.102.9]) (amavisd-new, port 10024) with ESMTP id 8gCpdii98BCf for <10110@debbugs.gnu.org>; Wed, 23 Nov 2011 11:04:53 +0100 (CET) Received: from [10.8.1.26] (unknown [10.8.1.26]) by shark.2a.pl (Postfix) with ESMTPA id 6FF2B2A6E03 for <10110@debbugs.gnu.org>; Wed, 23 Nov 2011 11:04:53 +0100 (CET) Message-ID: <4ECCC531.6080409@stegny.2a.pl> Date: Wed, 23 Nov 2011 11:04:33 +0100 From: =?UTF-8?B?S3J6eXN6dG9mIMW7ZWxlY2hvd3NraQ==?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Firefox/7.0.1 SeaMonkey/2.4.1 MIME-Version: 1.0 To: 10110@debbugs.gnu.org Subject: tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on Linux Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 10110 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) > Sorry (again). English is not my mother tongue, so I was asking myself > *what* is "not running on GNU/Hurd"? Now it's clear: my system (and not > the test). Actually neither of them was. > - || skip_ 'not running on GNU/Hurd' According to the English grammar, this message refers to the current process. A general statement referring to the test itself would be 'does not run on GNU/Hurd' > + || skip_ 'This test requires a GNU/Hurd system' While the original message feels all right, if you insist, "applies to" would sound better. Otherwise, you create an impression that the operator is missing something because she does not have GNU/Hurd, which is not true because GNU/Hurd is not RTM. IMHO, Chris From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 11:43:34 2011 Received: (at 10110-done) by debbugs.gnu.org; 28 Nov 2011 16:43:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RV4In-00070W-Nd for submit@debbugs.gnu.org; Mon, 28 Nov 2011 11:43:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RV4Ij-00070J-Tz for 10110-done@debbugs.gnu.org; Mon, 28 Nov 2011 11:43:32 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pASGfVRg024182 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Nov 2011 11:41:31 -0500 Received: from [10.3.113.130] (ovpn-113-130.phx2.redhat.com [10.3.113.130]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pASGfTNb004720; Mon, 28 Nov 2011 11:41:30 -0500 Message-ID: <4ED3B9B9.4000600@redhat.com> Date: Mon, 28 Nov 2011 09:41:29 -0700 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 MIME-Version: 1.0 To: Bernhard Voelker Subject: Re: bug#10110: tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on Linux References: <4ECBF172.4020002@bernhard-voelker.de> <4ECBF334.8040209@redhat.com> <4ECCA259.6050204@bernhard-voelker.de> In-Reply-To: <4ECCA259.6050204@bernhard-voelker.de> X-Enigmail-Version: 1.3.3 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig3E430126FAD6C083A9E84348" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -10.3 (----------) X-Debbugs-Envelope-To: 10110-done Cc: 10110-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -10.3 (----------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3E430126FAD6C083A9E84348 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 11/23/2011 12:35 AM, Bernhard Voelker wrote: >> This may have been a question better for the coreutils@gnu.org list, >> rather than opening up a new bug report. As such, I tagged this as no= t >> a bug, and marked it closed; but we can reopen it if you can propose >> better wording that would avoid further confusion. >=20 > sorry for that. > I'll try to propose a better wording below. >=20 > +++ b/tests/init.cfg > @@ -503,7 +503,7 @@ print_ver_() > require_gnu_() > { > test "$(uname)" =3D GNU \ > - || skip_ 'not running on GNU/Hurd' > + || skip_ 'This test requires a GNU/Hurd system' > } I like it, but it points out some inconsistencies in init.cfg; some of the skip_ usages are "Caps and period.", your proposed is "Caps but no period", and other uses are "lower and no period". We should probably use a similar style throughout the file, and I'm leaning towards GCS' suggestion of "lower and no period". Jim, thoughts? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig3E430126FAD6C083A9E84348 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJO07m5AAoJEKeha0olJ0NqEn0H/AxEGQ+Ogm1soMTx0Q7XQMJ9 FtA3rnWWBBOuraV6TRryNnfObJ6GXolRPUsbxxBX90bn8YpMHn+2rI1D2RoHS2hm GNmyW3s8JTDZIEP7ZKGy9xbq7zSgnu1JcAxOtfoNqzXAwVt9VpAU6tHAjDTv9Vo7 1B1wEVt7TC6qQlJdhGiD38aJthpeDpP5h7Ge8anHvA5gMJY4fePjVwl4PlM7+A1t j0IRk404luMy7LFmuho70WCuWjjdtzDTkqAI13Ij2wbY5iVDzU3YT5SzLPd1/Vbh +wtbEH/m9P0lqN2iSug+jBzpbhCGwPrUDMs+0u+OdMN1NylUjIwpq0AvL+NvXp4= =m2ZV -----END PGP SIGNATURE----- --------------enig3E430126FAD6C083A9E84348-- From unknown Sun Jun 22 08:09:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Dec 2011 12:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator