GNU bug report logs - #10110
tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on Linux

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10110 in the body.
You can then email your comments to 10110 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: bug-coreutils <at> gnu.org
Subject: tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on
	Linux
Date: Tue, 22 Nov 2011 20:01:06 +0100

[Message part 1 (text/plain, inline)]

Hi,

this new tests is skipped on my OpenSuSE-11.4 system:

...
+ require_gnu_
++ uname
+ test Linux = GNU
+ skip_ 'not running on GNU/Hurd'
+ warn_ 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
+ case $IFS in
+ printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
gnu-zero-uids: skipped test: not running on GNU/Hurd
+ test 9 = 2
+ printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
+ sed 1q
+ Exit 77

I'm confused by this message:
I do not have a GNU/Hurd system, but the test is skipped.

Shouldn't it be "skipping test: only running on GNU/Hurd"?
Or should the test run on Linux and require_gnu_ is buggy?

Have a nice day,
Berny

[gnu-zero-uids.log (text/x-log, attachment)]

Message #8 received at 10110 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 10110 <at> debbugs.gnu.org
Subject: Re: bug#10110: tests/id/gnu-zero-uids: skipping with "not running on
	GNU/Hurd" on Linux
Date: Tue, 22 Nov 2011 20:06:43 +0100

Bernhard Voelker wrote:
> Hi,
>
> this new tests is skipped on my OpenSuSE-11.4 system:
>
> ...
> + require_gnu_
> ++ uname
> + test Linux = GNU
> + skip_ 'not running on GNU/Hurd'
> + warn_ 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
> + case $IFS in
> + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
> gnu-zero-uids: skipped test: not running on GNU/Hurd
> + test 9 = 2
> + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
> + sed 1q
> + Exit 77
>
> I'm confused by this message:
> I do not have a GNU/Hurd system, but the test is skipped.
>
> Shouldn't it be "skipping test: only running on GNU/Hurd"?
> Or should the test run on Linux and require_gnu_ is buggy?

It's saying that the test is being skipped
because it is "not running on GNU/Hurd"

Message #15 received at 10110-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 10110-done <at> debbugs.gnu.org
Subject: Re: bug#10110: tests/id/gnu-zero-uids: skipping with "not running
	on GNU/Hurd" on Linux
Date: Tue, 22 Nov 2011 12:08:36 -0700

[Message part 1 (text/plain, inline)]

tag 10110 notabug
thanks

On 11/22/2011 12:01 PM, Bernhard Voelker wrote:
> Hi,
> 
> this new tests is skipped on my OpenSuSE-11.4 system:

This may have been a question better for the coreutils <at> gnu.org list,
rather than opening up a new bug report.  As such, I tagged this as not
a bug, and marked it closed; but we can reopen it if you can propose
better wording that would avoid further confusion.

> 
> ...
> + require_gnu_
> ++ uname
> + test Linux = GNU
> + skip_ 'not running on GNU/Hurd'
> + warn_ 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
> + case $IFS in
> + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
> gnu-zero-uids: skipped test: not running on GNU/Hurd
> + test 9 = 2
> + printf '%s\n' 'gnu-zero-uids: skipped test: not running on GNU/Hurd'
> + sed 1q
> + Exit 77
> 
> I'm confused by this message:
> I do not have a GNU/Hurd system, but the test is skipped.

It made sense to me, short for:

"We are skipping this test, since you are not running the test on
GNU/Hurd, which is the only platform known to be affected by the problem
exposed by the test"

> 
> Shouldn't it be "skipping test: only running on GNU/Hurd"?

That doesn't read right to me, since you _aren't_ running on GNU/Hurd,
but GNU/Linux.

> Or should the test run on Linux and require_gnu_ is buggy?

No.  The test can only pass on a system where getuid() can fail, and the
only known platform where that is the case is GNU/Hurd (GNU/Linux does
not provide the extension of a getuid() that can fail by executing a
process outside the realm of POSIX process ids).

-- 
Eric Blake   eblake <at> redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Message #16 received at 10110-done <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Eric Blake <eblake <at> redhat.com>
Cc: 10110-done <at> debbugs.gnu.org
Subject: Re: bug#10110: tests/id/gnu-zero-uids: skipping with "not running
	on GNU/Hurd" on Linux
Date: Wed, 23 Nov 2011 08:35:53 +0100

On 11/22/2011 08:08 PM, Eric Blake wrote:
> tag 10110 notabug
> thanks
> 
> On 11/22/2011 12:01 PM, Bernhard Voelker wrote:
>> Hi,
>>
>> this new tests is skipped on my OpenSuSE-11.4 system:
> 
> This may have been a question better for the coreutils <at> gnu.org list,
> rather than opening up a new bug report.  As such, I tagged this as not
> a bug, and marked it closed; but we can reopen it if you can propose
> better wording that would avoid further confusion.

sorry for that.
I'll try to propose a better wording below.

>> gnu-zero-uids: skipped test: not running on GNU/Hurd
>> ...
>>
>> I'm confused by this message:
>> I do not have a GNU/Hurd system, but the test is skipped.
> 
> It made sense to me, short for:
> 
> "We are skipping this test, since you are not running the test on
> GNU/Hurd, which is the only platform known to be affected by the problem
> exposed by the test"

Sorry (again). English is not my mother tongue, so I was asking myself
*what* is "not running on GNU/Hurd"? Now it's clear: my system (and not
the test).

>> Shouldn't it be "skipping test: only running on GNU/Hurd"?
> 
> That doesn't read right to me, since you _aren't_ running on GNU/Hurd,
> but GNU/Linux.

I searched through init.cfg, and thought the following would
fit best - what do you think?

From 3274bd90d4823ba57d3c1e797fa3aebb582937af Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <mail <at> bernhard-voelker.de>
Date: Wed, 23 Nov 2011 08:10:48 +0100
Subject: [PATCH] tests: make skip message clearer for GNU/Hurd tests

* tests/init.cfg (require_gnu_): enhance message
---
 tests/init.cfg |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/init.cfg b/tests/init.cfg
index 9b05b34..da646ff 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -503,7 +503,7 @@ print_ver_()
 require_gnu_()
 {
   test "$(uname)" = GNU \
-    || skip_ 'not running on GNU/Hurd'
+    || skip_ 'This test requires a GNU/Hurd system'
 }

 sanitize_path_
-- 
1.7.3.4

Message #19 received at 10110 <at> debbugs.gnu.org (full text, mbox):

From: Krzysztof Żelechowski
 <giecrilj <at> stegny.2a.pl>
To: 10110 <at> debbugs.gnu.org
Subject: tests/id/gnu-zero-uids: skipping with "not running on GNU/Hurd" on
	Linux
Date: Wed, 23 Nov 2011 11:04:33 +0100

> Sorry (again). English is not my mother tongue, so I was asking myself
> *what* is "not running on GNU/Hurd"? Now it's clear: my system (and not
> the test).
Actually neither of them was.
> -    || skip_ 'not running on GNU/Hurd'
According to the English grammar, this message refers to the current 
process.  A general statement referring to the test itself would be 
'does not run on GNU/Hurd'
> +    || skip_ 'This test requires a GNU/Hurd system'
While the original message feels all right, if you insist, "applies to" 
would sound better.  Otherwise, you create an impression that the 
operator is missing something because she does not have GNU/Hurd, which 
is not true because GNU/Hurd is not RTM.

IMHO,
Chris

Message #20 received at 10110-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 10110-done <at> debbugs.gnu.org
Subject: Re: bug#10110: tests/id/gnu-zero-uids: skipping with "not running
	on GNU/Hurd" on Linux
Date: Mon, 28 Nov 2011 09:41:29 -0700

[Message part 1 (text/plain, inline)]

On 11/23/2011 12:35 AM, Bernhard Voelker wrote:
>> This may have been a question better for the coreutils <at> gnu.org list,
>> rather than opening up a new bug report.  As such, I tagged this as not
>> a bug, and marked it closed; but we can reopen it if you can propose
>> better wording that would avoid further confusion.
> 
> sorry for that.
> I'll try to propose a better wording below.
> 

> +++ b/tests/init.cfg
> @@ -503,7 +503,7 @@ print_ver_()
>  require_gnu_()
>  {
>    test "$(uname)" = GNU \
> -    || skip_ 'not running on GNU/Hurd'
> +    || skip_ 'This test requires a GNU/Hurd system'
>  }

I like it, but it points out some inconsistencies in init.cfg; some of
the skip_ usages are "Caps and period.", your proposed is "Caps but no
period", and other uses are "lower and no period".  We should probably
use a similar style throughout the file, and I'm leaning towards GCS'
suggestion of "lower and no period".  Jim, thoughts?

-- 
Eric Blake   eblake <at> redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.