From unknown Fri Aug 15 15:34:30 2025 X-Loop: don@donarmstrong.com Subject: bug#1009: Carbon: posix-file-name-to-mac Reply-To: David Reitter , 1009@debbugs.gnu.org Resent-From: David Reitter Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 20 Sep 2008 12:40:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1009 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122191401910906 (code B ref -1); Sat, 20 Sep 2008 12:40:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=BAYES_00,FOURLA, IMPRONONCABLE_1,MURPHY_WRONG_WORD1,MURPHY_WRONG_WORD2,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 20 Sep 2008 12:33:39 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8KCXZhh010900 for ; Sat, 20 Sep 2008 05:33:36 -0700 Received: from mx10.gnu.org ([199.232.76.166]:53705) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kh1cc-0005II-V7 for emacs-pretest-bug@gnu.org; Sat, 20 Sep 2008 08:31:35 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kh1eU-0001IB-TU for emacs-pretest-bug@gnu.org; Sat, 20 Sep 2008 08:33:34 -0400 Received: from ug-out-1314.google.com ([66.249.92.170]:44307) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kh1eU-0001Ht-EK for emacs-pretest-bug@gnu.org; Sat, 20 Sep 2008 08:33:30 -0400 Received: by ug-out-1314.google.com with SMTP id z36so1504034uge.17 for ; Sat, 20 Sep 2008 05:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:mime-version:subject:date:x-mailer; bh=hLVNgSaoGUX6KSm+2BwViVRj3imhjzZuIu9GFNcI3Po=; b=TD65IePAmBnI+EQpSBBw/3iPp7ozOOgErZ/b1o8b/JJwzFz45J8jFTB1GD2rvfL+ZE qt3f/nZ21cLPf/TneEv1Fqdi1Ojbx/IAMNqEm3yBYhERc1pwLXteajRV5G+0yP4NcguL ZGqqUUlpN8QKGeE6sCeKui4Y2ygu8cGnKK2b8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:mime-version:subject:date:x-mailer; b=qvm+d3G5hdCqy+gXx4t+Cxm1qkurVNEL6uktGUQqP+s0sJS2vJrpDqX18WuTnSH+t7 wOcEe9SZpxTE64QFEe9sEQXwf9nHrSdEtEqhmJrSQgw/qilcNOjwagfJHLP8YqBRxPz5 UR12e4fIaqUS0cy+O1wy12JSwVpj1tiP7Cm6g= Received: by 10.66.233.14 with SMTP id f14mr1193006ugh.12.1221914006412; Sat, 20 Sep 2008 05:33:26 -0700 (PDT) Received: from ?10.0.1.3? ( [151.201.37.141]) by mx.google.com with ESMTPS id 29sm575077uga.26.2008.09.20.05.33.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 20 Sep 2008 05:33:25 -0700 (PDT) Message-Id: <702E333A-FA7D-4ECE-A116-3DA9C3A64F8E@gmail.com> From: David Reitter To: emacs-pretest-bug@gnu.org Content-Type: multipart/signed; boundary=Apple-Mail-16-941150426; micalg=sha1; protocol="application/pkcs7-signature" Mime-Version: 1.0 (Apple Message framework v929.2) Date: Sat, 20 Sep 2008 08:33:22 -0400 X-Mailer: Apple Mail (2.929.2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) --Apple-Mail-16-941150426 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit (posix-file-name-to-mac "~emacs/asd") (posix-file-name-to-mac "/tmp/") will crash a 22 branch Carbon Emacs. A fix is below - it disables ~emacs and /tmp expansion when getpwnam or get_temp_dir_name return NULL, which they seem to do. (OS X has /tmp, so I'm not sure if the code isn't leftover from MacOS and stopped working at some point.) - D Index: mac.c =================================================================== RCS file: /sources/emacs/emacs/src/Attic/mac.c,v retrieving revision 1.77.2.10 diff -c -r1.77.2.10 mac.c *** mac.c 29 Aug 2008 08:18:07 -0000 1.77.2.10 --- mac.c 20 Sep 2008 12:29:24 -0000 *************** *** 214,237 **** if (strncmp (p, "~emacs/", 7) == 0) { struct passwd *pw = getpwnam ("emacs"); ! p += 7; ! if (strlen (pw->pw_dir) + strlen (p) > MAXPATHLEN) ! return 0; ! strcpy (expanded_pathname, pw->pw_dir); ! strcat (expanded_pathname, p); ! p = expanded_pathname; ! /* now p points to the pathname with emacs dir prefix */ } else if (strncmp (p, "/tmp/", 5) == 0) { char *t = get_temp_dir_name (); ! p += 5; ! if (strlen (t) + strlen (p) > MAXPATHLEN) ! return 0; ! strcpy (expanded_pathname, t); ! strcat (expanded_pathname, p); ! p = expanded_pathname; ! /* now p points to the pathname with emacs dir prefix */ } else if (*p != '/') /* relative pathname */ strcat (mfn, ":"); --- 215,244 ---- if (strncmp (p, "~emacs/", 7) == 0) { struct passwd *pw = getpwnam ("emacs"); ! if (pw != NULL) ! { ! p += 7; ! if (strlen (pw->pw_dir) + strlen (p) > MAXPATHLEN) ! return 0; ! strcpy (expanded_pathname, pw->pw_dir); ! strcat (expanded_pathname, p); ! p = expanded_pathname; ! /* now p points to the pathname with emacs dir prefix */ ! } } else if (strncmp (p, "/tmp/", 5) == 0) { char *t = get_temp_dir_name (); ! if (t != NULL) ! { ! p += 5; ! if (strlen (t) + strlen (p) > MAXPATHLEN) ! return 0; ! strcpy (expanded_pathname, t); ! strcat (expanded_pathname, p); ! p = expanded_pathname; ! /* now p points to the pathname with emacs dir prefix */ ! } } else if (*p != '/') /* relative pathname */ strcat (mfn, ":"); --Apple-Mail-16-941150426 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICEEfSZyInpN9bVdFPsdICbiIwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MTIwOTIzMDM0OFoXDTA4MTIwODIzMDM0 OFowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDIS4kZGULD+CxprkxDnEccAnZ2GQQxfn55aiAPoy5kJ+uLhelaZP4p lgx3Vq8xYK1bjsLepGYp8qzVlHsyQPb6OfvRzrUXHxlJrHME0+Lblx37PBLxGDxc5W8qfZFJpej8 Dk3LUMga8laR9CRghbALoTV3UThUSMqk1cVwTY99KQIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAKU8XIS6 R/R3Hg6ae5p0i4iUJURq+sDVMX9RGB3Ge5V8oKKglIQGaY03leem65pqICL6mdgX/Px21JoaKVAA 8XITLFVEFHL6BfZ/eePnzNi93rnaNe7hLUwLdGztdYmqN8zF0DOCybL1M1JDB3cTr0XwHJwxziSf oEeENGNETykjMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBH0mciJ6TfW1XR T7HSAm4iMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA4MDkyMDEyMzMyM1owIwYJKoZIhvcNAQkEMRYEFAFZOqzcrxz/xRyWOV4c0FgdYqEN MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQR9JnIiek31tV0U+x0gJuIjCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQR9JnIiek31tV0U+x0gJuIjANBgkqhkiG9w0B AQEFAASBgKSx4qT2tRYDG3HN3IDKphrOfS+Hm2B83FePXZSpRyZZk8OaodLcWoGs6S0An4/INx7J 4NcdcgIJNMHxeo7QMK+xAtUe4Ynt38QVWhsBU4O6lJxiJ95+WL7PYmDOhmouPmdenFwRvzKnxHpY yAIa4O5dpISGKdxQjnlGmDSVfewIAAAAAAAA --Apple-Mail-16-941150426-- From unknown Fri Aug 15 15:34:30 2025 X-Loop: don@donarmstrong.com Subject: bug#1009: Carbon: posix-file-name-to-mac Reply-To: YAMAMOTO Mitsuharu , 1009@debbugs.gnu.org Resent-From: YAMAMOTO Mitsuharu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: don@donarmstrong.com Resent-Date: Mon, 22 Sep 2008 01:35:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1009 X-Emacs-PR-Package: emacs22 X-Emacs-PR-Keywords: Received: via spool by 1009-submit@emacsbugs.donarmstrong.com id=B1009.122204671830776 (code B ref 1009); Mon, 22 Sep 2008 01:35:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.5 required=4.0 tests=AWL,BAYES_00,FOURLA,GMAIL, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1009) by emacsbugs.donarmstrong.com; 22 Sep 2008 01:25:17 +0000 Received: from mathmail.math.s.chiba-u.ac.jp (mathmail.math.s.chiba-u.ac.jp [133.82.132.2]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8M1PEr6030617 for <1009@emacsbugs.donarmstrong.com>; Sun, 21 Sep 2008 18:25:15 -0700 Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 5AD9A2C40; Mon, 22 Sep 2008 10:25:12 +0900 (JST) Date: Mon, 22 Sep 2008 10:25:12 +0900 Message-ID: From: YAMAMOTO Mitsuharu To: David Reitter , 1009@debbugs.gnu.org In-Reply-To: <702E333A-FA7D-4ECE-A116-3DA9C3A64F8E@gmail.com> References: <702E333A-FA7D-4ECE-A116-3DA9C3A64F8E@gmail.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 =?UTF-8?Q?(Shij=C5=8D)?= APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) Organization: Faculty of Science, Chiba University MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII >>>>> On Sat, 20 Sep 2008 08:33:22 -0400, David Reitter said: > (posix-file-name-to-mac "~emacs/asd") > (posix-file-name-to-mac "/tmp/") > will crash a 22 branch Carbon Emacs. > A fix is below - it disables ~emacs and /tmp expansion when getpwnam > or get_temp_dir_name return NULL, which they seem to do. (OS X has > /tmp, so I'm not sure if the code isn't leftover from MacOS and > stopped working at some point.) Thanks. Maybe posix-file-name-to-mac and mac-file-name-to-posix should have been made Mac OS Classic only. Actually, they have already been removed from my local tree, because they are using some functions that are not available on 64-bit environment. Do you have some use cases of them on Mac OS X? I'm not sure if changes to the EMACS_22_BASE branch is still allowed. Please apply your patch if so. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp From unknown Fri Aug 15 15:34:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: David Reitter Subject: bug#1009: closed (Re: bug#1009: Carbon: posix-file-name-to-mac) Message-ID: References: <702E333A-FA7D-4ECE-A116-3DA9C3A64F8E@gmail.com> X-Gnu-PR-Message: they-closed 1009 X-Gnu-PR-Package: emacs22 Reply-To: 1009@debbugs.gnu.org Date: Thu, 10 Mar 2011 06:48:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1299739681-24644-1" This is a multi-part message in MIME format... ------------=_1299739681-24644-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #1009: Carbon: posix-file-name-to-mac which was filed against the emacs22 package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 1009@debbugs.gnu.org. --=20 1009: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1009 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1299739681-24644-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 1009-done) by debbugs.gnu.org; 10 Mar 2011 06:47:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxZec-0006OS-JD for submit@debbugs.gnu.org; Thu, 10 Mar 2011 01:47:22 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxZea-0006OF-Qe for 1009-done@debbugs.gnu.org; Thu, 10 Mar 2011 01:47:21 -0500 Received: from localhost ([127.0.0.1]:60257) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxZeV-0002ox-Mr; Thu, 10 Mar 2011 01:47:15 -0500 From: Glenn Morris To: 1009-done@debbugs.gnu.org Subject: Re: bug#1009: Carbon: posix-file-name-to-mac References: <702E333A-FA7D-4ECE-A116-3DA9C3A64F8E@gmail.com> X-Spook: STARLAN Honduras bce Security Council Maple Cohiba Etacs X-Ran: N4}@hau1uI6{g@}OKJ"R+=jjI8^Nbc$0vxDcaON.NWXTt|MHf=nY"{CGO!&DmtO_`B|~$O X-Hue: white X-Attribution: GM Date: Thu, 10 Mar 2011 01:47:15 -0500 In-Reply-To: (YAMAMOTO Mitsuharu's message of "Mon, 22 Sep 2008 10:25:12 +0900") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 1009-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Thanks for the report. Emacs 22 is very old and has not been supported for some time. The latest version is 23.3. Please open new reports for any issues you have with the new version. ------------=_1299739681-24644-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit >From david.reitter@gmail.com Sat Sep 20 05:33:39 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.6 required=4.0 tests=BAYES_00,FOURLA, IMPRONONCABLE_1,MURPHY_WRONG_WORD1,MURPHY_WRONG_WORD2,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 20 Sep 2008 12:33:39 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m8KCXZhh010900 for ; Sat, 20 Sep 2008 05:33:36 -0700 Received: from mx10.gnu.org ([199.232.76.166]:53705) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kh1cc-0005II-V7 for emacs-pretest-bug@gnu.org; Sat, 20 Sep 2008 08:31:35 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kh1eU-0001IB-TU for emacs-pretest-bug@gnu.org; Sat, 20 Sep 2008 08:33:34 -0400 Received: from ug-out-1314.google.com ([66.249.92.170]:44307) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kh1eU-0001Ht-EK for emacs-pretest-bug@gnu.org; Sat, 20 Sep 2008 08:33:30 -0400 Received: by ug-out-1314.google.com with SMTP id z36so1504034uge.17 for ; Sat, 20 Sep 2008 05:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:mime-version:subject:date:x-mailer; bh=hLVNgSaoGUX6KSm+2BwViVRj3imhjzZuIu9GFNcI3Po=; b=TD65IePAmBnI+EQpSBBw/3iPp7ozOOgErZ/b1o8b/JJwzFz45J8jFTB1GD2rvfL+ZE qt3f/nZ21cLPf/TneEv1Fqdi1Ojbx/IAMNqEm3yBYhERc1pwLXteajRV5G+0yP4NcguL ZGqqUUlpN8QKGeE6sCeKui4Y2ygu8cGnKK2b8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:mime-version:subject:date:x-mailer; b=qvm+d3G5hdCqy+gXx4t+Cxm1qkurVNEL6uktGUQqP+s0sJS2vJrpDqX18WuTnSH+t7 wOcEe9SZpxTE64QFEe9sEQXwf9nHrSdEtEqhmJrSQgw/qilcNOjwagfJHLP8YqBRxPz5 UR12e4fIaqUS0cy+O1wy12JSwVpj1tiP7Cm6g= Received: by 10.66.233.14 with SMTP id f14mr1193006ugh.12.1221914006412; Sat, 20 Sep 2008 05:33:26 -0700 (PDT) Received: from ?10.0.1.3? ( [151.201.37.141]) by mx.google.com with ESMTPS id 29sm575077uga.26.2008.09.20.05.33.24 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 20 Sep 2008 05:33:25 -0700 (PDT) Message-Id: <702E333A-FA7D-4ECE-A116-3DA9C3A64F8E@gmail.com> From: David Reitter To: emacs-pretest-bug@gnu.org Content-Type: multipart/signed; boundary=Apple-Mail-16-941150426; micalg=sha1; protocol="application/pkcs7-signature" Mime-Version: 1.0 (Apple Message framework v929.2) Subject: Carbon: posix-file-name-to-mac Date: Sat, 20 Sep 2008 08:33:22 -0400 X-Mailer: Apple Mail (2.929.2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) --Apple-Mail-16-941150426 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit (posix-file-name-to-mac "~emacs/asd") (posix-file-name-to-mac "/tmp/") will crash a 22 branch Carbon Emacs. A fix is below - it disables ~emacs and /tmp expansion when getpwnam or get_temp_dir_name return NULL, which they seem to do. (OS X has /tmp, so I'm not sure if the code isn't leftover from MacOS and stopped working at some point.) - D Index: mac.c =================================================================== RCS file: /sources/emacs/emacs/src/Attic/mac.c,v retrieving revision 1.77.2.10 diff -c -r1.77.2.10 mac.c *** mac.c 29 Aug 2008 08:18:07 -0000 1.77.2.10 --- mac.c 20 Sep 2008 12:29:24 -0000 *************** *** 214,237 **** if (strncmp (p, "~emacs/", 7) == 0) { struct passwd *pw = getpwnam ("emacs"); ! p += 7; ! if (strlen (pw->pw_dir) + strlen (p) > MAXPATHLEN) ! return 0; ! strcpy (expanded_pathname, pw->pw_dir); ! strcat (expanded_pathname, p); ! p = expanded_pathname; ! /* now p points to the pathname with emacs dir prefix */ } else if (strncmp (p, "/tmp/", 5) == 0) { char *t = get_temp_dir_name (); ! p += 5; ! if (strlen (t) + strlen (p) > MAXPATHLEN) ! return 0; ! strcpy (expanded_pathname, t); ! strcat (expanded_pathname, p); ! p = expanded_pathname; ! /* now p points to the pathname with emacs dir prefix */ } else if (*p != '/') /* relative pathname */ strcat (mfn, ":"); --- 215,244 ---- if (strncmp (p, "~emacs/", 7) == 0) { struct passwd *pw = getpwnam ("emacs"); ! if (pw != NULL) ! { ! p += 7; ! if (strlen (pw->pw_dir) + strlen (p) > MAXPATHLEN) ! return 0; ! strcpy (expanded_pathname, pw->pw_dir); ! strcat (expanded_pathname, p); ! p = expanded_pathname; ! /* now p points to the pathname with emacs dir prefix */ ! } } else if (strncmp (p, "/tmp/", 5) == 0) { char *t = get_temp_dir_name (); ! if (t != NULL) ! { ! p += 5; ! if (strlen (t) + strlen (p) > MAXPATHLEN) ! return 0; ! strcpy (expanded_pathname, t); ! strcat (expanded_pathname, p); ! p = expanded_pathname; ! /* now p points to the pathname with emacs dir prefix */ ! } } else if (*p != '/') /* relative pathname */ strcat (mfn, ":"); --Apple-Mail-16-941150426 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIFxDCCAn0w ggHmoAMCAQICEEfSZyInpN9bVdFPsdICbiIwDQYJKoZIhvcNAQEFBQAwYjELMAkGA1UEBhMCWkEx JTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAqBgNVBAMTI1RoYXd0ZSBQ ZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMB4XDTA3MTIwOTIzMDM0OFoXDTA4MTIwODIzMDM0 OFowYjEQMA4GA1UEBBMHUmVpdHRlcjEOMAwGA1UEKhMFRGF2aWQxFjAUBgNVBAMTDURhdmlkIFJl aXR0ZXIxJjAkBgkqhkiG9w0BCQEWF2RhdmlkLnJlaXR0ZXJAZ21haWwuY29tMIGfMA0GCSqGSIb3 DQEBAQUAA4GNADCBiQKBgQDIS4kZGULD+CxprkxDnEccAnZ2GQQxfn55aiAPoy5kJ+uLhelaZP4p lgx3Vq8xYK1bjsLepGYp8qzVlHsyQPb6OfvRzrUXHxlJrHME0+Lblx37PBLxGDxc5W8qfZFJpej8 Dk3LUMga8laR9CRghbALoTV3UThUSMqk1cVwTY99KQIDAQABozQwMjAiBgNVHREEGzAZgRdkYXZp ZC5yZWl0dGVyQGdtYWlsLmNvbTAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBQUAA4GBAKU8XIS6 R/R3Hg6ae5p0i4iUJURq+sDVMX9RGB3Ge5V8oKKglIQGaY03leem65pqICL6mdgX/Px21JoaKVAA 8XITLFVEFHL6BfZ/eePnzNi93rnaNe7hLUwLdGztdYmqN8zF0DOCybL1M1JDB3cTr0XwHJwxziSf oEeENGNETykjMIIDPzCCAqigAwIBAgIBDTANBgkqhkiG9w0BAQUFADCB0TELMAkGA1UEBhMCWkEx FTATBgNVBAgTDFdlc3Rlcm4gQ2FwZTESMBAGA1UEBxMJQ2FwZSBUb3duMRowGAYDVQQKExFUaGF3 dGUgQ29uc3VsdGluZzEoMCYGA1UECxMfQ2VydGlmaWNhdGlvbiBTZXJ2aWNlcyBEaXZpc2lvbjEk MCIGA1UEAxMbVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIENBMSswKQYJKoZIhvcNAQkBFhxwZXJz b25hbC1mcmVlbWFpbEB0aGF3dGUuY29tMB4XDTAzMDcxNzAwMDAwMFoXDTEzMDcxNjIzNTk1OVow YjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4xLDAq BgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBMIGfMA0GCSqGSIb3DQEB AQUAA4GNADCBiQKBgQDEpjxVc1X7TrnKmVoeaMB1BHCd3+n/ox7svc31W/Iadr1/DDph8r9RzgHU 5VAKMNcCY1osiRVwjt3J8CuFWqo/cVbLrzwLB+fxH5E2JCoTzyvV84J3PQO+K/67GD4Hv0CAAmTX p6a7n2XRxSpUhQ9IBH+nttE8YQRAHmQZcmC3+wIDAQABo4GUMIGRMBIGA1UdEwEB/wQIMAYBAf8C AQAwQwYDVR0fBDwwOjA4oDagNIYyaHR0cDovL2NybC50aGF3dGUuY29tL1RoYXd0ZVBlcnNvbmFs RnJlZW1haWxDQS5jcmwwCwYDVR0PBAQDAgEGMCkGA1UdEQQiMCCkHjAcMRowGAYDVQQDExFQcml2 YXRlTGFiZWwyLTEzODANBgkqhkiG9w0BAQUFAAOBgQBIjNFQg+oLLswNo2asZw9/r6y+whehQ5aU nX9MIbj4Nh+qLZ82L8D0HFAgk3A8/a3hYWLD2ToZfoSxmRsAxRoLgnSeJVCUYsfbJ3FXJY3dqZw5 jowgT2Vfldr394fWxghOrvbqNOUQGls1TXfjViF4gtwhGTXeJLHTHUb/XV9lTzGCAo8wggKLAgEB MHYwYjELMAkGA1UEBhMCWkExJTAjBgNVBAoTHFRoYXd0ZSBDb25zdWx0aW5nIChQdHkpIEx0ZC4x LDAqBgNVBAMTI1RoYXd0ZSBQZXJzb25hbCBGcmVlbWFpbCBJc3N1aW5nIENBAhBH0mciJ6TfW1XR T7HSAm4iMAkGBSsOAwIaBQCgggFvMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcN AQkFMQ8XDTA4MDkyMDEyMzMyM1owIwYJKoZIhvcNAQkEMRYEFAFZOqzcrxz/xRyWOV4c0FgdYqEN MIGFBgkrBgEEAYI3EAQxeDB2MGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3Vs dGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWlu ZyBDQQIQR9JnIiek31tV0U+x0gJuIjCBhwYLKoZIhvcNAQkQAgsxeKB2MGIxCzAJBgNVBAYTAlpB MSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYDVQQDEyNUaGF3dGUg UGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQQIQR9JnIiek31tV0U+x0gJuIjANBgkqhkiG9w0B AQEFAASBgKSx4qT2tRYDG3HN3IDKphrOfS+Hm2B83FePXZSpRyZZk8OaodLcWoGs6S0An4/INx7J 4NcdcgIJNMHxeo7QMK+xAtUe4Ynt38QVWhsBU4O6lJxiJ95+WL7PYmDOhmouPmdenFwRvzKnxHpY yAIa4O5dpISGKdxQjnlGmDSVfewIAAAAAAAA --Apple-Mail-16-941150426-- ------------=_1299739681-24644-1--