Subject: Re: 24.0.91; gdb-create-source-file-list and the documented behaviour

From: Chong Yidong <[email-masked]>
Date: Mon, 26 Dec 2011 16:25:45 +0800

> Don't we need to conditionalize gdb-get-source-file-list call ?  Also
> "ready" mode line update is done in that function. I guess that should
> be moved to gdb-get-source-file ?

IIUC, this was the bug that Nick was fixing in the following checkin, so
I'm closing it.  If it's not, please reopen.  Thanks.

revno: 106530
committer: Nick Roberts <[email-masked]>
branch nick: trunk
timestamp: Sun 2011-11-27 21:33:25 +1300
message:
  progmodes/gdb-mi.el (gdb-init-1): Condition execution of
  gdb-get-source-file-list on gdb-create-source-file-list.

=== modified file 'lisp/progmodes/gdb-mi.el'
*** lisp/progmodes/gdb-mi.el	2011-11-20 19:35:27 +0000
--- lisp/progmodes/gdb-mi.el	2011-11-27 08:33:25 +0000
***************
*** 873,885 ****
      (gdb-input (list "-gdb-set non-stop 1" 'gdb-non-stop-handler)))
  
    ;; find source file and compilation directory here
-   (gdb-input
-                                         ; Needs GDB 6.2 onwards.
-    (list "-file-list-exec-source-files" 'gdb-get-source-file-list))
    (if gdb-create-source-file-list
        (gdb-input
                                          ; Needs GDB 6.0 onwards.
!        (list "-file-list-exec-source-file" 'gdb-get-source-file)))
    (gdb-input
     (list "-gdb-show prompt" 'gdb-get-prompt)))
  
--- 873,885 ----
      (gdb-input (list "-gdb-set non-stop 1" 'gdb-non-stop-handler)))
  
    ;; find source file and compilation directory here
    (if gdb-create-source-file-list
        (gdb-input
+                                         ; Needs GDB 6.2 onwards.
+        (list "-file-list-exec-source-files" 'gdb-get-source-file-list)))
+   (gdb-input
                                          ; Needs GDB 6.0 onwards.
!    (list "-file-list-exec-source-file" 'gdb-get-source-file))
    (gdb-input
     (list "-gdb-show prompt" 'gdb-get-prompt)))