From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 16 07:30:27 2011 Received: (at submit) by debbugs.gnu.org; 16 Nov 2011 12:30:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQedD-0000AB-Ea for submit@debbugs.gnu.org; Wed, 16 Nov 2011 07:30:27 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQedA-0008Q8-D3 for submit@debbugs.gnu.org; Wed, 16 Nov 2011 07:30:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQecL-00076s-An for submit@debbugs.gnu.org; Wed, 16 Nov 2011 07:29:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:34582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQecL-00076o-9P for submit@debbugs.gnu.org; Wed, 16 Nov 2011 07:29:29 -0500 Received: from eggs.gnu.org ([140.186.70.92]:36782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQecK-0002BC-Bh for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 07:29:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQecJ-00076K-GN for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 07:29:28 -0500 Received: from mail-iy0-f169.google.com ([209.85.210.169]:46247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQecJ-00076G-DM for bug-gnu-emacs@gnu.org; Wed, 16 Nov 2011 07:29:27 -0500 Received: by iaek3 with SMTP id k3so648319iae.0 for ; Wed, 16 Nov 2011 04:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; bh=6gEGS7Edu9Dzk7E/lFgDW3fARxEtXpl2onVvTLizQHo=; b=M3EhNlZf6ZdtI2Vpp1Uq0nVe0LxkQIHLANjREs8jOLqAo8ydo5inLn1VMGpsY4XmcG bm9cNRjEYE1muGkERz+9gsqhKTdO+DQ83hpgINdCml0l5mgX05j5vzZ1F1z1eJ9YDb/i JRXHZi6Srh/ylfVp+e0QDVbgH+Ft5ywGxSX30= Received: by 10.42.161.70 with SMTP id s6mr31609191icx.40.1321446566727; Wed, 16 Nov 2011 04:29:26 -0800 (PST) Received: from ubuntu ([119.255.41.67]) by mx.google.com with ESMTPS id bu33sm43883082ibb.11.2011.11.16.04.29.23 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Nov 2011 04:29:26 -0800 (PST) From: Leo To: bug-gnu-emacs@gnu.org Subject: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! X-Debbugs-CC: Lars Magne Ingebrigtsen Date: Wed, 16 Nov 2011 20:29:12 +0800 Message-ID: <87y5vg5jzb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) I am seeing this warning in Gnus. ,---- | Making font-lock-mode-hook buffer-local while locally let-bound! `---- which seems to relate to line 602 in mm-view.el 601: ;; Disable support modes, e.g., jit-lock, lazy-lock, etc. 602: (font-lock-mode-hook nil) 603: (font-lock-support-mode nil) Leo From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 16 09:50:32 2011 Received: (at 10063) by debbugs.gnu.org; 16 Nov 2011 14:50:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQgop-0003jc-TB for submit@debbugs.gnu.org; Wed, 16 Nov 2011 09:50:32 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQgon-0003jI-HK for 10063@debbugs.gnu.org; Wed, 16 Nov 2011 09:50:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AkwGAFLMw05MCqs//2dsb2JhbABDp1aCIIEGgXIBAQQBViMFCws0EhQYDSSIFbkdihcEiBSZcIRK X-IronPort-AV: E=Sophos;i="4.69,521,1315195200"; d="scan'208";a="148209066" Received: from 76-10-171-63.dsl.teksavvy.com (HELO pastel.home) ([76.10.171.63]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 16 Nov 2011 09:49:38 -0500 Received: by pastel.home (Postfix, from userid 20848) id E07115936A; Wed, 16 Nov 2011 09:49:37 -0500 (EST) From: Stefan Monnier To: Leo Subject: Re: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! Message-ID: References: <87y5vg5jzb.fsf@gmail.com> Date: Wed, 16 Nov 2011 09:49:37 -0500 In-Reply-To: <87y5vg5jzb.fsf@gmail.com> (Leo's message of "Wed, 16 Nov 2011 20:29:12 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 10063 Cc: Lars Magne Ingebrigtsen , 10063@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) > I am seeing this warning in Gnus. > ,---- > | Making font-lock-mode-hook buffer-local while locally let-bound! > `---- > which seems to relate to line 602 in mm-view.el > 601: ;; Disable support modes, e.g., jit-lock, lazy-lock, etc. > 602: (font-lock-mode-hook nil) > 603: (font-lock-support-mode nil) BTW, these should not be let-bindings but buffer-local bindings. Also the mode-setting and font-locking should be wrapped in with-demoted-errors so that errors in them don't prevent showing the attachment's content. Finally, font-lock-maximum-size should not be set to nil: there is nothing special about font-locking attachments that makes it more desirable to font-lock them entirely than normal files. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 21 14:39:36 2011 Received: (at 10063) by debbugs.gnu.org; 21 Nov 2011 19:39:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSZiG-0006aP-3W for submit@debbugs.gnu.org; Mon, 21 Nov 2011 14:39:36 -0500 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSZiB-0006aF-1O for 10063@debbugs.gnu.org; Mon, 21 Nov 2011 14:39:31 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1RSZgn-00009K-Px; Mon, 21 Nov 2011 20:38:02 +0100 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! In-Reply-To: (Stefan Monnier's message of "Wed, 16 Nov 2011 09:49:37 -0500") Date: Mon, 21 Nov 2011 20:37:36 +0100 Message-ID: References: <87y5vg5jzb.fsf@gmail.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.91 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEXw2dFpUU9RKjCbgn4d DxOftOQAAAACWklEQVQ4jVWU7bkqIQyEo1jAwlKAhBTAVwGSTf813QGP91HcP8u7CZNJkE4nZjTs IGcX2ZWSl71lJbAHuOjhE9ms/gOeFeAB4G4HWb55r84WeNWQ6S4XkTtIffdBd0R6tfV1nAAFIHvm HZGuYS8cbHSTSWZnS36DNoc9ARTnWDHjllbEpKgPSIUcups98enpA8CJ4IcVgAsCNsgBQAfV42ZE FF8fMBtSZRxZ3AIDAsYGVtXpMKrFQSmhuF4t6zpEXRZbAlEbYZvxSyyWo2txAfuA8AY2hnhdYKn6 gIBXL2q8AUJ6DxyST9FUNBqfG0hxC7AHQF8k6Owb2NN5/x88JHF3G2h2a5+DT3xQs3D28QYFICRO sPygkU6URNAAA1eqhFQA9xl6F109C7Adrc4eNBRXz9IUcgUKvpdbiSyQRXn9gNZ7RAUA8+vr3mvv 0JCEphz0m6r7aEsuu/LeKI7gwBJoV+2kz1uj9cYppCRa6tJfMUmlCeSuyvEIlxqX345m65hEtxzZ q9z+/H75diLx37ZqeRh6pUR1taB8AGu5a9qgBYDX290UANxk0eMkSQHyHPagagHYGi+MFOfOAOxX IoQVGj4/AUbSacnxlhVZCt1mcmt8xE5U7xvvSgJsiJAsJLliWn7donNNohoE//p4O0emOPtYsr+X 1exxT+u6P9/rrtlHChMNy5jEvwXgNdVGwjliroKsicSDSWSRijNSZ3843kAWqMqWE2HqAm8TNzDc PEVbKnmGidt2WansGGaJOROr6fUHeAHcarxM0rPBUQBFBHLhjwa51P4B35mZ6I3PXt8AAAAASUVO RK5CYII= X-Now-Playing: Throwing Muses's _Anthology (2)_: "Red Eyes" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1RSZgn-00009K-Px X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1322509082.10494@SvDChBMExa3tMbW990eTBQ X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 10063 Cc: 10063@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: > BTW, these should not be let-bindings but buffer-local bindings. > > Also the mode-setting and font-locking should be wrapped in > with-demoted-errors so that errors in them don't prevent showing the > attachment's content. > > Finally, font-lock-maximum-size should not be set to nil: there is > nothing special about font-locking attachments that makes it more > desirable to font-lock them entirely than normal files. Ok; done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 21 14:39:15 2011 Received: (at control) by debbugs.gnu.org; 21 Nov 2011 19:39:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSZhy-0006Zx-LG for submit@debbugs.gnu.org; Mon, 21 Nov 2011 14:39:15 -0500 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RSZhv-0006Zp-Tm for control@debbugs.gnu.org; Mon, 21 Nov 2011 14:39:12 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1RSZgc-00008h-Ao for control@debbugs.gnu.org; Mon, 21 Nov 2011 20:37:50 +0100 Date: Mon, 21 Nov 2011 20:37:48 +0100 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #10063 X-MailScanner-ID: 1RSZgc-00008h-Ao X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1322509070.92003@Fh3rt/zAjofwFXN2VR+3og X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 10063 fixed close 10063 24.1 From unknown Mon Aug 18 00:07:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Dec 2011 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 26 15:04:18 2011 Received: (at control) by debbugs.gnu.org; 26 Dec 2011 20:04:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfGmQ-0000fr-Am for submit@debbugs.gnu.org; Mon, 26 Dec 2011 15:04:18 -0500 Received: from mx18.lb01.inode.at ([62.99.145.20] helo=mx.inode.at) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfGmN-0000fi-FO for control@debbugs.gnu.org; Mon, 26 Dec 2011 15:04:16 -0500 Received: from [85.127.80.57] (port=5046 helo=iznogoud.viz) by smartmx-18.inode.at with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1RfGjs-0000YI-5j for control@debbugs.gnu.org; Mon, 26 Dec 2011 21:01:40 +0100 Received: from wolfgang by iznogoud.viz with local (Exim 4.77 (FreeBSD)) (envelope-from ) id 1RfGjq-0000f2-QJ for control@debbugs.gnu.org; Mon, 26 Dec 2011 21:01:38 +0100 From: Wolfgang Jenkner To: control@debbugs.gnu.org Subject: Date: Mon, 26 Dec 2011 21:01:28 +0100 Message-ID: <85fwg714rr.fsf@iznogoud.viz> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.92 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.4 (/) unarchive 10063 tags 10063 - fixed From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 26 15:07:10 2011 Received: (at 10063) by debbugs.gnu.org; 26 Dec 2011 20:07:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfGpC-0000kS-39 for submit@debbugs.gnu.org; Mon, 26 Dec 2011 15:07:10 -0500 Received: from mx12.lb01.inode.at ([62.99.145.14] helo=mx.inode.at) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfGp9-0000kK-Up for 10063@debbugs.gnu.org; Mon, 26 Dec 2011 15:07:08 -0500 Received: from [85.127.80.57] (port=13206 helo=iznogoud.viz) by smartmx-12.inode.at with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1RfGme-0006kz-C7; Mon, 26 Dec 2011 21:04:32 +0100 Received: from wolfgang by iznogoud.viz with local (Exim 4.77 (FreeBSD)) (envelope-from ) id 1RfGma-0000f5-CS; Mon, 26 Dec 2011 21:04:28 +0100 From: Wolfgang Jenkner To: Stefan Monnier Subject: Re: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! Date: Mon, 26 Dec 2011 21:02:52 +0100 References: <87y5vg5jzb.fsf@gmail.com> Message-ID: <8539c714mr.fsf@iznogoud.viz> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.92 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 10063 Cc: Lars Magne Ingebrigtsen , Katsumi Yamaoka , 10063@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Tags: patch Stefan Monnier writes: >> 601: ;; Disable support modes, e.g., jit-lock, lazy-lock, etc. >> 602: (font-lock-mode-hook nil) >> 603: (font-lock-support-mode nil) > > BTW, these should not be let-bindings but buffer-local bindings. There's usually a major mode being called a few lines later, so kill-all-local-variables has already undone those settings before font-locking happens. Here's more context from mm-view.el (mm-display-inline-fontify): #+begin_src emacs-lisp (let ((font-lock-verbose nil)) ;; Disable support modes, e.g., jit-lock, lazy-lock, etc. (set (make-local-variable 'font-lock-mode-hook) nil) (set (make-local-variable 'font-lock-support-mode) nil) ... (with-demoted-errors (if mode (funcall mode) ...) ...)) #+end_src By the way, if you were viewing this in a Gnus article buffer after having set org-src-fontify-natively to t such a snippet used to be font-locked like in emacs-lisp mode but now it isn't, for the reason just given. The first patch below is relative to emacs bzr trunk and the second patch relative to gnus git master (No Gnus). 2011-12-26 Wolfgang Jenkner * font-lock.el (font-lock-support-mode): Mark it permanent-local. (Bug#10063) 2011-12-26 Wolfgang Jenkner * mm-view.el (mm-display-inline-fontify): Scrap `font-lock-mode-hook'. The 2005-09-06 entry gives disabling support modes as the only reason for caring about that variable, but already in NEWS.19 the advice is to use `font-lock-support-mode' instead as hook for support functions. === modified file 'lisp/font-lock.el' --- lisp/font-lock.el 2011-11-20 07:30:16 +0000 +++ lisp/font-lock.el 2011-12-26 05:03:58 +0000 @@ -887,6 +887,8 @@ :version "21.1" :group 'font-lock) +(put 'font-lock-support-mode 'permanent-local t) + (defvar fast-lock-mode) (defvar lazy-lock-mode) (defvar jit-lock-mode) -- >8 -- Subject: [PATCH] Scrap font-lock-mode-hook. --- lisp/mm-view.el | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/lisp/mm-view.el b/lisp/mm-view.el index 854ca34..0b3db15 100644 --- a/lisp/mm-view.el +++ b/lisp/mm-view.el @@ -566,8 +566,6 @@ (face-property 'default prop) (current-buffer)))) (delete-region ,(point-min-marker) ,(point-max-marker))))))))) -;; Shut up byte-compiler. -(defvar font-lock-mode-hook) (defun mm-display-inline-fontify (handle &optional mode) "Insert HANDLE inline fontifying with MODE. If MODE is not set, try to find mode automatically." @@ -602,7 +600,6 @@ If MODE is not set, try to find mode automatically." ;; I find font-lock a bit too verbose. (let ((font-lock-verbose nil)) ;; Disable support modes, e.g., jit-lock, lazy-lock, etc. - (set (make-local-variable 'font-lock-mode-hook) nil) (set (make-local-variable 'font-lock-support-mode) nil) (setq buffer-file-name (mm-handle-filename handle)) (set (make-local-variable 'enable-local-variables) nil) -- 1.7.8 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 26 18:39:47 2011 Received: (at 10063) by debbugs.gnu.org; 26 Dec 2011 23:39:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfK8x-0000Ae-84 for submit@debbugs.gnu.org; Mon, 26 Dec 2011 18:39:47 -0500 Received: from orlando.hostforweb.net ([216.246.45.90]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfK8u-0000AV-LL for 10063@debbugs.gnu.org; Mon, 26 Dec 2011 18:39:45 -0500 Received: from localhost ([127.0.0.1]:36498) by orlando.hostforweb.net with smtp (Exim 4.69) (envelope-from ) id 1RfK6M-0002vu-Tq; Mon, 26 Dec 2011 17:37:07 -0600 Date: Tue, 27 Dec 2011 08:36:53 +0900 Message-ID: From: Katsumi Yamaoka To: Wolfgang Jenkner Subject: Re: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! References: <87y5vg5jzb.fsf@gmail.com> <8539c714mr.fsf@iznogoud.viz> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.92 (i686-pc-cygwin) Cancel-Lock: sha1:Zmsf/gUVu5pCSmWXWFNoGYmfeMk= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 10063 Cc: Lars Magne Ingebrigtsen , 10063@debbugs.gnu.org, Stefan Monnier , Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Wolfgang Jenkner wrote: [...] > 2011-12-26 Wolfgang Jenkner > * mm-view.el (mm-display-inline-fontify): Scrap `font-lock-mode-hook'. [...] > --- a/lisp/mm-view.el > +++ b/lisp/mm-view.el [...] > -;; Shut up byte-compiler. > -(defvar font-lock-mode-hook) Why it is defvar'd here is that it no longer exists in Emacs but still exists in XEmacs. XEmacs people use it to run some support modes `fast-lock', `lazy-lock', etc. as Emacs people use `font-lock-support-mode'. > ;; Disable support modes, e.g., jit-lock, lazy-lock, etc. > - (set (make-local-variable 'font-lock-mode-hook) nil) Gnus should run with not only old Emacsen but also XEmacsen[1], so please don't scrap it. (when (featurep 'xemacs) ...? [1] (info "(gnus)Emacsen") From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 11:29:31 2011 Received: (at 10063) by debbugs.gnu.org; 27 Dec 2011 16:29:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfZu5-0007WX-Hw for submit@debbugs.gnu.org; Tue, 27 Dec 2011 11:29:30 -0500 Received: from mx05.lb01.inode.at ([62.99.145.5] helo=mx.inode.at) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfZu2-0007WN-Ps for 10063@debbugs.gnu.org; Tue, 27 Dec 2011 11:29:28 -0500 Received: from [85.127.82.5] (port=15764 helo=iznogoud.viz) by smartmx-05.inode.at with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1RfZrS-00037N-GT; Tue, 27 Dec 2011 17:26:46 +0100 Received: from wolfgang by iznogoud.viz with local (Exim 4.77 (FreeBSD)) (envelope-from ) id 1RfZrO-0000ko-WF; Tue, 27 Dec 2011 17:26:43 +0100 From: Wolfgang Jenkner To: Katsumi Yamaoka Subject: Re: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! References: <87y5vg5jzb.fsf@gmail.com> <8539c714mr.fsf@iznogoud.viz> Date: Tue, 27 Dec 2011 17:26:42 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 27 Dec 2011 08:36:53 +0900") Message-ID: <85lipy6kvx.fsf@iznogoud.viz> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.92 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 10063 Cc: Lars Magne Ingebrigtsen , 10063@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Katsumi Yamaoka writes: > Wolfgang Jenkner wrote: >> -(defvar font-lock-mode-hook) > > Why it is defvar'd here is that it no longer exists in Emacs but > still exists in XEmacs. Well, it doesn't exist anymore but it still works (and is used, e.g., in c-mode) in Emacs as well (as a consequence of font-lock-mode being defined via define-minor-mode). > Gnus should run with not only old Emacsen but also XEmacsen[1], > so please don't scrap it. (when (featurep 'xemacs) ...? There's also the problem that setting (or binding) font-lock-mode-hook to nil prevents other (perhaps essential) functions on this hook from running as well. So, here "to scrap" really means "to honour" ;-) Thank you for the explanation! Wolfgang From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 14:51:33 2011 Received: (at 10063) by debbugs.gnu.org; 27 Dec 2011 19:51:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rfd3d-0003nD-7V for submit@debbugs.gnu.org; Tue, 27 Dec 2011 14:51:33 -0500 Received: from mx11.lb01.inode.at ([62.99.145.13] helo=mx.inode.at) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Rfd3a-0003n3-F4 for 10063@debbugs.gnu.org; Tue, 27 Dec 2011 14:51:31 -0500 Received: from [85.127.87.3] (port=9517 helo=iznogoud.viz) by smartmx-11.inode.at with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1Rfd0z-0006GT-9Z; Tue, 27 Dec 2011 20:48:49 +0100 Received: from wolfgang by iznogoud.viz with local (Exim 4.77 (FreeBSD)) (envelope-from ) id 1Rfd0v-0000uh-L5; Tue, 27 Dec 2011 20:48:45 +0100 From: Wolfgang Jenkner To: Katsumi Yamaoka Subject: Re: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! References: <87y5vg5jzb.fsf@gmail.com> <8539c714mr.fsf@iznogoud.viz> Date: Tue, 27 Dec 2011 20:48:45 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 27 Dec 2011 08:36:53 +0900") Message-ID: <85wr9h6bj6.fsf@iznogoud.viz> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.92 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 10063 Cc: Lars Magne Ingebrigtsen , 10063@debbugs.gnu.org, Stefan Monnier , Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Katsumi Yamaoka writes: > Gnus should run with not only old Emacsen but also XEmacsen[1], > so please don't scrap it. Obviously, my patch for Gnus would work only with a current or future version of Emacs containing my other patch. So, now, I scrap my proposal ;-) Wolfgang From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 17:15:53 2011 Received: (at 10063) by debbugs.gnu.org; 27 Dec 2011 22:15:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RffJJ-00078C-E3 for submit@debbugs.gnu.org; Tue, 27 Dec 2011 17:15:53 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RffJE-00077t-ST; Tue, 27 Dec 2011 17:15:49 -0500 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pBRMCoqG020877; Tue, 27 Dec 2011 17:12:56 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 61CF1665DE; Mon, 26 Dec 2011 20:29:40 -0500 (EST) From: Stefan Monnier To: Katsumi Yamaoka Subject: Re: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! Message-ID: References: <87y5vg5jzb.fsf@gmail.com> <8539c714mr.fsf@iznogoud.viz> Date: Mon, 26 Dec 2011 20:29:40 -0500 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 27 Dec 2011 08:36:53 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.5 X-NAI-Spam-Rules: 2 Rules triggered DATE_IN_PAST_12_24=0.5, RV4084=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4084> : streams <714375> : uri <1035875> X-NAI-Spam-Level: X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 10063 Cc: Lars Magne Ingebrigtsen , Wolfgang Jenkner , 10063@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) > Why it is defvar'd here is that it no longer exists in Emacs but > still exists in XEmacs. XEmacs people use it to run some support > modes `fast-lock', `lazy-lock', etc. as Emacs people use > `font-lock-support-mode'. A note about it (not near the defvar but near the place where you force this var to nil) would be welcome. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 27 21:43:35 2011 Received: (at 10063) by debbugs.gnu.org; 28 Dec 2011 02:43:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfjUN-0005Sc-GD for submit@debbugs.gnu.org; Tue, 27 Dec 2011 21:43:35 -0500 Received: from orlando.hostforweb.net ([216.246.45.90]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RfjUK-0005ST-Bf for 10063@debbugs.gnu.org; Tue, 27 Dec 2011 21:43:33 -0500 Received: from localhost ([127.0.0.1]:40626) by orlando.hostforweb.net with smtp (Exim 4.69) (envelope-from ) id 1RfjRg-0003Pz-MV; Tue, 27 Dec 2011 20:40:49 -0600 Date: Wed, 28 Dec 2011 11:40:35 +0900 Message-ID: From: Katsumi Yamaoka To: Stefan Monnier Subject: Re: bug#10063: 24.0.91; Making font-lock-mode-hook buffer-local while locally let-bound! References: <87y5vg5jzb.fsf@gmail.com> <8539c714mr.fsf@iznogoud.viz> Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.92 (i686-pc-cygwin) Cancel-Lock: sha1:LDbQX6efYItrWG8uvv+q5/kADUk= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 10063 Cc: Lars Magne Ingebrigtsen , Wolfgang Jenkner , 10063@debbugs.gnu.org, Leo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Stefan Monnier wrote: >> Why it is defvar'd here is that it no longer exists in Emacs but >> still exists in XEmacs. XEmacs people use it to run some support >> modes `fast-lock', `lazy-lock', etc. as Emacs people use >> `font-lock-support-mode'. > A note about it (not near the defvar but near the place where you force > this var to nil) would be welcome. Ok. Done. From unknown Mon Aug 18 00:07:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Jan 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator