GNU bug report logs - #10053
Wrong use of minibuffer-completion-table in tmm-add-prompt

Previous Next

Full log

View this message in rfc822 format

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 10053 <at> debbugs.gnu.org
Subject: bug#10053: Wrong use of minibuffer-completion-table in tmm-add-prompt
Date: Wed, 16 Nov 2011 09:27:49 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> But the error is that tmm-add-prompt should not be run in that case.
> It should only be run when you use tmm-prompt or tmm-menubar.
Yes, but when calling `menu-bar-open' with menu-bar-mode==nil, it calls
`x-menu-bar-open' which calls `tmm-menubar' right?
And in my case here `tmm-add-prompt' is called and error occur.
I think it would be safer to check if `minibuffer-completion-table' is a
table or a (a)list, and run the appropriate code to handle both cases.
Though `all-completions' can handle both cases here i think.  

I still not understand the purpose of `tmm-add-prompt', what does it
want to complete here? A list of buffers? Why?

> I see a small error in tmm.el which could explain why tmm-add-prompt
> lingers on minibuffer-setup-hook longer than desired.  I've installed the
> patch below, please see if it helps.
Your patch works with `anything-completion-mode' disabled, but as soon i
turn it on, `tmm-add-prompt' is called and same error occur:

--8<---------------cut here---------------start------------->8---
Debugger entered--Lisp error: (wrong-type-argument listp closure)
  car(closure)
  mapcar(car (closure (t) (&rest args)
[...]

  tmm-add-prompt()
--8<---------------cut here---------------end--------------->8---

`anything-completion-mode' is only using his own
`completing-read-function'.

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.