GNU bug report logs - #10038
[PATCH] tests: avoid rare fp failure in du/move-dir-while-traversing

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nix <nix <at> esperi.org.uk>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] tests: avoid rare fp failure in du/move-dir-while-traversing
Date: Sun, 13 Nov 2011 18:15:10 +0000

du/move-dir-while-traversing: boost the mkdir iteration count yet again.
---
 tests/du/move-dir-while-traversing |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

I just had an FP in du/move-dir-while-traversing, due to the traversal
terminating too soon. My autobuilder is running on a 2.2GHz Nehalem,
with the source tree located on a loopback ext4 filesystem on a tmpfs,
so particularly rapid test execution is understandable.

Patch obvious (I ran 200 trials of this just to avoid having to change
the comment!):

diff --git a/tests/du/move-dir-while-traversing b/tests/du/move-dir-while-traversing
index 322a9a5..d0969fe 100755
--- a/tests/du/move-dir-while-traversing
+++ b/tests/du/move-dir-while-traversing
@@ -66,8 +66,8 @@ long=d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z
 # Five iterations was not enough in 2 of 7 "make -j20 check" runs on a
 # 6/12-core system.  However, using "10", I saw no failure in 20 trials.
 # Using 10 iterations was not enough, either.
-# Using 30, I saw no failure in 200 trials.
-for i in $(seq 30); do
+# Using 50, I saw no failure in 200 trials.
+for i in $(seq 50); do
   mkdir -p $t/3/a/b/c/$i/$long || framework_failure_
 done
 
-- 
1.7.7.2.144.g3624f

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.