From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 13:16:00 2011 Received: (at submit) by debbugs.gnu.org; 13 Nov 2011 18:16:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RPeb2-0006TZ-6H for submit@debbugs.gnu.org; Sun, 13 Nov 2011 13:16:00 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RPeb0-0006TN-6I for submit@debbugs.gnu.org; Sun, 13 Nov 2011 13:15:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RPeaR-00038J-17 for submit@debbugs.gnu.org; Sun, 13 Nov 2011 13:15:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([140.186.70.17]:38496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPeaQ-00038F-Vy for submit@debbugs.gnu.org; Sun, 13 Nov 2011 13:15:22 -0500 Received: from eggs.gnu.org ([140.186.70.92]:42485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPeaQ-00021M-05 for bug-coreutils@gnu.org; Sun, 13 Nov 2011 13:15:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RPeaP-000383-18 for bug-coreutils@gnu.org; Sun, 13 Nov 2011 13:15:21 -0500 Received: from icebox.esperi.org.uk ([81.187.191.129]:46920 helo=mail.esperi.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RPeaO-00037G-Mv for bug-coreutils@gnu.org; Sun, 13 Nov 2011 13:15:20 -0500 Received: from esperi.org.uk (nix@spindle.srvr.nix [192.168.14.15]) by mail.esperi.org.uk (8.14.5/8.14.5) with ESMTP id pADIFB0N020697 for ; Sun, 13 Nov 2011 18:15:11 GMT Received: (from nix@localhost) by esperi.org.uk (8.14.5/8.14.5/Submit) id pADIFBOe017699; Sun, 13 Nov 2011 18:15:11 GMT From: Nix To: bug-coreutils@gnu.org Subject: [PATCH] tests: avoid rare fp failure in du/move-dir-while-traversing Emacs: indefensible, reprehensible, and fully extensible. Date: Sun, 13 Nov 2011 18:15:10 +0000 Message-ID: <87bosf99e9.fsf@spindle.srvr.nix> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC-dcc1-Metrics: spindle 1182; Body=1 Fuz1=1 Fuz2=1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.17 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) du/move-dir-while-traversing: boost the mkdir iteration count yet again. --- tests/du/move-dir-while-traversing | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) I just had an FP in du/move-dir-while-traversing, due to the traversal terminating too soon. My autobuilder is running on a 2.2GHz Nehalem, with the source tree located on a loopback ext4 filesystem on a tmpfs, so particularly rapid test execution is understandable. Patch obvious (I ran 200 trials of this just to avoid having to change the comment!): diff --git a/tests/du/move-dir-while-traversing b/tests/du/move-dir-while-traversing index 322a9a5..d0969fe 100755 --- a/tests/du/move-dir-while-traversing +++ b/tests/du/move-dir-while-traversing @@ -66,8 +66,8 @@ long=d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z # Five iterations was not enough in 2 of 7 "make -j20 check" runs on a # 6/12-core system. However, using "10", I saw no failure in 20 trials. # Using 10 iterations was not enough, either. -# Using 30, I saw no failure in 200 trials. -for i in $(seq 30); do +# Using 50, I saw no failure in 200 trials. +for i in $(seq 50); do mkdir -p $t/3/a/b/c/$i/$long || framework_failure_ done -- 1.7.7.2.144.g3624f From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 14:06:39 2011 Received: (at 10038-done) by debbugs.gnu.org; 13 Nov 2011 19:06:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RPfO2-0007cA-OO for submit@debbugs.gnu.org; Sun, 13 Nov 2011 14:06:38 -0500 Received: from mx.meyering.net ([88.168.87.75]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RPfO0-0007c0-43 for 10038-done@debbugs.gnu.org; Sun, 13 Nov 2011 14:06:37 -0500 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 202AF6006A; Sun, 13 Nov 2011 20:06:06 +0100 (CET) From: Jim Meyering To: Nix Subject: Re: bug#10038: [PATCH] tests: avoid rare fp failure in du/move-dir-while-traversing In-Reply-To: <87bosf99e9.fsf@spindle.srvr.nix> (nix@esperi.org.uk's message of "Sun, 13 Nov 2011 18:15:10 +0000") References: <87bosf99e9.fsf@spindle.srvr.nix> Date: Sun, 13 Nov 2011 20:06:06 +0100 Message-ID: <87r51blu5d.fsf@rho.meyering.net> Lines: 91 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 10038-done Cc: 10038-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Nix wrote: > du/move-dir-while-traversing: boost the mkdir iteration count yet again. > --- > tests/du/move-dir-while-traversing | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > I just had an FP in du/move-dir-while-traversing, due to the traversal > terminating too soon. My autobuilder is running on a 2.2GHz Nehalem, > with the source tree located on a loopback ext4 filesystem on a tmpfs, > so particularly rapid test execution is understandable. > > Patch obvious (I ran 200 trials of this just to avoid having to change > the comment!): > > diff --git a/tests/du/move-dir-while-traversing b/tests/du/move-dir-while-traversing > index 322a9a5..d0969fe 100755 > --- a/tests/du/move-dir-while-traversing > +++ b/tests/du/move-dir-while-traversing > @@ -66,8 +66,8 @@ long=d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z > # Five iterations was not enough in 2 of 7 "make -j20 check" runs on a > # 6/12-core system. However, using "10", I saw no failure in 20 trials. > # Using 10 iterations was not enough, either. > -# Using 30, I saw no failure in 200 trials. > -for i in $(seq 30); do > +# Using 50, I saw no failure in 200 trials. > +for i in $(seq 50); do > mkdir -p $t/3/a/b/c/$i/$long || framework_failure_ > done Thanks. I've applied that and pushed it along with a tiny admin patch. (also tweaked your log message to conform) >From 47052ddbfa04b16d649ae0ecbaacfd3ce1f03c53 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 13 Nov 2011 20:00:08 +0100 Subject: [PATCH 1/2] maint: adjust git hook to allow "copy: ..." on line 1 of commit message * scripts/git-hooks/commit-msg: Add "copy" to the list of valid command-name-like summary line prefixes. --- scripts/git-hooks/commit-msg | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/git-hooks/commit-msg b/scripts/git-hooks/commit-msg index 96d5947..76b829d 100755 --- a/scripts/git-hooks/commit-msg +++ b/scripts/git-hooks/commit-msg @@ -42,7 +42,7 @@ check_msg() test|timeout|touch|tr|true|truncate|tsort|tty|uname|unexpand) ;; uniq|unlink|uptime|users|vdir|wc|who|whoami|yes) ;; # other tags - gnulib|tests|maint|doc|build|scripts) ;; + copy|gnulib|tests|maint|doc|build|scripts) ;; *) echo "invalid first word of summary line: $w"; fail=1;; esac done -- 1.7.8.rc2 >From b8b6dd27a61dce58d6537dfbee65c7428f4ae3cd Mon Sep 17 00:00:00 2001 From: Nix Date: Sun, 13 Nov 2011 18:15:10 +0000 Subject: [PATCH 2/2] tests: avoid rare fp failure in du/move-dir-while-traversing * tests/du/move-dir-while-traversing: Boost the mkdir iteration count yet again. --- tests/du/move-dir-while-traversing | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/du/move-dir-while-traversing b/tests/du/move-dir-while-traversing index 322a9a5..d0969fe 100755 --- a/tests/du/move-dir-while-traversing +++ b/tests/du/move-dir-while-traversing @@ -66,8 +66,8 @@ long=d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z # Five iterations was not enough in 2 of 7 "make -j20 check" runs on a # 6/12-core system. However, using "10", I saw no failure in 20 trials. # Using 10 iterations was not enough, either. -# Using 30, I saw no failure in 200 trials. -for i in $(seq 30); do +# Using 50, I saw no failure in 200 trials. +for i in $(seq 50); do mkdir -p $t/3/a/b/c/$i/$long || framework_failure_ done -- 1.7.8.rc2 From unknown Sun Jun 22 04:14:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 12 Dec 2011 12:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator