GNU bug report logs - #10016
ls -lk is wrong

Previous Next

Full log

Message #26 received at 10016 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Eric Blake <eblake <at> redhat.com>
Cc: Alan Curry <pacman-cu <at> kosh.dhis.org>, 10016 <at> debbugs.gnu.org
Subject: Re: bug#10016: ls -lk is wrong
Date: Fri, 11 Nov 2011 20:24:48 +0100

Eric Blake wrote:

> On 11/11/2011 11:30 AM, Jim Meyering wrote:
>>> +++ b/src/ls.c
>>> @@ -3030,9 +3030,7 @@ gobble_file (char const *name, enum filetype type, ino_t inode,
>>>              {
>>>                char buf[LONGEST_HUMAN_READABLE + 1];
>>>                uintmax_t size = unsigned_file_size (f->stat.st_size);
>>> -              int len = mbswidth (human_readable (size, buf, human_output_opts,
>>> -                                                  1, file_output_block_size),
>>> -                                  0);
>>> +              int len = mbswidth (human_readable (size, buf, 0, 1, 1), 0);
>>
>> I don't like the idea of printing a byte count there when
>> --block-size=... takes effect.  Does anyone else have an opinion?
>
> Are you proposing that --block-size keep the current behavior, and that
> -k no longer be a synonym for --block-size=1k but instead becomes a new
> long option?

Precisely.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.