Subject: Re: Enable to boot from emmc on rockpro64
From: Pierre Langlois <[email-masked]>
To: [email-masked]
Cc: Vagrant Cascadian <[email-masked]>, Pierre Langlois <[email-masked]>
Date: Sat, 31 Jul 2021 12:38:09 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Guix!

Pierre Langlois <[email-masked]> writes:

> [[PGP Signed Part:Undecided]]
> Hi Vagrant,
>
> I just had a break-through with this! See inline.

(snip)

From 055d1d358c55811cafd4c56b919865b75e59d936 Mon Sep 17 00:00:00 2001
From: Pierre Langlois <[email-masked]>
Date: Tue, 27 Jul 2021 20:15:55 +0100
Subject: [PATCH] gnu: u-boot-rockpro64-rk3399: Enable 'set-environment phase.

* gnu/packages/bootloaders.scm (u-boot-rockpro64-rk3399)[arguments]: Run
'set-environment phase after 'unpack instead of non-existent
'patch-rockpro64-config phase.
---
 gnu/packages/bootloaders.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 742992a119..4f7a8853e8 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -931,7 +931,7 @@ to Novena upstream, does not load u-boot.img from the first partition.")
         (substitute-keyword-arguments (package-arguments base)
           ((#:phases phases)
            `(modify-phases ,phases
-              (add-after 'patch-rockpro64-config 'set-environment
+              (add-after 'unpack 'set-environment
                 (lambda* (#:key inputs #:allow-other-keys)
                   (setenv "BL31" (string-append (assoc-ref inputs "firmware")
                                                 "/bl31.elf"))

Given this turned out to be a simple bug-fix, I just pushed it with
adb84ae8ea95a6f956d81fdac0b5c6508024a541

Closing!

Thanks,
Pierre