Subject: Re: [bug#45108] Added emacs-burly
From: Oleg Pykhalov <[email-masked]>
To: rdes <[email-masked]>
Cc: [email-masked]
Date: Tue, 08 Dec 2020 08:01:32 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Thank you for patches.

rdes via Guix-patches via <[email-masked]> writes:

[…]

> Please let me know in the future if this should be multiple emails.

It's a good practice to split an email with multiple patches, which is
described on webpage “Sending a Patch Series” [1].

[1] https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

> Sent with [ProtonMail](https://protonmail.com) Secure Email.
> From 0e24818db4f22cff0d841b7b77866121e0f2d6a5 Mon Sep 17 00:00:00 2001
> From: Ryan Desfosses <[email-masked]>
> Date: Mon, 7 Dec 2020 18:17:52 -0500
> Subject: [PATCH 1/2] gnu: Add emacs-map
                                         ^
                                         missing dot

[…]

> +    (synopsis "Map manipulation functions")
> +    (description
> +     "map.el provides map-manipulation functions that work on alists,
> +hash-table and arrays.  All functions are prefixed with \"map-\".")

1. “description should start with an upper-case letter or digit” as
reported by "./pre-inst-env guix lint".

2. Istead of ‘\"map-\"’, please use ‘@code{map-}’.

[…]

> Subject: [PATCH 2/2] gnu: Add emacs-burly
                                           ^
                                           missing dot

Pushed with changes above to master.

Oleg.