Subject: Re: [bug#44176] Acknowledgement (gnu: Add bash-ctypes)
From: Ludovic Courtès <[email-masked]>
To: Zhu Zihao <[email-masked]>
Cc: david larsson <[email-masked]>, [email-masked]
Date: Mon, 26 Oct 2020 22:27:58 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Zhu Zihao <[email-masked]> skribis:

> The git version lacks configure script, so we have to generate it first.
> That means we need to add autoconf, automake and libtool to
> native-inputs.
>
> And IIUC Guix's distributing strategy is distribute a release rather
> than rolling on Git. Do you think it's worth to change to git-fetch?

For Autotools-based project, we build from “make dist” tarballs like you
did, so I think it’s fine (we should discuss changing that in the
future.)

>>From 8210f5f95ca4f33dce35ed0c9bb20c8f615ab079 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <[email-masked]>
> Date: Fri, 23 Oct 2020 20:47:04 +0800
> Subject: [PATCH 1/2] gnu: Add bash-ctypes
>
> * gnu/packages/bash.scm(bash-ctypes): New variable.

[...]

>>From 663104a3945696323d893443a3ab0c96c17e07e3 Mon Sep 17 00:00:00 2001
> From: Zhu Zihao <[email-masked]>
> Date: Fri, 23 Oct 2020 23:43:05 +0800
> Subject: [PATCH 2/2] gnu: Use prefix "license:" to import (guix licenses)
>
> * gnu/packages/bash.scm
> (bash, bash-completion, bash-tap, bats, bash-ctypes)[license]:
>
> Rename with prefix "license:".

I tweaked the synopsis/description and applied both.

Thanks!

Ludo’.