Subject: Re: bug#77510: 31.0.50; help-customize fails with multiply defined symbols
From: Dmitry Gutov <[email-masked]>
To: Stephen Berman <[email-masked]>
Cc: [email-masked]
Date: Mon, 14 Apr 2025 03:38:44 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

On 13/04/2025 11:59, Stephen Berman wrote:
>> Like this:
>>
>> diff --git a/lisp/help-fns.el b/lisp/help-fns.el
>> index 6c4c3f4da97..fa7241d3e9d 100644
>> --- a/lisp/help-fns.el
>> +++ b/lisp/help-fns.el
>> @@ -1965,7 +1965,8 @@ describe-symbol
>>            (unless single
>>              ;; Don't record the `describe-variable' item in the stack.
>>              (setq help-xref-stack-item nil)
>> -          (help-setup-xref (list #'describe-symbol symbol) nil))
>> +          (let ((help-mode--current-data help-mode--current-data))
>> +            (help-setup-xref (list #'describe-symbol symbol) nil)))
>>            (goto-char (point-max))
>>            (help-xref--navigation-buttons)
>>            (goto-char (point-min))))))
> I confirm this fixes the issue I reported, so if my patch is
> problematical, I'm fine with yours.  Thanks!

Great! I've pushed this patch to master, thanks for testing.

We can return to other options if some other drawbacks are reported.