Subject: Re: bug#46564: [PATCH core-updates]: Use autoconf-wrapper instead of autoconf
From: Ludovic Courtès <[email-masked]>
To: Maxime Devos <[email-masked]>
Cc: [email-masked]
Date: Wed, 17 Mar 2021 23:12:32 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> skribis:

>> From d42be9473bac6b8bcfe17a37c92f2481cb2198fb Mon Sep 17 00:00:00 2001
>> From: Maxime Devos <[email-masked]>
>> Date: Mon, 22 Feb 2021 16:43:10 +0100
>> Subject: [PATCH] gnu: Use autoconf instead of autoconf-wrapper when possible.
>>
>> This should reduce confusion on when to use the "autoconf"
>> package and when to use "autoconf-wrapper" instead in
>> package definitions.
>>
>> Fixes: <https://issues.guix.gnu.org/46564>
>>
>> * gnu/packages/autotools.scm (autoconf-wrapper):
>>   advise to use the "autoconf" package instead where
>>   possible.
>> * gnu/packages/game-development.scm (tsukundere)[native-inputs]:
>>   use "autoconf" instead of "autoconf-wrapper".
>> * gnu/packages/gimp.scm
>>   (glimpse)[native-inputs]: likewise.
>>   (gimp-resynthesizer)[native-inputs]: add comment on why
>>   "autoconf-wrapper" is used.
>> * gnu/packages/gnunet.scm (gnunet)[native-inputs]:
>>   use "autoconf" instead of "autoconf-wrapper".
>> * gnu/packages/gnupg.scm (signing-party)[native-inputs]:
>>   add comment on why "autoconf-wrapper" is used.
>> * gnu/packages/guile-xyz.scm
>>   (guile-bash,guile-filesystem,guile-ics,guile-udev)[native-inputs]:
>>   use "autoconf" instead of "autoconf-wrapper".
>> * gnu/packages/libevent.scm (libuv)[native-inputs]: indicates
>>   "autoconf-wrapper" needs to be replaced with "autoconf"
>>   on core-updates.
>> * gnu/packages/logging.scm (glog)[native-inputs]: use "autoconf"
>>   instead of "autoconf-wrapper".
>> * gnu/packages/mail.scm (libetpan)[native-inputs]: likewise.
>> * gnu/packages/mate.scm
>>   (mate-icon-theme-faenza)[native-inputs]: add comment on why
>>   "autoconf-wrapper" is used.
>>   (mate-screensaver)[native-inputs]: use "autoconf" instead of
>>   "autoconf-wrapper".
>> * gnu/packages/package-management.scm (guix)[native-inputs]: likewise.
>> * gnu/packages/sawfish.scm (librep)[native-inputs]: likewise.
>> * gnu/packages/video.scm (motion)[native-inputs]: likewise.
>> * gnu/packages/zile.scm (zile)[native-inputs]: likewise.
>
> At first sight it should rebuild much so LGTM!

And I’ve now pushed it.

Thanks, and apologies for forgetting to push it right away!

Ludo’.