Subject: Re: [bug#42282] [PATCH] gnu: Add ttaenc.
From: Marius Bakke <[email-masked]>
To: Alexandros Theodotou <[email-masked]>, [email-masked]
Date: Tue, 21 Jul 2020 00:40:29 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Alexandros Theodotou <[email-masked]> writes:

> Hi,
>
> This patch adds the TTA encoder.

[...]

> * gnu/packages/audio.scm (ttaenc): New variable.

[...]
  
> +(define-public ttaenc
> +  (package
> +    (name "ttaenc")
> +    (version "3.4.1")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "mirror://sourceforge/tta/"
> +                            "tta/ttaenc-src"
> +                            "/ttaenc-" version "-src.tgz"))
> +        (sha256
> +          (base32
> +            "1iixpr4b89g9g1hwn8ak8k8iflcww3r5f09a117qdidc2nqcijdj"))))

If you don't use Emacs, please run ./etc/indent-code.el before
submitting packages.  :-)

> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:make-flags
> +       (list "CC=gcc" (string-append "INSDIR=" (assoc-ref %outputs "out") "/bin"))

I used (string-append "CC=" ,(cc-for-target)) here to aid
cross-compilation.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure) ; no configure
> +         (delete 'check)     ; no check

And added #:tests? #f instead of deleting the phase.

> +        (add-before 'install 'make-bindir
> +          (lambda* (#:key outputs #:allow-other-keys)
> +            (let* ((out (assoc-ref outputs "out")))
> +              (mkdir-p (string-append out "/bin"))
> +              #t))))))
> +    (synopsis "TTA lossless audio encoder")
> +    (description
> +      "TTA performs lossless compression on multichannel 8,16 and 24 bits
> +data of the Wav audio files.  Being lossless means that no data-
> +quality is lost in the compression - when uncompressed, the data will
> +be identical to the original.  The compression ratios of TTA depend on
> +the type of music file being compressed, but the compression size
> +will generally range between 30% - 70% of the original.  TTA format
> +supports both of ID3v1/v2 and APEv2 tags. Detailed format description
> +is available at http://tta.sourceforge.net")

I removed the last sentence, because that URL just redirects to the home
page and did not actually contain a detailed format description.  Also,
it was missing punctuation, and lacked two spaces after the previous
punctuation (did you forget to use 'guix lint'?).

> +    (home-page "http://tausoft.org/")
> +    (license license:gpl2)))

This is GPL2+, as explicitly stated in the README.

Applied with those changes, thanks!