Subject: Re: [bug#40358] Add beancount
From: Christopher Lemmer Webber <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Thu, 02 Apr 2020 11:20:20 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès writes:

> Hello!
>
> Christopher Lemmer Webber <[email-masked]> skribis:
>
>> From 27274e0075f7215693cc4a51482c68ce00167d37 Mon Sep 17 00:00:00 2001
>> From: Christopher Lemmer Webber <[email-masked]>
>> Date: Tue, 31 Mar 2020 16:57:15 -0400
>> Subject: [PATCH] gnu: Add beancount.
>>
>> * gnu/packages/finance.scm (beancount): New variable.
>> * gnu/packages/patches/beancount-disable-googleapis-fonts.patch: New file.
>
> Could you add the patch to gnu/local.mk?

Good call.  Done.

>> +    (home-page "http://furius.ca/beancount")
>> +    (synopsis "Command-line Double-Entry Accounting")
>
> Nitpick: please remote capitals except for the first one, and…

Done.

>> +    (description
>> +     "A double-entry bookkeeping computer language that lets you define
>> +financial transaction records in a text file, read them in memory, generate
>> +a variety of reports from them, and provides a web interface.")
>
> … make it a full sentence.

Okay, done.

>> +++ b/gnu/packages/patches/beancount-disable-googleapis-fonts.patch
>> @@ -0,0 +1,23 @@
>> +From: Nicolas Dandrimont <[email-masked]>
>> +Date: Tue, 1 May 2018 04:49:55 +0200
>> +Subject: Remove fonts.googleapis.com links for the bean-web template
>
> Could you add the URL of the upstream patch or discussion, if any?
>
> OK with these changes!
>
> Thanks,
> Ludo’.

Pushed!  Thanks for your review!