Subject: Re: [bug#38157] [PATCH] gnu: Add font-dseg.
From: Ludovic Courtès <[email-masked]>
To: Alexandros Theodotou <[email-masked]>
Cc: [email-masked], Tobias Geerinckx-Rice <[email-masked]>
Date: Tue, 19 Nov 2019 10:51:19 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Alexandros,

Alexandros Theodotou <[email-masked]> skribis:

> From ec6c88abe3de6346087d821539e43afb3dff42c8 Mon Sep 17 00:00:00 2001
> From: Alexandros Theodotou <[email-masked]>
> Date: Sun, 10 Nov 2019 01:25:28 +0000
> Subject: [PATCH] gnu: Add font-dseg.
>
> * gnu/packages/fonts.scm (font-dseg): New variable.

Nice.  Applied with the minor changes below: addressing a ‘guix lint’
warning, and using an even more appropriate string function.  ;-)

Thanks,
Ludo’.

diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 7fe0aee20b..83c97444bf 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -1537,7 +1537,7 @@ have been designed to be very distinguishable from each other.")
           (string-append "https://github.com/keshikan/DSEG/"
                          "releases/download/v" version
                          "/fonts-DSEG_v"
-                         (apply string-append (string-split version #\.))
+                         (string-concatenate (string-split version #\.))
                          ".zip"))
         (sha256
           (base32
@@ -1561,6 +1561,7 @@ have been designed to be very distinguishable from each other.")
     (home-page "https://www.keshikan.net/fonts-e.html")
     (synopsis "DSEG: 7-segment and 14-segment fonts")
     (description
-     "DSEG is a font family that imitates seven and fourteen segment
-display (7SEG,14SEG). DSEG includes the roman alphabet and symbol glyphs.")
+     "DSEG is a font family that imitates seven- and fourteen-segment LCD
+displays (7SEG, 14SEG).  DSEG includes the roman alphabet and symbol glyphs.
+This package provides the TrueType fonts.")
     (license license:silofl1.1)))