Subject: Re: [bug#69862] [PATCH] update mu to 1.12.2
From: Ludovic Courtès <[email-masked]>
To: Benjamin Slade <[email-masked]>
Cc: [email-masked]
Date: Fri, 22 Mar 2024 11:42:33 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Benjamin Slade <[email-masked]> skribis:

>>From eeaea275fab5141dad07ed01614018a5eb8e0511 Mon Sep 17 00:00:00 2001
> From: Benjamin Slade <[email-masked]>
> Date: Sun, 17 Mar 2024 10:33:02 -0500
> Subject: [PATCH] update mu to 1.12.2
>

I added a commit log that follows our conventions and applied it.

>            (add-after 'unpack 'patch-bin-references
>              (lambda _
>                (substitute* '("guile/tests/test-mu-guile.cc"
> -                             "mu/tests/test-mu-cmd.cc"
> -                             "mu/tests/test-mu-cmd-cfind.cc"
>                               "mu/tests/test-mu-query.cc")
>                  (("/bin/sh") (which "sh")))
>                (substitute* '("lib/tests/bench-indexer.cc"
>                               "lib/utils/mu-test-utils.cc")
> -                (("/bin/rm") (which "rm")))))
> +                (("/bin/rm") (which "rm")))
> +              (substitute* '("lib/mu-maildir.cc")
> +                (("/bin/mv") (which "mv")))))

This won’t do the right thing when cross-compiling.  To fix it, it
should be changed to things like:

  (search-input-file inputs "/bin/mv")

The problem predates this patch of course so it’s not a blocker, but
something to look at going forward.

Thanks,
Ludo’.