Subject: Re: [bug#40083] [PATCH] gnu: Add blktrace.
From: Marius Bakke <[email-masked]>
To: Vincent Legoll <[email-masked]>
Cc: [email-masked], Ludovic Courtès <[email-masked]>
Date: Fri, 20 Mar 2020 18:35:50 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Vincent Legoll <[email-masked]> writes:

> Is that better ?

LGTM.

> I intend to submit the rmtree patch (along a bunch of other cleanups)
> to upstream, will update guix packaging when that will happen...

Great!

[...]
  
> +(define-public blktrace
> +  (let ((commit "f4f8ef7cdea138cfaa2f3ca0ee31fa23d3bcf1cc")
> +        (revision "0"))

I added a comment about why we take this commit instead of the latest
tagged version.

[...]

> +           (add-after 'unpack 'fix-gnuplot-path
> +             (lambda* (#:key inputs #:allow-other-keys)
> +               (let ((gnuplot (assoc-ref inputs "gnuplot")))
> +                 (substitute* "btt/bno_plot.py"
> +                   (("gnuplot %s")
> +                    (string-append gnuplot "/bin/gnuplot %s")))))))))

...and ended this phase on a #t.

Applied!