Subject: Re: bug#26984: Add loksh (ported OpenBSD pdksh)
From: Marius Bakke <[email-masked]>
To: ng0 <[email-masked]>, [email-masked]
Date: Sat, 20 May 2017 02:42:49 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

ng0 <[email-masked]> writes:

> Subject: [PATCH] gnu: Add loksh.
>
> * gnu/packages/shells.scm (loksh): New variable.

Thanks for this patch! I've used this shell a lot on OpenBSD. One
thing it does better than bash is that ^W stops at "/" and other
boundaries, not just spaces!

I've applied it with a slight adjustment to description:

diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index 5035c935a..47d3a4614 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -487,10 +487,10 @@ operating system.")
        (modify-phases %standard-phases
          (delete 'configure)))) ;No configure script
     (home-page "https://github.com/dimkr/loksh")
-    (synopsis "Port of OpenBSD pdksh to Linux")
+    (synopsis "Korn Shell from OpenBSD")
     (description
-     "loksh is a Linux port of OpenBSD's ksh (pdksh).
-It is a small, interactive shell targeted at resource-constrained systems.")
+     "loksh is a Linux port of OpenBSD's @command{ksh}.  It is a small,
+interactive POSIX shell targeted at resource-constrained systems.")
     ;; The file 'LEGAL' says it is the public domain, and the 2
     ;; exceptions which are listed are not included in this port.
     (license public-domain)))

> By the way, this can not be used for the test suite in graphviz.
> There are many ksh implementations, and this is not the one
> the tests accept. Or at least its ksh93 checks fail ;)

Maybe they need "mksh"? Another popular Korn Shell :)