Subject: Re: [bug#44798] [PATCH] gnu: Add emacs-embark
From: Arun Isaac <[email-masked]>
To: Niklas Eklund <[email-masked]>, [email-masked]
Date: Tue, 24 Nov 2020 00:15:09 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

Thanks for the patch! I pushed to master with the following minor edits.

> +  ;; There are no tagged releases upstream on gitlab, instead we are using
> +  ;; the most recent commit.

I think you meant github, not gitlab.

> +  (let ((commit "dc20b4e53c4ce1ad91100dfeb093115f2cc0b210")
> +        (revision "0"))
> +    (package
> +      (name "emacs-embark")
> +      (version (git-version "0.6" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/oantolin/embark")
> +               (commit commit)))
> +         (sha256
> +          (base32 "1jrvdlwip7zll5ixlnk9l0apr8hj60ysqfc47q3k4hhfyl9rawbq"))
> +         (file-name (git-file-name name version))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs
> +       `(("emacs-avy" ,emacs-avy)))
> +      (home-page "https://github.com/oantolin/embark")
> +      (synopsis "Emacs Mini-Buffer Actions Rooted in Keymaps")

I capitalized only the first letter of the first word---Emacs. I
downcased the rest.

> +      (description
> +       "This package provides a command embark-act (and a variant
> +embark-act-noexit), to execute actions on the top minibuffer completion
> +canidate: the one that would be chosen by minibuffer-force-complete")

I started the string "This package..." on the same line as description,
and added a period after minibuffer-force-complete.