Package:  emacs
Severity: minor

	Even though toggle-read-only was marked as obsolete back in
	2012, there’re still a handful of references to it remaining in
	the code, most notably in vc/*.el.  Consider, e. g.:

$ find lisp/ -type f -name \*.el \
      -exec gawk 'FILENAME ~ /\<files\.el$/ || /^\s*[;"]|"$/ { next; }
                  /[^-[:alnum:]]toggle-read-only\>/ {
                      print FILENAME ":" FNR ":\t" $0;
                  }' {} + 
lisp/dired.el:1553:	    (define-key map [remap toggle-read-only] 'dired-toggle-read-only)
lisp/progmodes/hideif.el:192:	     'toggle-read-only 'hide-ifdef-toggle-outside-read-only map)
lisp/vc/vc-hooks.el:637:	  'vc-toggle-read-only 'toggle-read-only "24.1")
lisp/vc/ediff-init.el:1349:	(defvar ediff-toggle-read-only-function 'toggle-read-only
lisp/vc/ediff-util.el:1030:					   'toggle-read-only)
lisp/vc/ediff-util.el:1031:					  (file-writable 'toggle-read-only)
lisp/vc/ediff-util.el:1042:			   (setq toggle-ro-cmd 'toggle-read-only))
lisp/vc/ediff-util.el:1057:			   (setq toggle-ro-cmd 'toggle-read-only)
lisp/vc/ediff-util.el:1063:			 (string-match "toggle-read-only" (symbol-name toggle-ro-cmd)))
$ 

	For one thing, typing A or B in when using Ediff results in the
	respective message:

`toggle-read-only' is an obsolete command (as of 24.3); use `read-only-mode' instead.

	I suggest these be replaced with read-only-mode as appropriate.

	TIA.

-- 
FSF associate member #7257	http://boycottsystemd.org/