This change:

2008-10-14  Chong Yidong  <cyd@stupidchicken.com>

	* faces.el (set-face-attribute): Set family and foundry before
	other attributes.
	(face-spec-set-2): Pass unmodified args to set-face-attribute.

breaks a face definition I have been using without problem for several
years.  Here is the defface in question, which I essentially copied from
an existing defface (I don't remember which, sorry):

(defface todo-filed-item-header
  '((((class color)
      (background dark))
     (:foreground "deep sky blue" :normal t))
    (((class color)
      (background light))
     (:foreground "steel blue" :normal t))
    (t (:foreground "steel blue" :normal t)))
  "Face for filed todo item header string."
  :group 'todo)

When the file containing this is loaded, the error in the Subject is
raised; here is the backtrace: