Subject: Re: [bug#74798] [PATCH] gnu: gdb: Ensure configure-flags are appended to original package
From: Janneke Nieuwenhuizen <[email-masked]>
To: Rutherther via Guix-patches via <[email-masked]>
Cc: [email-masked], Rutherther <[email-masked]>
Date: Wed, 11 Dec 2024 21:02:49 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Rutherther via Guix-patches via writes:

Hello,

> Since recently there has been a change to gdb package that introduced
> configure-flags, three gdb packages broke, since they assumed there are no
> configure-flags in gdb. That means they produced the same gdb as gdb-14.
>
> * gnu/packages/embedded.scm (make-gdb-arm-none-eabi)[arguments]: Append
> configure-flags to original flags.
> * gnu/packages/gdb.scm (gdb-multiarch)[arguments]: Append
> configure-flags to original flags.
> * gnu/packages/gdb.scm (avr-gdb)[arguments]: Append
> configure-flags to original flags.
>
> Change-Id: Ia8748b86dc72197bd4eef307d091b6af44fc5611

Thank you!  And sorry for breaking things :)

I've changed the commit message to

--8<---------------cut here---------------start------------->8---
gnu: gdb: Fix build of target-specific variants.

This is a follow-up to commit
    baf4a3330762d184f5b10846151a9e3afd7c3dbe
    gnu: Add gdb-15.2, with support for the 64bit Hurd.

That commit changed the gdb package, introducing #:configure-flags, breaking
three gdb packages, since they assumed there are no #:configure-flags in gdb.
That means they produced the same gdb as gdb-14.

This patch fixes that by ensuring #:configure-flags are appended to original
package.

* gnu/packages/embedded.scm (make-gdb-arm-none-eabi)[arguments]:
Append #configure-flags to original flags.
(gdb-multiarch)[arguments]: Likewise.
(avr-gdb)[arguments]: Likewise.
--8<---------------cut here---------------end--------------->8---

and pushed to master as 98908e0777889aeec2796dbdc4f0809a1898dd3b.

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <[email-masked]>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com