Subject: Re: [PATCH] gnu: Add emacs-sv-kalender-namnsdagar.
From: Nicolas Goaziou <[email-masked]>
To: [email-masked]
Cc: Spencer King <[email-masked]>
Date: Mon, 19 Aug 2024 19:58:08 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

> * gnu/packages/emacs-xyz.scm (emacs-sv-kalender-namnsdagar): New
> variable.

Thank you. Applied with the following changes.

> +(define-public emacs-sv-kalender-namnsdagar
> +  (package
> +    (name "emacs-sv-kalender-namnsdagar")
> +    (version "20240620.1416")

I set version to 1.0, as specified in main file.

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/matsl/sv-kalender-namnsdagar.git")

I removed the "git" suffix.

> +             (commit "31ef6ac82e448de3db1cf0c37df54581eb9b00f6")))

I let-bound the commit hash at the beginning of the package definition.

Regards,
-- 
Nicolas Goaziou