Subject: Re: [bug#71071] [PATCH] services: nix: Mount Nix store read only.
From: Oleg Pykhalov <[email-masked]>
To: [email-masked]
Cc: Ludovic Courtès <[email-masked]>, Maxim Cournoyer <[email-masked]>
Date: Wed, 29 May 2024 06:32:37 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Maxim and Ludovic.

Maxim Cournoyer <[email-masked]> writes:

>> * gnu/services/nix.scm (nix-shepherd-service): Add requirements.
>> (%nix-store-directory): New variable.
>> (nix-service-type): Add file-system-service-type extension.
>>
>> Change-Id: I73c54ab8699a54be33fac6732d919c4844d1daa4
>
> Nitpick: The Change-Id value shouldn't change between revisions of a
> change (so it should eb the same as in v1, which was
> I18a5d58c92c1f2b5b6dcecc3d5b439cc15bf4e49).

Oh, I wasn't aware of that. Thanks for pointing it out. I've updated the
Change-Id and pushed the commit as
797be0ea5c3703ad96acd32c98dca5f946cf5c95.

[…]

> This LGTM, thanks to Ludo for suggesting this nice improvement in v2.

Yes, thanks for the suggestions. All of them have been implemented.

Regards,
Oleg.