Subject: Re: [bug#70546] [PATCH v2] gnu: cairo: Fix cross-compilation.
From: Zheng Junjie <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked], Vivien Kraus <[email-masked]>, Liliana Marie Prikler <[email-masked]>, Maxim Cournoyer <[email-masked]>
Date: Tue, 14 May 2024 00:37:16 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> writes:

> Hi,
>
> Zheng Junjie <[email-masked]> skribis:
>
>> * gnu/packages/gtk.scm (cairo)[arguments]: Add ‘fix-cross-compilation’ phase
>> when cross-compiling.
>>
>> Change-Id: I3579bb1249c749ee5f164bb4dd47f585b181c2bc
>
> [...]
>
>> +       ,@(if (%current-target-system)
>> +             `(#:phases
>> +               (modify-phases %standard-phases
>> +                 (add-after 'unpack 'fix-cross-compilation
>> +                   (lambda _
>> +                     ;; XXX: Let meson-build-system can customize the property
>
> s/can customize/customize/
>
>> +                     (substitute* "meson.build"
>> +                       (("'ipc_rmid_deferred_release', 'auto'")
>> +                        ;; see https://github.com/NixOS/nixpkgs/blob/df51f2293e935e85f6a2e69bcf89a40cb31bbc3d/pkgs/development/libraries/cairo/default.nix#L65
>> +                        ;; XXX: check it on hurd.
>> +                        "'ipc_rmid_deferred_release', 'true'"))))))
>> +             '())))
>
> Otherwise LGTM, thanks!
>
> Ludo’.

Thanks, push at https://git.savannah.gnu.org/cgit/guix.git/commit/?id=ecfd88cbe34551ebdae92c7c6bb5888bbd0993d6