Subject: Re: [bug#67365] [PATCH core-updates] gnu: gitless: fix definition.
From: Hilton Chain <[email-masked]>
To: Zheng Junjie <[email-masked]>
Cc: [email-masked]
Date: Wed, 22 Nov 2023 20:17:48 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

On Wed, 22 Nov 2023 19:00:17 +0800,
Zheng Junjie wrote:
> 
> gnu/packages/version-control.scm(gitless)[arguments] move #~ to #:phases,
> disable test.
> 
> Change-Id: Ibe3cdbd24fc0b27a15a880a2a45cb0cd8cfde84d
> ---
>  gnu/packages/version-control.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index c366a41342..b687d184c2 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -50,6 +50,7 @@
>  ;;; Copyright © 2023 Nicolas Graves <[email-masked]>
>  ;;; Copyright © 2023 Bruno Victal <[email-masked]>
>  ;;; Copyright © 2023 Kjartan Oli Agustsson <[email-masked]>
> +;;; Copyright © 2023 Zheng Junjie <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -776,9 +777,10 @@ (define-public gitless
>         (file-name (git-file-name name version))))
>      (build-system python-build-system)
>      (arguments
> -     #~(list
> -        #:phases
> -        (modify-phases %standard-phases
> +     (list
> +      #:tests? #f ;; FIXME: fix test
> +      #:phases
> +      #~(modify-phases %standard-phases
>            (add-before 'build 'loosen-requirements
>              (lambda _
>                (substitute* "setup.py"
> 
> base-commit: 1bca46690c6240310befc6208fb24a044bd4b437
> -- 
> 2.41.0

Applied (without the #:tests? change, I'll address it later), thank you!