Subject: Re: bug#67361: 29.1; MH-E: creating a new folder can sometimes fail with a Lisp error
From: Bill Wohler <[email-masked]>
To: Mike Kupfer <[email-masked]>
Cc: [email-masked], Chris Siebenmann <[email-masked]>, Eli Zaretskii <[email-masked]>
Date: Mon, 15 Jan 2024 17:34:45 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Version 30.0.50

Thanks for your patch, Mike.

I did not receive approval to commit this patch to the release branch,
so I committed your patch to master and closed the bug.

Bill Wohler <[email-masked]> wrote:

> Eli,
> 
> Would you prefer if I applied Mike's patch to the emacs-29 branch or
> master?
> 
> > diff --git a/lisp/mh-e/mh-funcs.el b/lisp/mh-e/mh-funcs.el
> > --- a/lisp/mh-e/mh-funcs.el
> > +++ b/lisp/mh-e/mh-funcs.el
> > @@ -108,7 +108,7 @@
> >              (window-config mh-previous-window-config))
> >          (mh-set-folder-modified-p t)    ; lock folder to kill it
> >          (mh-exec-cmd-daemon "rmf" 'mh-rmf-daemon folder)
> > -        (when (boundp 'mh-speed-folder-map)
> > +        (when (and (boundp 'speedbar-buffer) speedbar-buffer)
> >            (mh-speed-invalidate-map folder))
> >          (mh-remove-from-sub-folders-cache folder)
> >          (mh-set-folder-modified-p nil)  ; so kill-buffer doesn't complain
> > diff --git a/lisp/mh-e/mh-search.el b/lisp/mh-e/mh-search.el
> > --- a/lisp/mh-e/mh-search.el
> > +++ b/lisp/mh-e/mh-search.el
> > @@ -1569,7 +1569,7 @@
> >      (save-excursion (mh-exec-cmd-quiet nil "rmf" chosen-name))
> >      (mh-exec-cmd-quiet nil "folder" "-create" "-fast" chosen-name)
> >      (mh-remove-from-sub-folders-cache chosen-name)
> > -    (when (boundp 'mh-speed-folder-map)
> > +    (when (and (boundp 'speedbar-buffer) speedbar-buffer)
> >        (mh-speed-add-folder chosen-name))
> >      chosen-name))
> >  
> > diff --git a/lisp/mh-e/mh-utils.el b/lisp/mh-e/mh-utils.el
> > --- a/lisp/mh-e/mh-utils.el
> > +++ b/lisp/mh-e/mh-utils.el
> > @@ -795,7 +795,7 @@
> >               (message "Creating %s" folder-name)
> >               (mh-exec-cmd-error nil "folder" folder-name)
> >               (mh-remove-from-sub-folders-cache folder-name)
> > -             (when (boundp 'mh-speed-folder-map)
> > +             (when (and (boundp 'speedbar-buffer) speedbar-buffer)
> >                 (mh-speed-add-folder folder-name))
> >               (message "Creating %s...done" folder-name))
> >              (new-file-flag
> > 
> 
> -- 
> Bill Wohler <[email-masked]> aka <[email-masked]>
> http://www.newt.com/wohler/, GnuPG ID:610BD9AD

-- 
Bill Wohler <[email-masked]> aka <[email-masked]>
http://www.newt.com/wohler/, GnuPG ID:610BD9AD