Subject: Re: [bug#65336] [PATCH 0/2] Update looking-glass-client to B6 and restyle package
From: Christopher Baines <[email-masked]>
To: Ahmad Draidi <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Tue, 29 Aug 2023 14:05:06 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Ahmad Draidi via Guix-patches via <[email-masked]> writes:

> This series updates and restyles looking-glass-client, and also restores a
> configuration parameter that was dropped in the previous update patch. Some
> notes for posterity below.
>
> The package builds with "-march=native" GCC parameter by default, which
> makes it incompatible with CPUs older than the build machine and causes
> crashes with "terminated by signal SIGILL (Illegal instruction)" and perhaps
> others. We build it with the minimum supported CPU architecture to fix that.
> This also helps with package reproducibility.
>
> Thanks,
>
> Ahmad Draidi (2):
>   gnu: looking-glass-client: Update to B6.
>   gnu: looking-glass-client: Update package style.
>
>  gnu/packages/virtualization.scm | 146 ++++++++++++++++----------------
>  1 file changed, 73 insertions(+), 73 deletions(-)

Thanks Ahmad, these changes look good to me. I've pushed to master as
02e32197a80e4fc323ffe0e519ad4e58f206fc5d.