Subject: Re: [bug#62138] [PATCH v7] gnu: a2ps: Update to 4.15.3
From: Nicolas Goaziou <[email-masked]>
To: Andy Tai <[email-masked]>
Cc: [email-masked]
Date: Mon, 03 Apr 2023 13:12:07 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Andy Tai <[email-masked]> writes:

> * gnu/packages/pretty-print.scm (a2ps): update to 4.15.3.
>   Remove now unneeded patches.
>
> * gnu/packages/patches/a2ps-CVE-2001-1593.patch,
>   gnu/packages/patches/a2ps-CVE-2014-0466.patch,
>   gnu/packages/patches/a2ps-CVE-2015-8107.patch: Remove

Thank you.

I completed the commit message (missing modification of inputs) and pushed.

>      (inputs
> -     (list psutils gv))
> +     (list psutils file gv libgc libpaper))

I reordered it alphabetically.

> +         (add-after 'unpack 'skio-failed-tests

Typo fixed.

> +           (lambda _
> +                     (substitute* "tests/Makefile.am"
> +                       (("encoding.tst") ""))
> +                     (substitute* "tests/Makefile.am"
> +                       (("prolog-2.tst") ""))
> +                     (substitute* "tests/Makefile.in"
> +                       (("encoding.tst") ""))
> +                     (substitute* "tests/Makefile.in"
> +                       (("prolog-2.tst") ""))))

I simplified the multiple substitute* calls.

Regards,
-- 
Nicolas Goaziou