Subject: Re: bug#60055: [PATCH] scripts: system: Skip initrd modules check when using --target.
From: Maxim Cournoyer <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Wed, 21 Dec 2022 14:24:19 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Ludovic Courtès <[email-masked]> writes:

> Hi,
>
> Maxim Cournoyer <[email-masked]> skribis:
>
>> * guix/scripts/system.scm (perform-action): Do not call CHECK-INITRD-MODULES
>> when the %current-target-system parameter is set.
>
> [...]
>
>> +      (unless (%current-target-system)
>> +        ;; Skip the check if the user is making use of --target, as it doesn't
>> +        ;; make sense in this context.
>> +        (check-initrd-modules os))))
>
> s/doesn’t make sense.*/cannot be checked against the running kernel./
>
> Otherwise LGTM, thanks!

Thanks for precising the comment.  Applied with the suggestion!

-- 
Thanks,
Maxim