Subject: Re: bug#56756: [PATCH] gnu: services: Add optional fix for opensmtpd executables group
From: Ludovic Courtès <[email-masked]>
To: Maya <[email-masked]>
Cc: [email-masked]
Date: Mon, 01 Aug 2022 11:51:33 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Maya,

Maya <[email-masked]> skribis:

> This is a patch that fixes "<executable name>: this program must be setgid smtpq". As this cannot be done in the store during build, but the upstream opensmtpd requires to set the group of those executables.
>
> ---
>  gnu/services/mail.scm | 67 +++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 65 insertions(+), 2 deletions(-)

That sounds like a welcome improvement.

I applied the patch with a few changes:

  • Changed the option name from ‘set-gids?’ to ‘setgid-commands?’,
    which I think is slightly clearer.

  • Tweaked and moved its documentation to ‘doc/guix.texi’.

  • Adjusted the commit log as per our conventions (see
    <https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html>).

Thank you!

Ludo’.