Subject: Re: bug#56387: [PATCH] computed-file: Clarify comment about guile record field.
From: Maxim Cournoyer <[email-masked]>
To: jgart <[email-masked]>
Cc: [email-masked]
Date: Thu, 07 Jul 2022 17:39:31 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi jgart,

jgart <[email-masked]> writes:

> * guix/gexp.scm (<computed-file>): Clarify that what goes in the guile
> record field is any variant of a guile package record instance.
> ---
>  guix/gexp.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/gexp.scm b/guix/gexp.scm
> index ef92223048..eba65e92cf 100644
> --- a/guix/gexp.scm
> +++ b/guix/gexp.scm
> @@ -581,7 +581,7 @@ (define-record-type <computed-file>
>    computed-file?
>    (name       computed-file-name)                 ;string
>    (gexp       computed-file-gexp)                 ;gexp
> -  (guile      computed-file-guile)                ;<package>
> +  (guile      computed-file-guile)                ;<package guile-*>
>    (options    computed-file-options))             ;list of arguments

If this was a statically typed language, the proper type of the argument
accepted would be <package>, not <package guile-*>, so I'm inclined to
leave it the way it is (also, we'd have to survey the whole code base to
adjust for our current convention, which is to use <package>).

Closing,

Thanks,

Maxim