Subject: Re: bug#55518: [PATCH] gnu: Add python-gatt.
From: Ludovic Courtès <[email-masked]>
To: "Wamm K. D" <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Sat, 28 May 2022 00:02:35 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

I added a commit log and applied with the changes below, as suggested by
Tobias (for the description).

The inputs are propagated because, for instance, the code reads:

--8<---------------cut here---------------start------------->8---
try:
    import dbus
    import dbus.mainloop.glib
except ImportError:
    import sys
    print("Module 'dbus' not found")
    print("Please run: sudo apt-get install python3-dbus")
    print("See also: https://github.com/getsenic/gatt-python#installing-gatt-sdk-for-python")
    sys.exit(1)
--8<---------------cut here---------------end--------------->8---

Thus, if you install python-gatt in a profile, python-dbus should be
propagated as well so it “just works”.

Thanks,
Ludo’.

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index d706906a9d..fe1896efca 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -31806,32 +31806,35 @@ (define-public python-srt
 composing subtitles in the SRT file format.")
     (license license:expat)))
 
-(define python-gatt
+(define-public python-gatt
   (package
     (name "python-gatt")
     (version "0.2.7")
     (source (origin
               (method url-fetch)
               (uri (pypi-uri "gatt" version))
-              (sha256 (base32
-                       "0fjf066jixk30fr8xwfalwfnhqpr56yv0cccyypnx2qp9bi9svb2"))))
-    (inputs (list python-dbus python-pygobject))
+              (sha256
+               (base32
+                "0fjf066jixk30fr8xwfalwfnhqpr56yv0cccyypnx2qp9bi9svb2"))))
+    (propagated-inputs (list python-dbus python-pygobject))
     (build-system python-build-system)
     (home-page "https://github.com/getsenic/gatt-python")
     (synopsis "Bluetooth GATT SDK for Python")
     (description "The Bluetooth @acronym{GATT, Generic ATTribute Profile}
-@acronym{SDK, Software Development Kit} for Python helps you implementing and
-communicating with any Bluetooth Low Energy device that has a @acronym{GATT}
+@acronym{SDK, Software Development Kit} for Python helps you implement and
+communicate with any Bluetooth Low Energy device that has a GATT
 profile.  It supports:
+
 @itemize @bullet
 @item Discovering nearby Bluetooth Low Energy devices
 @item Connecting and disconnecting devices
-@item Implementing your custom @acronym{GATT} profile
-@item Accessing all @acronym{GATT} services
-@item Accessing all @acronym{GATT} characteristics
+@item Implementing your custom GATT profile
+@item Accessing all GATT services
+@item Accessing all GATT characteristics
 @item Reading characteristic values
 @item Writing characteristic values
 @item Subscribing for characteristic value change notifications
 @end itemize
+
 Currently, Linux is the only platform supported by this library.")
     (license license:expat)))