Subject: Re: [bug#54232] [PATCH 1/2] gnu: python-daemon: Use the git repo as source instead of pypi.
From: Maxime Devos <[email-masked]>
To: Attila Lendvai <[email-masked]>
Cc: [email-masked]
Date: Thu, 03 Mar 2022 15:46:15 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Attila Lendvai schreef op do 03-03-2022 om 14:42 [+0000]:
> > Also, how does this address the test failure? The pypi and git are
> > at
> > the same version. Did upstream adjust the 'release/2.3.0' tag in
> > place
> > or something?
> 
> sorry for not being clear enough! sending this patch was essentially
> a mistake: the tests do work fine.
> 
> probably i have added the disabling of the test prior to the
> SUBSTITUTE* (that
> is basically a backport of the fix commit in upstream), and when i
> rebased some
> pending changes, then i mistakenly included the now irrelevant
> disabling.
> 
> feel free to apply or reject this as you see fit. it's not important
> for me to build from git, even though i also find it better. probably
> the software heritage archives also work better with git.

They do support tarballs to some degree, and disarchive to some degree
compensates for mismatches.  I don't know how well this works in
practice.

Anyway, I'm closing for now, but if it is discussed on guix-devel@ with
a positive conclusion, feel free to reopen.

Greetings,
Maxime.